From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergio.gonzalez.monroy@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 524625A96
 for <dev@dpdk.org>; Wed, 11 Feb 2015 11:51:31 +0100 (CET)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga103.fm.intel.com with ESMTP; 11 Feb 2015 02:44:25 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.09,558,1418112000"; d="scan'208";a="453065586"
Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99])
 by FMSMGA003.fm.intel.com with ESMTP; 11 Feb 2015 02:36:51 -0800
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.64]) by
 IRSMSX107.ger.corp.intel.com ([169.254.10.75]) with mapi id 14.03.0195.001;
 Wed, 11 Feb 2015 10:51:28 +0000
From: "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>
To: Panu Matilainen <pmatilai@redhat.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH] mk: fix missing link of librte_vhost in
 shared,	non-combined config
Thread-Index: AQHQRdg/FWQQjFD2zUSEP+OlIsTOXZzrQzQQ
Date: Wed, 11 Feb 2015 10:51:27 +0000
Message-ID: <91383E96CE459D47BCE92EFBF5CE73B004F4AB6C@IRSMSX108.ger.corp.intel.com>
References: <6ca22ee1257e34ee2b89f2fb354d6c382b8f3e29.1423644785.git.pmatilai@redhat.com>
In-Reply-To: <6ca22ee1257e34ee2b89f2fb354d6c382b8f3e29.1423644785.git.pmatilai@redhat.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] mk: fix missing link of librte_vhost in
 shared, non-combined config
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Feb 2015 10:51:31 -0000

Hi Panu,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Panu Matilainen
> Sent: Wednesday, February 11, 2015 8:53 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] mk: fix missing link of librte_vhost in share=
d,
> non-combined config
>=20
> When building shared, non-combined library, librte_vhost does not get
> linked in, causing among other things vhost example to fail building to d=
o
> undefined symbols on linkage.
>=20
> Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
> ---
>  mk/rte.app.mk | 4 ++++
>  1 file changed, 4 insertions(+)
>=20
> diff --git a/mk/rte.app.mk b/mk/rte.app.mk index 95dbb0b..55d989e 100644
> --- a/mk/rte.app.mk
> +++ b/mk/rte.app.mk
> @@ -125,6 +125,10 @@ LDLIBS +=3D -lm
>  LDLIBS +=3D -lrt
>  endif
>=20
> +ifeq ($(CONFIG_RTE_LIBRTE_VHOST), y)
> +LDLIBS +=3D -lrte_vhost
> +endif
> +
>  endif # ! CONFIG_RTE_BUILD_COMBINE_LIBS
>=20
>  ifeq ($(CONFIG_RTE_LIBRTE_PMD_PCAP),y)
> --
> 2.1.0

I think that vhost is being linked in the wrong place (plugins section).
The plugins only get linked when building static libraries.
I think the patch should also remove vhost from the plugins section.

Regards,
Sergio