From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id CBDED1B1DC; Wed, 3 Jan 2018 15:12:50 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 05E406C009E; Wed, 3 Jan 2018 14:12:49 +0000 (UTC) Received: from [192.168.38.17] (84.52.114.114) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Wed, 3 Jan 2018 14:12:42 +0000 To: Olivier Matz CC: Ivan Malov , Igor Ryzhov , , Thomas Monjalon , Laurent Hardy , Ferruh Yigit , References: <20171214171531.10506-1-olivier.matz@6wind.com> <20171219092932.5k5sg3eemfghatkl@glumotte.dev.6wind.com> <20180103134358.rc4funbiws5mlimh@platinum> <20180103135409.jwltlb45hfhnqwoh@platinum> From: Andrew Rybchenko Message-ID: <91395f4d-9f40-943b-245a-1858aec91588@solarflare.com> Date: Wed, 3 Jan 2018 17:12:37 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180103135409.jwltlb45hfhnqwoh@platinum> Content-Language: en-GB X-Originating-IP: [84.52.114.114] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.100.1062-23570.004 X-TM-AS-Result: No--16.337300-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-MDID: 1514988769-04I+I0h4NZK3 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] ethdev: fix setting of MAC address X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Jan 2018 14:12:51 -0000 On 01/03/2018 04:54 PM, Olivier Matz wrote: > On Wed, Jan 03, 2018 at 02:43:59PM +0100, Olivier Matz wrote: >> I've walked through the PMDs as suggested by Andrew, and there was >> indeed some conflicts with the initial patch. I've just submitted the >> patch for vmxnet3 [1] and bnxt [2]. >> >> But there is still an issue with the qede driver, that overwrites the >> MAC address in dev->data by the previous one if it cannot be set. It >> seems it's the only driver that does this in error case, but anyway, >> this behavior will be broken by the initial patch. >> >> So I submitted a v2 that only changes the behavior for i40evf [3]. >> >> I propose to include these 3 patches for 18.02, and announce an ABI >> change for 18.05 to add a return value to dev_ops->mac_addr_set() and >> move the ether_addr_copy() after the callback, only in case of success. >> >> Any opinions? I'm not sure if dev_ops->mac_addr_set() is a part of ABI. It is an internal interface between rte_ethdev library and drivers. Yes, out-of-tree drivers will be broken. rte_eth_dev_default_mac_addr_set() is definitely a part of API/ABI, but it already has return value. So, I'm not sure that we have to wait for 18.05, but it is still may be too late for 18.02 since integration deadline is pretty close. > [1] https://dpdk.org/dev/patchwork/patch/32855/ > [2] https://dpdk.org/dev/patchwork/patch/32856/ > [3] https://dpdk.org/dev/patchwork/patch/32857/ Many thanks for drivers review and fixes.