From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C30034339F; Thu, 23 Nov 2023 00:27:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 79C7D402BD; Thu, 23 Nov 2023 00:27:31 +0100 (CET) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id 85CF040262 for ; Thu, 23 Nov 2023 00:27:29 +0100 (CET) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 128B53200A30; Wed, 22 Nov 2023 18:27:27 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Wed, 22 Nov 2023 18:27:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1700695647; x=1700782047; bh=0CBmFz493czwNa40TgfSS9DDQC3oJ2SkW4b l4d89G0M=; b=p5Ye7mrtKsonp9a74VpPoo3qqVhWzuEJiqrxDylUCGE0twSTrE9 aCb7odPp4nIvyoN2aSoXpDVScKqGk8c8UF/nscmI0dDppgdepa0G9JNFd2FMrsoL jhp9V4KPKLv1GfNLQ7QuLO7Kq+yEiq1cfn41e2D39AFsEEYG5P0k+E+B7XUPY/n+ TNBo+EOiS7fI1VxFqQgkFIg1Ely/HSkNZ6FVd/e8lGx0s9O1a8eM7wuYUkIEdjea caRkXvvRCXg/+7wy21pFPwUnxlhnAkpDcwMd72AaCN58R303njjS5C9f/02erZL5 TmsqKvQb/z+V9mdI+q5m9PhwXQkspYBUgwA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1700695647; x=1700782047; bh=0CBmFz493czwNa40TgfSS9DDQC3oJ2SkW4b l4d89G0M=; b=ogc+EZdBR9td5xyzuN8GlzE2y1nc2f1qm5hMj6v4k8YzEvG7glw 6JBTkP8UQmQrZ1u8/wNq3PIGtBtg37oRbkp71CwTqbPe+9FUCwZtwqimVaJFjBhn N6E95EGifvWuoDs8Wqg3g2hYhe6NRuE5akbdBd+2aQubQbH4pTzCXc/3MTmzeExb CZHuBa4h3s2Tl+ClyJjfECIRzSU03OjgG1ZGaX6BiIa6NZppsRE+VnTlTDRk7m6e fxh0sFMDlwfYD7+VtW9KzpBig6i9XjZP/eDEEUWkCW+K1cVb06PhgnROnp/if3pf e2turrZwszsqqQjQ2HtoKDAT2HfP2KFf6aQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudehvddguddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 22 Nov 2023 18:27:26 -0500 (EST) From: Thomas Monjalon To: Robin Jarry , Stephen Hemminger , Jerin Jacob , fengchengwen Cc: dev@dpdk.org, skori@marvell.com Subject: Re: [PATCH 1/2] usertools/rss: add driver abstractions Date: Thu, 23 Nov 2023 00:27:24 +0100 Message-ID: <9141995.lOV4Wx5bFT@thomas> In-Reply-To: References: <20231023080710.240402-3-rjarry@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 22/11/2023 10:37, fengchengwen: > On 2023/11/22 16:28, Robin Jarry wrote: > > Stephen Hemminger, Nov 21, 2023 at 18:27: > >> On Tue, 21 Nov 2023 22:51:19 +0530 > >> Jerin Jacob wrote: > >> > IMO, That may be too much of non-productive work to save a couple of > >> > lines(seed array) of duplicate code between c and python. > >> > >> But the tool is incomplete right now, it doesn't cover all the drivers. > > > > I agree that having a standard API or mechanism for drivers to expose their default redirection table size and hash seed key would be nice. The script could have a dynamically generated section that is populated during the build based on selected drivers. > > > > However, it would make the python script dependant on it and it would not be a standalone tool anymore. This is not a blocking issue but something to keep in mind. > > The usertools/dpdk-pmdinfo.py will parse dpdk elf to get some information, We could do same thing in here. We can imagine different things to avoid listing few RSS keys in this script. For now, this series is an improvement, so I take it. Feel free to follow-up with more enhancements.