From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3362DA04E7; Mon, 2 Nov 2020 19:54:58 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 47FBD1DBD; Mon, 2 Nov 2020 19:54:56 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 9E64E1D9E for ; Mon, 2 Nov 2020 19:54:53 +0100 (CET) IronPort-SDR: qqrdF8kvBW8w9fAzHaWYuPnkkcF990FO3baHnBnetzi5ADidnMxOF3riuU3LxSbdWbCG2AzirH kicP6Sra8tZg== X-IronPort-AV: E=McAfee;i="6000,8403,9793"; a="156713101" X-IronPort-AV: E=Sophos;i="5.77,445,1596524400"; d="scan'208";a="156713101" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2020 10:54:51 -0800 IronPort-SDR: cCBtmdXvP9qpS9Nd6cWdIdhuSU02vXcc2aS9NmDHzDTiopmDtZD645upkFIb9TldLnlb2Wgq8m 5ioEe8Wry1QA== X-IronPort-AV: E=Sophos;i="5.77,445,1596524400"; d="scan'208";a="538126144" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.219.143]) ([10.213.219.143]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2020 10:54:50 -0800 To: Ivan Malov , dev@dpdk.org, Andrey Vesnovaty Cc: Xueming Li , Ori Kam , Thomas Monjalon , Andrew Rybchenko References: <20201029114644.22169-1-ivan.malov@oktetlabs.ru> <20201102114317.24492-1-ivan.malov@oktetlabs.ru> From: Ferruh Yigit Message-ID: <914ca03f-69ed-9cb0-44a3-1a3bf9af79f7@intel.com> Date: Mon, 2 Nov 2020 18:54:48 +0000 MIME-Version: 1.0 In-Reply-To: <20201102114317.24492-1-ivan.malov@oktetlabs.ru> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3 1/2] ethdev: introduce transfer attribute to shared action conf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/2/2020 11:43 AM, Ivan Malov wrote: > In a flow rule, attribute "transfer" means operation level > at which both traffic is matched and actions are conducted. > > Add the very same attribute to shared action configuration. > If a driver needs to prepare HW resources in two different > ways, depending on the operation level, in order to set up > an action, then this new attribute will indicate the level. > Also, when handling a flow rule insertion, the driver will > be able to turn down a shared action if its level is unfit. > > Signed-off-by: Ivan Malov > Acked-by: Ori Kam > --- > lib/librte_ethdev/rte_flow.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h > index a8eac4deb..8b970ba0b 100644 > --- a/lib/librte_ethdev/rte_flow.h > +++ b/lib/librte_ethdev/rte_flow.h > @@ -3487,6 +3487,14 @@ struct rte_flow_shared_action_conf { > /**< Action valid for rules applied to ingress traffic. */ > uint32_t egress:1; > /**< Action valid for rules applied to egress traffic. */ > + > + /** > + * When set to 1, indicates that the action is valid for > + * transfer traffic; otherwise, for non-transfer traffic. > + * > + * See struct rte_flow_attr. > + */ > + uint32_t transfer:1; Is this require any documentation update? Also cc'ed Andrey, as he is author of the shared action feature, @Andrey can you please review this update?