From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 56DD61E35 for ; Sat, 3 Feb 2018 16:34:28 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id BC01C6C005B; Sat, 3 Feb 2018 15:34:26 +0000 (UTC) Received: from [192.168.38.17] (84.52.114.114) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Sat, 3 Feb 2018 15:34:21 +0000 To: Bruce Richardson CC: , Ivan Malov References: <1517575438-8609-1-git-send-email-arybchenko@solarflare.com> <1517575438-8609-2-git-send-email-arybchenko@solarflare.com> <20180202161829.GC20444@bricha3-MOBL3.ger.corp.intel.com> From: Andrew Rybchenko Message-ID: <915e76b2-504d-c142-a5d6-da0658d39d7e@solarflare.com> Date: Sat, 3 Feb 2018 18:33:51 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180202161829.GC20444@bricha3-MOBL3.ger.corp.intel.com> Content-Language: en-GB X-Originating-IP: [84.52.114.114] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.100.1062-23638.004 X-TM-AS-Result: No--14.297000-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-MDID: 1517672067-8m4tW4nMQtyf Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 2/2] net/sfc: add support for meson build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Feb 2018 15:34:28 -0000 On 02/02/2018 07:18 PM, Bruce Richardson wrote: > On Fri, Feb 02, 2018 at 12:43:58PM +0000, Andrew Rybchenko wrote: >> From: Ivan Malov >> >> Signed-off-by: Ivan Malov >> Signed-off-by: Andrew Rybchenko >> --- >> drivers/net/meson.build | 2 +- >> drivers/net/sfc/base/meson.build | 69 ++++++++++++++++++++++++++++++++++++++++ >> drivers/net/sfc/meson.build | 61 +++++++++++++++++++++++++++++++++++ >> 3 files changed, 131 insertions(+), 1 deletion(-) >> create mode 100644 drivers/net/sfc/base/meson.build >> create mode 100644 drivers/net/sfc/meson.build > Hi, > > looks pretty good in general. I have a few comments below to improve > things. > > Unfortunately, this will break the ARM builds in it's current form too > (or at least it broke the builds using the cross-files that I tested). > I think you need to add a check at the top of the driver meson.build > file for unsupported architectures, and set "build = false" for those > platforms. Many thanks for review notes. Hopefully we have processed everything. It looks like x86 is the common for 64-bit and 32-bit. In theory we do not supported 32-bit x86 with make. I've tried to build on 32-bit host with meson/ninja and the build fails but earlier than our driver: ../dpdk-next-net/lib/librte_kni/rte_kni.c: In function ‘kni_allocate_mbufs’: ../dpdk-next-net/lib/librte_kni/rte_kni.c:669:2: error: size of unnamed array is negative   RTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, data_off) !=   ^~~~~~~~~~~~~~~~ ../dpdk-next-net/lib/librte_kni/rte_kni.c:671:2: error: size of unnamed array is negative   RTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, data_len) !=   ^~~~~~~~~~~~~~~~ ../dpdk-next-net/lib/librte_kni/rte_kni.c:673:2: error: size of unnamed array is negative   RTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, pkt_len) !=   ^~~~~~~~~~~~~~~~ ../dpdk-next-net/lib/librte_kni/rte_kni.c:675:2: error: size of unnamed array is negative   RTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, ol_flags) !=   ^~~~~~~~~~~~~~~~ ../dpdk-next-net/lib/librte_kni/rte_kni.c: At top level: cc1: warning: unrecognized command line option ‘-Wno-format-truncation’ cc1: warning: unrecognized command line option ‘-Wno-address-of-packed-member’ [26/498] Compiling C object 'lib/rte_port@sta/rte_port_kni.c.o'. ninja: build stopped: subcommand failed. It is Debian stretch. gcc (Debian 6.3.0-18) 6.3.0 20170516 Does the build on 32-bit x86 work for you? bash$ meson --version 0.42.1 bash$ ninja --version 1.7.2 Build using make works fine. Andrew.