From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 588691B218 for ; Tue, 31 Oct 2017 19:24:44 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id DE31120D12; Tue, 31 Oct 2017 14:24:43 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Tue, 31 Oct 2017 14:24:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=U0LQSexzf6WdKEGWK967vcoDnX UQi4jlvlaUAwJJPcs=; b=r43mv9nJU78Pdi3fII4HZljKYeHwDnTYtG/MCpwahH 9aw2UkxYfxlYsGUJlSuDG+ksfr+dPYORBPI2eP6Wgm2AGdnKI9PUne+Lobq3+P5T c1GjoijOifyPY71xgqbHDAignZmWgPpp6s9HRMd8r8QRT3CoTgyck8yPb6tJrQLo E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=U0LQSe xzf6WdKEGWK967vcoDnXUQi4jlvlaUAwJJPcs=; b=IOTWVBmUBOvi5PIJ4L+f7a SVXlVNEz+BaX5h485Jcf946lvcxuHqJJlqeSyX7iBC7TX7pBXOK0AHg57zrlQCCW 0YL388GjbEB8qY9k44rfqJYLY7WjFQSkBE2+QRDV+lokJXkiNykDDx7Qvegeq3/R T0uHx8k7feNVBgqD3Zr3q/qNFZ9XnDZSythmlCqcso+9VKtFfTv9RyMDja9BEp84 ds+yOdroJqtlc+0eJ7xvWjV4rMhhY6MWi7IRZDj3efFDwWtKye6yqUttDMjR0rrS s+KezZYacTpxy+4fnDm9IB/Y77kpLhisH1kbFdIMYjhDbnAZ1vUATrMvJBbc0KDg == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 668277F96B; Tue, 31 Oct 2017 14:24:43 -0400 (EDT) From: Thomas Monjalon To: Jerin Jacob Cc: dev@dpdk.org, Jonas Pfefferle1 , Anatoly Burakov Date: Tue, 31 Oct 2017 19:24:42 +0100 Message-ID: <9161630.57FQBGedkL@xps> In-Reply-To: References: <20171028062255.11910-1-jerin.jacob@caviumnetworks.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] bus/pci: fix vfio device reset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Oct 2017 18:24:44 -0000 28/10/2017 12:54, Jonas Pfefferle1: > Jerin Jacob wrote on 28/10/2017 08:22:55: > > If the device is not capable of resetting, then Linux kernel updates > > the errno as EINVAL. > > https://urldefense.proofpoint.com/v2/url? > > u=http-3A__elixir.free-2Delectrons.com_linux_v4. > > 9_source_drivers_vfio_pci_vfio-5Fpci.c-23L887&d=DwIBAg&c=jf_iaSHvJObTbx- > > siA1ZOg&r=rOdXhRsgn8Iur7bDE0vgwvo6TC8OpoDN-pXjigIjRW0&m=V- > > sbOkvx7qxOMbwyk3n1Fb_1NCjAhl0io- > > hqldJ0r6M&s=OXV7lrxTpahVIsA3J3nCNUlLqW21nlMiQiYveAzyQhc&e= > > > > Honor the EINVAL errno value to avoid pci vfio setup failure. > > > > Fixes: f25f8f367644 ("bus/pci: check VFIO reset ioctl error") > > > > Cc: Jonas Pfefferle > > Cc: Anatoly Burakov > > > > Signed-off-by: Jerin Jacob > > Looks good to me. > > Reviewed-by: Jonas Pfefferle > > Thanks, > Jonas Applied, thanks