From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Yuan Linsi <yuanlinsi01@baidu.com>,
ajit.khaparde@broadcom.com, somnath.kotur@broadcom.com,
lance.richardson@broadcom.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix a possible stack smashing
Date: Fri, 1 May 2020 00:55:51 +0100 [thread overview]
Message-ID: <9171fcaf-8ffb-47e7-621e-9f4066cf8e1d@intel.com> (raw)
In-Reply-To: <1588253872-19024-1-git-send-email-yuanlinsi01@baidu.com>
On 4/30/2020 2:37 PM, Yuan Linsi wrote:
> From: yuanlinsi01 <yuanlinsi01@baidu.com>
>
> We see a stack smashing as a result of defensive code missing. Once the
> nb_pkts is less than RTE_BNXT_DESCS_PER_LOOP, it will be modified to
> zero after doing a floor align, and we can not exit the following
> receiving packets loop. And the buffers will be overwrite, then the
> stack frame was ruined.
>
> Fix the problem by adding defensive code, once the nb_pkts is zero, just
> directly return with no packets.
>
> Fixes: bc4a000f2 ("net/bnxt: implement SSE vector mode")
> Cc: stable@dpdk.org
>
> Signed-off-by: yuanlinsi01 <yuanlinsi01@baidu.com>
> Signed-off-by: rongdongsheng <rongdongsheng@baidu.com>
Hi Yuan,
For the sign-off tag, we need "Name Surname <email@adress.com>" syntax,
for you I can see from mail thread that it is:
"Signed-off-by: Linsi Yuan <yuanlinsi01@baidu.com>"
Can you please share the same for the other sign-off, 'rongdongsheng'?
next prev parent reply other threads:[~2020-04-30 23:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 13:37 Yuan Linsi
2020-04-30 13:45 ` Lance Richardson
2020-04-30 18:29 ` Ajit Khaparde
2020-04-30 23:55 ` Ferruh Yigit [this message]
2020-05-05 3:42 ` Ajit Khaparde
2020-05-06 3:18 ` [dpdk-dev] 答复: " Yuan,Linsi
-- strict thread matches above, loose matches on Subject: below --
2020-05-06 3:28 [dpdk-dev] " Yuan Linsi
2020-05-06 5:26 ` Ajit Khaparde
2020-05-06 3:18 Yuan Linsi
2020-04-30 12:05 yuanlinsi01
2020-04-30 12:55 ` Somnath Kotur
2020-04-30 13:33 ` [dpdk-dev] 答复: " Yuan,Linsi
2020-04-30 10:08 [dpdk-dev] " yuanlinsi01
2020-04-30 10:07 yuanlinsi01
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9171fcaf-8ffb-47e7-621e-9f4066cf8e1d@intel.com \
--to=ferruh.yigit@intel.com \
--cc=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=lance.richardson@broadcom.com \
--cc=somnath.kotur@broadcom.com \
--cc=yuanlinsi01@baidu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).