From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 81184A04F5; Thu, 12 Dec 2019 13:01:59 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 41181374C; Thu, 12 Dec 2019 13:01:58 +0100 (CET) Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by dpdk.org (Postfix) with ESMTP id 85E042BD3 for ; Thu, 12 Dec 2019 13:01:57 +0100 (CET) Received: by mail-wm1-f66.google.com with SMTP id d5so2199919wmb.4 for ; Thu, 12 Dec 2019 04:01:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=9tD9n6TVirA5ep5pjReczyz26qBjVsfuPBdyow/Q31E=; b=Oj09f0OuDPLGa5ayfRypXKuEtKRiusO1RzrrPPUsqX7KDR3lNfTYfBxybe6SccAJEO juHbo5EcS9Vy7NqCV+um8oXA8y3swiqXYmMLIwfEku0mfACEQyE7g+kOx0DlNZEuEQY/ IG9lisA6Ex/11soSGLIbkZVW/GkR+vZhJz1ffZpqf56SawaCJbwhq9OudsEd3SZPuj3W gtPaQodGw8xLqdUDeOV8jerK4iJNUgqkNRj4TfigKD/nJI38iLgbj2dEpvgoOS5jXTcn o0gEmoPYwhYFxTh6wvbeEqajhS7/yjcoSCuksoSYqpmxc/cUIziPvVUJVZdiwrAcSLit eAGw== X-Gm-Message-State: APjAAAWoZJPEisgOn0SfaxvCTHvtn6vHabsgmzp+Kum51IFN/YxDDZ8n xZ4RVSiJMxYJZ2VZ2L5IbLY= X-Google-Smtp-Source: APXvYqwL/cpK7UjDcE5PhGJZyiII76aLwvTMXB6bmbv/Ag+E9XdTK+YnNYFRtVfLPh5DIymjZ1dW4w== X-Received: by 2002:a1c:23d7:: with SMTP id j206mr5964201wmj.39.1576152117152; Thu, 12 Dec 2019 04:01:57 -0800 (PST) Received: from [192.168.1.118] (host31-202-dynamic.33-79-r.retail.telecomitalia.it. [79.33.202.31]) by smtp.gmail.com with ESMTPSA id x10sm5748408wrv.60.2019.12.12.04.01.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Dec 2019 04:01:56 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3601.0.10\)) From: Alfredo Cardigliano In-Reply-To: <60a8f721-1241-52ca-6fa0-467c017e9102@intel.com> Date: Thu, 12 Dec 2019 13:01:52 +0100 Cc: Thomas Monjalon , John McNamara , Marko Kovacevic , dev@dpdk.org Content-Transfer-Encoding: quoted-printable Message-Id: <917A33B2-883F-4585-843C-98C1BE8FBCA2@ntop.org> References: <20191209214656.27347-1-cardigliano@ntop.org> <20191209214656.27347-2-cardigliano@ntop.org> <60a8f721-1241-52ca-6fa0-467c017e9102@intel.com> To: Ferruh Yigit X-Mailer: Apple Mail (2.3601.0.10) Subject: Re: [dpdk-dev] [PATCH v3 01/17] net/ionic: add skeleton X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > On 10 Dec 2019, at 19:48, Ferruh Yigit wrote: >=20 > On 12/9/2019 9:46 PM, Alfredo Cardigliano wrote: >> Add makefile and config file options to compile the Pensando ionic = PMD. >> Add feature and version map file. >> Update maintainers file. >>=20 >> Signed-off-by: Alfredo Cardigliano >> Reviewed-by: Shannon Nelson >=20 > <...> >=20 >> @@ -277,6 +277,11 @@ CONFIG_RTE_LIBRTE_E1000_DEBUG_TX=3Dn >> CONFIG_RTE_LIBRTE_E1000_DEBUG_TX_FREE=3Dn >> CONFIG_RTE_LIBRTE_E1000_PF_DISABLE_STRIP_CRC=3Dn >>=20 >> +# >> +# Compile Pensando IONIC PMD driver >> +# >> +CONFIG_RTE_LIBRTE_IONIC_PMD=3Dy >> + >=20 > Is the driver supported by BSD platform or i686, arm, PPC = architectures? If not > can you please disable the PMD on those config files? I guess setting =E2=80=99n=E2=80=99 in defconfig_* will override = common_base settings. Is there any documentation that I can check for this? Thank you. > <...> >=20 >> diff --git a/doc/guides/nics/ionic.rst b/doc/guides/nics/ionic.rst >> new file mode 100644 >> index 000000000..41eac0f6b >> --- /dev/null >> +++ b/doc/guides/nics/ionic.rst >> @@ -0,0 +1,37 @@ >> +.. SPDX-License-Identifier: (BSD-3-Clause OR GPL-2.0) >> + Copyright(c) 2018-2019 Pensando Systems, Inc. All rights = reserved. >> + >> +IONIC Driver >> +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> + >> +The ionic driver provides support for Pensando server adapters. >> +Please visit https://pensando.io for more information about the >> +adapters. >=20 > Thanks for providing the company link, that was useful. But also can = you please > provide a link that has the details of the device that 'ionic' driver = is for. > I can see some documentation related to Naples DSC-xx devices but I = assume they > are something else. > Btw, related to the HW you are providing the driver for, is it = publicly > available now or are the documentation like specs/datasheets provided = publicly? The website is fairly new and more docs will be available soon from = https://pensando.io/platform Product briefs are available at the moment from the same page, is it = fine to link them? https://pensando.io/assets/documents/Naples_100_ProductBrief-10-2019.pdf https://pensando.io/assets/documents/Naples-25_ProductBrief_10-2019.pdf > <...> >=20 >> diff --git a/drivers/net/ionic/Makefile b/drivers/net/ionic/Makefile >> new file mode 100644 >> index 000000000..d2c2b53b3 >> --- /dev/null >> +++ b/drivers/net/ionic/Makefile >> @@ -0,0 +1,38 @@ >> +# SPDX-License-Identifier: (BSD-3-Clause OR GPL-2.0) >> +# Copyright(c) 2018-2019 Pensando Systems, Inc. All rights reserved. >> + >> +include $(RTE_SDK)/mk/rte.vars.mk >> + >> +# >> +# library name >> +# >> +LIB =3D librte_pmd_ionic.a >> + >> +CFLAGS +=3D -O3 >> +CFLAGS +=3D $(WERROR_FLAGS) >> + >> +EXPORT_MAP :=3D rte_pmd_ionic_version.map >> + >> +ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y) >> +# >> +# CFLAGS for icc >> +# >> + >> +else ifeq ($(CONFIG_RTE_TOOLCHAIN_CLANG),y) >> +# >> +# CFLAGS for clang >> +# >> + >> +else >> +# >> +# CFLAGS for gcc >> +# >> + >> +endif >=20 > I would suggest only add these when you really have some CFLAGS to = add. >=20 >> + >> +# >> +# all source are stored in SRCS-y >> +# >> +SRCS-$(CONFIG_RTE_LIBRTE_IONIC_PMD) +=3D >=20 > The SHARED library build is failing because of "undefined reference" = to some > internal libraries. > You need to add "LDLIBS" as you use them in patches, same thing for = meson. Thank you Alfredo