From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 5D4BBDE0 for ; Mon, 13 Feb 2017 17:05:47 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Feb 2017 08:05:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,156,1484035200"; d="scan'208";a="1125983860" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga002.fm.intel.com with ESMTP; 13 Feb 2017 08:05:36 -0800 Received: from fmsmsx108.amr.corp.intel.com ([169.254.9.130]) by fmsmsx107.amr.corp.intel.com ([169.254.6.78]) with mapi id 14.03.0248.002; Mon, 13 Feb 2017 08:05:35 -0800 From: "Eads, Gage" To: "Richardson, Bruce" , Jerin Jacob CC: "dev@dpdk.org" , "hemant.agrawal@nxp.com" , "Van Haaren, Harry" , "nipun.gupta@nxp.com" Thread-Topic: [PATCH] eventdev: Add rte_errno return values to the enqueue and dequeue functions Thread-Index: AQHSheVitwdUjKxUsEC59Jlrj0d4iKFnWGuAgAAFl4D//7kgAA== Date: Mon, 13 Feb 2017 16:05:35 +0000 Message-ID: <9184057F7FC11744A2107296B6B8EB1E01E65A58@FMSMSX108.amr.corp.intel.com> References: <1486760541-12568-1-git-send-email-gage.eads@intel.com> <20170213103854.GB377356@bricha3-MOBL3.ger.corp.intel.com> <20170213114810.GA32617@localhost.localdomain> <20170213120811.GA11468@bricha3-MOBL3.ger.corp.intel.com> In-Reply-To: <20170213120811.GA11468@bricha3-MOBL3.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzIwYmRkOWEtN2FlZi00ZWVlLTkzNjgtNTlhNjY4NjU0ODA3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IngxenRlcEhWWUZHbTRCb2piYXk1NnFGWk83b3BJaFUyRThTN1Z1ZlN5elU9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.1.200.108] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] eventdev: Add rte_errno return values to the enqueue and dequeue functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Feb 2017 16:05:49 -0000 > -----Original Message----- > From: Richardson, Bruce > Sent: Monday, February 13, 2017 6:08 AM > To: Jerin Jacob > Cc: Eads, Gage ; dev@dpdk.org; > hemant.agrawal@nxp.com; Van Haaren, Harry ; > nipun.gupta@nxp.com > Subject: Re: [PATCH] eventdev: Add rte_errno return values to the enqueu= e and > dequeue functions > =20 > On Mon, Feb 13, 2017 at 05:18:11PM +0530, Jerin Jacob wrote: > > On Mon, Feb 13, 2017 at 10:38:55AM +0000, Bruce Richardson wrote: > > > On Fri, Feb 10, 2017 at 03:02:21PM -0600, Gage Eads wrote: > > > > This change allows user software to differentiate between an > > > > invalid argument (such as an invalid queue_id or sched_type in an > > > > enqueued event) and backpressure from the event device. > > > > > > > > The port and device ID checks are placed in > > > > RTE_LIBRTE_EVENTDEV_DEBUG header guards to avoid the performance > hit in non-debug execution. > > > > > > > > Signed-off-by: Gage Eads > > > > --- > > > > > > Do we have some idea of the performance hit from these? It may be > > > too soon to know, given we don't have many drivers to test with, but > > > if there is no perf hit seen with the SW driver, I think we should > > > look to just always do this, rather than having it compile-time off. > > > If it does > > > > IMO, It is better put to under compile-time like ethdev. It is > > difficult predict the performance regression on wide range of cores > > that DPDK runs now. I think we need to add following additional checks > > based on Gage header file change > > > > 1) Per event queue ID is valid or not? > > 2) Per event's sched type doesn't match the capabilities of the destin= ation > queue. > > > =20 > Ok, if we are expanding the number of checks then I definitely think it = needs to > be compile-time selected. My thinking is that, unlike checking the dev ID or port ID, per-event check= s should be in the PMD itself since (presumably) it will loop over the even= ts anyway. I also think it makes sense for the per-event error checking not= to be compile-time selectable because a PMD needs to handle the invalid qu= eue ID or sched_type case anyway. > =20 > /Bruce > > > > > prove to be a performance problem we can look to #ifdef it out later= . > > > > > > /Bruce