From: "Eads, Gage" <gage.eads@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] mk: use extra cflags when linking libs with a compiler
Date: Mon, 31 Jul 2017 21:46:06 +0000 [thread overview]
Message-ID: <9184057F7FC11744A2107296B6B8EB1E01EFF618@FMSMSX108.amr.corp.intel.com> (raw)
In-Reply-To: <2807565.BH6kPGmNW3@xps>
Sure, will fix that now. I was just waiting for any other feedback to include in a v2.
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Monday, July 31, 2017 4:44 PM
> To: Eads, Gage <gage.eads@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] mk: use extra cflags when linking libs with a
> compiler
>
> 25/07/2017 17:03, Gage Eads:
> > When using the compiler to link libraries, include EXTRA_CFLAGS. This
> > is needed when cross-compiling to pass --sysroot, for example. GCC
> > cross-compilers built with Yocto don't use the --with-sysroot option,
> > making it necessary to pass the --sysroot command-line option.
> >
> > This is the same solution as in commit e8fbb6d9cfd9 ("mk: use extra
> > cflags when linking with compiler"), but applied to libs instead of apps.
> > ---
> > mk/rte.lib.mk | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> You forgot the Signed-off-by line.
next prev parent reply other threads:[~2017-07-31 21:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 15:03 Gage Eads
2017-07-31 21:44 ` Thomas Monjalon
2017-07-31 21:46 ` Eads, Gage [this message]
2017-07-31 21:49 ` [dpdk-dev] [PATCH v2] " Gage Eads
2017-07-31 21:56 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9184057F7FC11744A2107296B6B8EB1E01EFF618@FMSMSX108.amr.corp.intel.com \
--to=gage.eads@intel.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).