From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id D41DA7CBB for ; Mon, 31 Jul 2017 23:46:08 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Jul 2017 14:46:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,304,1498546800"; d="scan'208";a="884826675" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by FMSMGA003.fm.intel.com with ESMTP; 31 Jul 2017 14:46:07 -0700 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 31 Jul 2017 14:46:07 -0700 Received: from fmsmsx108.amr.corp.intel.com ([169.254.9.74]) by FMSMSX110.amr.corp.intel.com ([169.254.14.38]) with mapi id 14.03.0319.002; Mon, 31 Jul 2017 14:46:07 -0700 From: "Eads, Gage" To: Thomas Monjalon CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] mk: use extra cflags when linking libs with a compiler Thread-Index: AQHTCkY6BdI0SgC0EkmBoIKn+auGWaJueBcw Date: Mon, 31 Jul 2017 21:46:06 +0000 Message-ID: <9184057F7FC11744A2107296B6B8EB1E01EFF618@FMSMSX108.amr.corp.intel.com> References: <1500995026-20707-1-git-send-email-gage.eads@intel.com> <2807565.BH6kPGmNW3@xps> In-Reply-To: <2807565.BH6kPGmNW3@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNmNkNjY5NGYtMGVhMy00NTdmLWIwNTgtMWJmNGI2MjA3NGIwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IlBWTWVvQklTMmtaMUVKbWE0SGQyZUQ1RVNWVVljY0lzQzNBd2lrWCtEV289In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.1.200.106] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] mk: use extra cflags when linking libs with a compiler X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2017 21:46:09 -0000 Sure, will fix that now. I was just waiting for any other feedback to inclu= de in a v2. > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Monday, July 31, 2017 4:44 PM > To: Eads, Gage > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] mk: use extra cflags when linking libs wi= th a > compiler >=20 > 25/07/2017 17:03, Gage Eads: > > When using the compiler to link libraries, include EXTRA_CFLAGS. This > > is needed when cross-compiling to pass --sysroot, for example. GCC > > cross-compilers built with Yocto don't use the --with-sysroot option, > > making it necessary to pass the --sysroot command-line option. > > > > This is the same solution as in commit e8fbb6d9cfd9 ("mk: use extra > > cflags when linking with compiler"), but applied to libs instead of app= s. > > --- > > mk/rte.lib.mk | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > You forgot the Signed-off-by line.