From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id F00BC1D90 for ; Mon, 11 Dec 2017 17:15:43 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Dec 2017 08:15:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,392,1508828400"; d="scan'208";a="10951315" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by FMSMGA003.fm.intel.com with ESMTP; 11 Dec 2017 08:15:42 -0800 Received: from fmsmsx108.amr.corp.intel.com ([169.254.9.23]) by FMSMSX105.amr.corp.intel.com ([169.254.4.125]) with mapi id 14.03.0319.002; Mon, 11 Dec 2017 08:15:42 -0800 From: "Eads, Gage" To: Pavan Nikhilesh , "jerin.jacobkollanukkaran@cavium.com" , "Van Haaren, Harry" , "Rao, Nikhil" , "hemant.agrawal@nxp.com" , "Ma, Liang J" CC: "dev@dpdk.org" Thread-Topic: [PATCH 01/13] examples/eventdev: add Rx adapter support Thread-Index: AQHTb5tV4Vmgppf2W0qZijcaDLf7mqM+Ul7Q Date: Mon, 11 Dec 2017 16:15:41 +0000 Message-ID: <9184057F7FC11744A2107296B6B8EB1E2BB1623A@FMSMSX108.amr.corp.intel.com> References: <20171207203705.25020-1-pbhagavatula@caviumnetworks.com> <20171207203705.25020-2-pbhagavatula@caviumnetworks.com> In-Reply-To: <20171207203705.25020-2-pbhagavatula@caviumnetworks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTJjYTViMzUtNjkzYi00MDBmLTk1YmQtMmU5MjEwMjgxMmI4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IjBZSWFqa3YyR1FnMGczTFF2aW1LckNRb0dQMEk5c3NVcGRaY2hLTGFNRlE9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.1.200.106] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 01/13] examples/eventdev: add Rx adapter support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Dec 2017 16:15:44 -0000 Hi Pavan, > static inline void > schedule_devices(unsigned int lcore_id) { > if (fdata->rx_core[lcore_id] && (fdata->rx_single || > rte_atomic32_cmpset(&(fdata->rx_lock), 0, 1))) { > - producer(); > + rte_service_run_iter_on_app_lcore(fdata->rxadptr_service_id, > 1); > rte_atomic32_clear((rte_atomic32_t *)&(fdata->rx_lock)); > } The (rx_single || cmpset(rx_lock)) check should no longer be needed -- this= logic is provided in rte_service_run_iter_on_app_lcore() and service_run()= . The rx_lock can be dropped in general. > + if (port_needed) > + prod_data.port_id =3D cons_data.port_id + 1; > + prod_data.dev_id =3D evdev_id; > + prod_data.qid =3D cdata.qid[0]; > + Is prod_data still needed? Looks like we're only using it in main() to prin= t the port ID (which may not be valid, depending on if port_needed is true)= . Thanks, Gage