From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id A37E72030 for ; Tue, 12 Dec 2017 16:59:26 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Dec 2017 07:59:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,395,1508828400"; d="scan'208";a="11923232" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga004.fm.intel.com with ESMTP; 12 Dec 2017 07:59:25 -0800 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 12 Dec 2017 07:59:25 -0800 Received: from fmsmsx108.amr.corp.intel.com ([169.254.9.23]) by FMSMSX109.amr.corp.intel.com ([169.254.15.83]) with mapi id 14.03.0319.002; Tue, 12 Dec 2017 07:59:24 -0800 From: "Eads, Gage" To: Pavan Nikhilesh Bhagavatula , "jerin.jacobkollanukkaran@cavium.com" , "Van Haaren, Harry" , "Rao, Nikhil" , "hemant.agrawal@nxp.com" , "Ma, Liang J" CC: "dev@dpdk.org" Thread-Topic: [PATCH 01/13] examples/eventdev: add Rx adapter support Thread-Index: AQHTb5tV4Vmgppf2W0qZijcaDLf7mqM+Ul7QgAGX9wD///lFAA== Date: Tue, 12 Dec 2017 15:59:24 +0000 Message-ID: <9184057F7FC11744A2107296B6B8EB1E2BB16F44@FMSMSX108.amr.corp.intel.com> References: <20171207203705.25020-1-pbhagavatula@caviumnetworks.com> <20171207203705.25020-2-pbhagavatula@caviumnetworks.com> <9184057F7FC11744A2107296B6B8EB1E2BB1623A@FMSMSX108.amr.corp.intel.com> <20171212081757.aarmhwpaduvgjaic@Pavan-LT> In-Reply-To: <20171212081757.aarmhwpaduvgjaic@Pavan-LT> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmFiYmI2ZGYtZTRiZC00ZGFmLThjYmMtNzE0ZmE3YjM4NmJlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Imp1SVZzcXpMTmdxVkpweDBNREJ4UlwvOURTWnF5eVY0SnVoamtycEtVdHZJPSJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.1.200.106] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 01/13] examples/eventdev: add Rx adapter support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Dec 2017 15:59:27 -0000 > -----Original Message----- > From: Pavan Nikhilesh Bhagavatula > [mailto:pbhagavatula@caviumnetworks.com] > Sent: Tuesday, December 12, 2017 2:18 AM > To: Eads, Gage ; > jerin.jacobkollanukkaran@cavium.com; Van Haaren, Harry > ; Rao, Nikhil ; > hemant.agrawal@nxp.com; Ma, Liang J > Cc: dev@dpdk.org > Subject: Re: [PATCH 01/13] examples/eventdev: add Rx adapter support >=20 > On Mon, Dec 11, 2017 at 04:15:41PM +0000, Eads, Gage wrote: > > Hi Pavan, > > > > > > > > > static inline void > > > schedule_devices(unsigned int lcore_id) { > > > if (fdata->rx_core[lcore_id] && (fdata->rx_single || > > > rte_atomic32_cmpset(&(fdata->rx_lock), 0, 1))) { > > > - producer(); > > > + rte_service_run_iter_on_app_lcore(fdata->rxadptr_service_id, > > > 1); > > > rte_atomic32_clear((rte_atomic32_t *)&(fdata->rx_lock)); > > > } > > > > The (rx_single || cmpset(rx_lock)) check should no longer be needed -- = this > logic is provided in rte_service_run_iter_on_app_lcore() and service_run(= ). The > rx_lock can be dropped in general. > > >=20 > we could either remove the example level locks (or) keep the locks at app= lication > level and disable them in service api through > rte_service_run_iter_on_app_lcore(, 0). >=20 > If we choose to remove example level locks we could do something like > rte_service_run_iter_on_app_lcore(id, !rx_single) >=20 That sounds good. No need to duplicate code that the EAL provides, and it s= implifies the example. Thanks, Gage