DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Eads, Gage" <gage.eads@intel.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Cc: "jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>,
	"santosh.shukla@caviumnetworks.com"
	<santosh.shukla@caviumnetworks.com>,
	Hemant Agrawal <hemant.agrawal@nxp.com>,
	"nipun.gupta@nxp.com" <nipun.gupta@nxp.com>,
	"Van Haaren, Harry" <harry.van.haaren@intel.com>,
	"Richardson, Bruce" <bruce.richardson@intel.com>
Subject: [dpdk-dev] Documenting eventdev reconfiguration behavior
Date: Tue, 9 Jan 2018 17:00:16 +0000	[thread overview]
Message-ID: <9184057F7FC11744A2107296B6B8EB1E369CE6E6@fmsmsx101.amr.corp.intel.com> (raw)

Hi folks,

As mentioned in a previous thread*, the eventdev documentation is unclear on what the user can expect when a device is stopped, possibly re-configured, and restarted. The documentation states that:

* If the application wants to change the configuration (i.e. call
* rte_event_dev_configure(), rte_event_queue_setup(), or
* rte_event_port_setup()), it must call rte_event_dev_stop() first to stop the
* device and then do the reconfiguration before calling rte_event_dev_start()
* again. The schedule, enqueue and dequeue functions should not be invoked
* when the device is stopped.

And:

/**
* Stop an event device. The device can be restarted with a call to
* rte_event_dev_start()
*
* @param dev_id
*   Event device identifier.
*/
void
rte_event_dev_stop(uint8_t dev_id);

Specifically, the documentation is unclear on whether events that are queued in the device when rte_event_dev_stop() is called will remain there after rte_event_dev_start()? And does this depend on whether rte_event_dev_configure() or rte_event_queue_setup() are called? (There are probably other aspects that need clarification, but this is a starting point.)

Hopefully we can agree on a common behavior, or else perhaps capabilities flags are in order. I propose we take the (in my view) simplest approach, that eventdevs will not preserve events when a device is stopped and restarted. (Thus to avoid memory leaks, the application is responsible for flushing events out of the device before stopping it.) This is simple to support in the sw PMD, and I would expect this to be simpler for hardware devices as well.

Thoughts?

Thanks,
Gage

*http://dpdk.org/ml/archives/dev/2018-January/085777.html

             reply	other threads:[~2018-01-09 17:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-09 17:00 Eads, Gage [this message]
2018-01-11  7:30 ` Jerin Jacob
2018-01-16 16:59   ` Eads, Gage

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9184057F7FC11744A2107296B6B8EB1E369CE6E6@fmsmsx101.amr.corp.intel.com \
    --to=gage.eads@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=harry.van.haaren@intel.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=jerin.jacob@caviumnetworks.com \
    --cc=nipun.gupta@nxp.com \
    --cc=santosh.shukla@caviumnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).