From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id A3440A495 for ; Mon, 2 Apr 2018 17:51:00 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Apr 2018 08:50:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,396,1517904000"; d="scan'208";a="30091399" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga007.jf.intel.com with ESMTP; 02 Apr 2018 08:50:43 -0700 Received: from fmsmsx108.amr.corp.intel.com ([169.254.9.102]) by fmsmsx107.amr.corp.intel.com ([169.254.6.119]) with mapi id 14.03.0319.002; Mon, 2 Apr 2018 08:50:43 -0700 From: "Eads, Gage" To: Jerin Jacob CC: "Van Haaren, Harry" , "dev@dpdk.org" , "hemant.agrawal@nxp.com" , "Richardson, Bruce" , "santosh.shukla@caviumnetworks.com" , "nipun.gupta@nxp.com" Thread-Topic: [PATCH v4 2/2] event/sw: support device stop flush callback Thread-Index: AQHTwFWrAIMN3FoguUye7ASWWY9UZaPeD2RwgAULYqCACov3AIAABsvQ Date: Mon, 2 Apr 2018 15:50:42 +0000 Message-ID: <9184057F7FC11744A2107296B6B8EB1E3FA8B5B6@FMSMSX108.amr.corp.intel.com> References: <1521087130-20244-1-git-send-email-gage.eads@intel.com> <1521555187-25710-1-git-send-email-gage.eads@intel.com> <1521555187-25710-2-git-send-email-gage.eads@intel.com> <9184057F7FC11744A2107296B6B8EB1E3FA88B56@FMSMSX108.amr.corp.intel.com> <20180402080305.GB7280@jerin> In-Reply-To: <20180402080305.GB7280@jerin> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWRiOTdiZjktYTA0MC00NWZhLTkwNmQtOTJlYWRlMGEwOTcyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkFmbWJBSk1WYWV3UHM5eXNCbjg3VXJZMHdmbzhlUnZGa1NZXC94Z1Bad3JrPSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.1.200.108] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 2/2] event/sw: support device stop flush callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Apr 2018 15:51:01 -0000 If it's ok with you, I'll resubmit these two patches separately. The sw imp= lementation has some unresolved race conditions with the scheduler service = that may take some time to fix, but this shouldn't block the first patch. T= hat patch needs a fix too (v4 includes a now-incorrect comment about stop n= ot draining events from ports), so I'll fix and resubmit that. Thanks, Gage > -----Original Message----- > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > Sent: Monday, April 2, 2018 3:03 AM > To: Eads, Gage > Cc: Van Haaren, Harry ; dev@dpdk.org; > hemant.agrawal@nxp.com; Richardson, Bruce ; > santosh.shukla@caviumnetworks.com; nipun.gupta@nxp.com > Subject: Re: [PATCH v4 2/2] event/sw: support device stop flush callback >=20 > > > [Update: Ah I see you do this below already. Still, better check > > > twice I think, the data path isn't running here anyway in case > > > future me decides to call > > > sw_flush_iq() without performing the check] > > > > Agreed, will fix in v5. >=20 > Gage, >=20 > Could please send the v5 so that I can include it in RC1 pull request. >=20