From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <gage.eads@intel.com> Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 5F2845920 for <dev@dpdk.org>; Wed, 3 Apr 2019 22:49:12 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Apr 2019 13:49:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,306,1549958400"; d="scan'208";a="139759390" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga003.jf.intel.com with ESMTP; 03 Apr 2019 13:49:11 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 3 Apr 2019 13:49:09 -0700 Received: from fmsmsx108.amr.corp.intel.com ([169.254.9.216]) by FMSMSX112.amr.corp.intel.com ([169.254.5.23]) with mapi id 14.03.0415.000; Wed, 3 Apr 2019 13:49:09 -0700 From: "Eads, Gage" <gage.eads@intel.com> To: Thomas Monjalon <thomas@monjalon.net> CC: "dev@dpdk.org" <dev@dpdk.org>, "olivier.matz@6wind.com" <olivier.matz@6wind.com>, "arybchenko@solarflare.com" <arybchenko@solarflare.com>, "Richardson, Bruce" <bruce.richardson@intel.com>, "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, "gavin.hu@arm.com" <gavin.hu@arm.com>, "Honnappa.Nagarahalli@arm.com" <Honnappa.Nagarahalli@arm.com>, "nd@arm.com" <nd@arm.com> Thread-Topic: [dpdk-dev] [PATCH v7 0/8] Add stack library and new mempool handler Thread-Index: AQHU6l106HJcq+HQzkaheTjzG/xNHaYq58Yg Date: Wed, 3 Apr 2019 20:49:08 +0000 Message-ID: <9184057F7FC11744A2107296B6B8EB1E542107EF@FMSMSX108.amr.corp.intel.com> References: <20190401211429.20282-1-gage.eads@intel.com> <20190403200916.16349-1-gage.eads@intel.com> <4770051.yqIPWfFot0@xps> In-Reply-To: <4770051.yqIPWfFot0@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTA1NWZkNjQtNTE5My00Yjc5LWI5MDAtODg0MjA0ODhiMTlhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWUQ5b2dLTG1qNEx2WlRLMmF5azR1U082RWR0YjE1dHdxSnJBTG4yUVVjQzJ5cGwyNXlGZDdEeUYrek92aVRRbyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.1.200.107] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v7 0/8] Add stack library and new mempool handler X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 03 Apr 2019 20:49:13 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Wednesday, April 3, 2019 3:40 PM > To: Eads, Gage <gage.eads@intel.com> > Cc: dev@dpdk.org; olivier.matz@6wind.com; arybchenko@solarflare.com; > Richardson, Bruce <bruce.richardson@intel.com>; Ananyev, Konstantin > <konstantin.ananyev@intel.com>; gavin.hu@arm.com; > Honnappa.Nagarahalli@arm.com; nd@arm.com > Subject: Re: [dpdk-dev] [PATCH v7 0/8] Add stack library and new mempool > handler >=20 > 03/04/2019 22:09, Gage Eads: > > v7: > > - Add rte_branch_prediction.h include to rte_stack_std.h for unlikely() > > - Add rte_compat.h include to rte_stack.h for __rte_experimental >=20 > There is another error when compiling for Arm: >=20 > lib/librte_stack/rte_stack.h:76:2: error: > implicit declaration of function 'RTE_ASSERT' Fix incoming. Looking through the rest of that header, I don't see any othe= r externally defined macros/data structures/functions/etc. that would need = another include. Also note that v7's ci/Performance-Testing build fail (http://mails.dpdk.or= g/archives/test-report/2019-April/079261.html) is because dpdklab applied t= he patch on commit 3c45889189924067, which is older than the 128-bit CAS pa= tch. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 206BDA0679 for <public@inbox.dpdk.org>; Wed, 3 Apr 2019 22:49:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 30D7B5F36; Wed, 3 Apr 2019 22:49:14 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 5F2845920 for <dev@dpdk.org>; Wed, 3 Apr 2019 22:49:12 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Apr 2019 13:49:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,306,1549958400"; d="scan'208";a="139759390" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga003.jf.intel.com with ESMTP; 03 Apr 2019 13:49:11 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 3 Apr 2019 13:49:09 -0700 Received: from fmsmsx108.amr.corp.intel.com ([169.254.9.216]) by FMSMSX112.amr.corp.intel.com ([169.254.5.23]) with mapi id 14.03.0415.000; Wed, 3 Apr 2019 13:49:09 -0700 From: "Eads, Gage" <gage.eads@intel.com> To: Thomas Monjalon <thomas@monjalon.net> CC: "dev@dpdk.org" <dev@dpdk.org>, "olivier.matz@6wind.com" <olivier.matz@6wind.com>, "arybchenko@solarflare.com" <arybchenko@solarflare.com>, "Richardson, Bruce" <bruce.richardson@intel.com>, "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, "gavin.hu@arm.com" <gavin.hu@arm.com>, "Honnappa.Nagarahalli@arm.com" <Honnappa.Nagarahalli@arm.com>, "nd@arm.com" <nd@arm.com> Thread-Topic: [dpdk-dev] [PATCH v7 0/8] Add stack library and new mempool handler Thread-Index: AQHU6l106HJcq+HQzkaheTjzG/xNHaYq58Yg Date: Wed, 3 Apr 2019 20:49:08 +0000 Message-ID: <9184057F7FC11744A2107296B6B8EB1E542107EF@FMSMSX108.amr.corp.intel.com> References: <20190401211429.20282-1-gage.eads@intel.com> <20190403200916.16349-1-gage.eads@intel.com> <4770051.yqIPWfFot0@xps> In-Reply-To: <4770051.yqIPWfFot0@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTA1NWZkNjQtNTE5My00Yjc5LWI5MDAtODg0MjA0ODhiMTlhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWUQ5b2dLTG1qNEx2WlRLMmF5azR1U082RWR0YjE1dHdxSnJBTG4yUVVjQzJ5cGwyNXlGZDdEeUYrek92aVRRbyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.1.200.107] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v7 0/8] Add stack library and new mempool handler X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Message-ID: <20190403204908.xoMdK4How4arjONf_gal5MoIhekHF8xb-jCmCaACk9U@z> > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Wednesday, April 3, 2019 3:40 PM > To: Eads, Gage <gage.eads@intel.com> > Cc: dev@dpdk.org; olivier.matz@6wind.com; arybchenko@solarflare.com; > Richardson, Bruce <bruce.richardson@intel.com>; Ananyev, Konstantin > <konstantin.ananyev@intel.com>; gavin.hu@arm.com; > Honnappa.Nagarahalli@arm.com; nd@arm.com > Subject: Re: [dpdk-dev] [PATCH v7 0/8] Add stack library and new mempool > handler >=20 > 03/04/2019 22:09, Gage Eads: > > v7: > > - Add rte_branch_prediction.h include to rte_stack_std.h for unlikely() > > - Add rte_compat.h include to rte_stack.h for __rte_experimental >=20 > There is another error when compiling for Arm: >=20 > lib/librte_stack/rte_stack.h:76:2: error: > implicit declaration of function 'RTE_ASSERT' Fix incoming. Looking through the rest of that header, I don't see any othe= r externally defined macros/data structures/functions/etc. that would need = another include. Also note that v7's ci/Performance-Testing build fail (http://mails.dpdk.or= g/archives/test-report/2019-April/079261.html) is because dpdklab applied t= he patch on commit 3c45889189924067, which is older than the 128-bit CAS pa= tch.