From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 47769A0487 for ; Mon, 1 Jul 2019 11:57:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B9CE42BC8; Mon, 1 Jul 2019 11:57:57 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 891F72BB5 for ; Mon, 1 Jul 2019 11:57:55 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Jul 2019 02:57:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,438,1557212400"; d="scan'208,217";a="163637248" Received: from klaatz-mobl1.ger.corp.intel.com (HELO [10.237.221.70]) ([10.237.221.70]) by fmsmga008.fm.intel.com with ESMTP; 01 Jul 2019 02:57:53 -0700 To: David Marchand Cc: dev , Thomas Monjalon References: <1561635235-22238-1-git-send-email-david.marchand@redhat.com> <1561635235-22238-9-git-send-email-david.marchand@redhat.com> <2284715.k64COaWSDv@xps> From: "Laatz, Kevin" Message-ID: <918800d8-3777-0b50-93d1-ec35a7062e72@intel.com> Date: Mon, 1 Jul 2019 10:57:52 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 8/9] remove experimental tags from all symbol definitions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 29/06/2019 07:19, David Marchand wrote: > On Sat, Jun 29, 2019 at 7:57 AM David Marchand > > wrote: > > On Fri, Jun 28, 2019 at 9:20 PM David Marchand > > wrote: > > > On Fri, Jun 28, 2019 at 5:57 PM Thomas Monjalon > > wrote: > > 27/06/2019 13:33, David Marchand: > > We had some inconsistencies between functions prototypes > and actual > > definitions. > > Let's avoid this by only adding the experimental tag to > the prototypes. > > Tests with gcc and clang show it is enough. > > > > git grep -l __rte_experimental |grep \.c$ |while read > file; do > >       sed -i -e '/^__rte_experimental$/d' $file; > >       sed -i -e 's/ *__rte_experimental//' $file; > >       sed -i -e 's/__rte_experimental *//' $file; > > done > > There is one miss: > > rte_telemetry_parse is not flagged as experimental > but is listed in version map > Please add __rte_experimental to the definition of > rte_telemetry_parse > > > Not sure I get you. > How did you get this warning? > > > Ah ok, this library is disabled by default. > Another fix being cooked. > > Expect a v2 maybe later today, but I still need an answer on which > approach we take :-) > > > Reducing the CC: list. > > So, the reason why it is not flagged is that rte_telemetry_parser.h is > not included in rte_telemetry_parser.c. > But then I wondered why we did not see it. > rte_telemetry Makefile does not add WERROR_FLAGS in its CFLAGS. > If I try to add it, we have an avalanche of warnings for trivial > things like symbol not marked as static, and a more bizarre "null" > string passed as a marker that something went bad. > > I will send the fix on the missing header as part of my series. > But please Kevin, fix the rest of the warnings and add WERROR_FLAGS in > the lib Makefile. > We noticed this too and are working on a patch for this :-) Thanks, Kevin > Thanks. > > -- > David Marchand