From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D38F1431E0; Mon, 23 Oct 2023 10:47:49 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8A32140270; Mon, 23 Oct 2023 10:47:49 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 2A4A240262 for ; Mon, 23 Oct 2023 10:47:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698050867; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Kuwd8+IwY528IEXrsQ81kq74kl5p7Im8kmfRE6RYkmo=; b=Wv1a3Bm/PfDWCvS2wzDJLu5TU8lkuKLGiILBAL6XmRRCik53SgGcE8uR8QrF0BYa0H+AJ/ iT4fYHPUj+++4O9aW6TJJMDUt3sHifh69qbbZAnZNvKub+MRuNiQoZIf1UzJqcbYo612E5 IbRz00g9sQCd2jblO+wzmKfD47BLRHY= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-198-Ze2C-xStNh69oC-766AVQw-1; Mon, 23 Oct 2023 04:47:40 -0400 X-MC-Unique: Ze2C-xStNh69oC-766AVQw-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4083fec2c30so17991225e9.1 for ; Mon, 23 Oct 2023 01:47:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698050859; x=1698655659; h=content-transfer-encoding:in-reply-to:subject:from:content-language :references:cc:to:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Kuwd8+IwY528IEXrsQ81kq74kl5p7Im8kmfRE6RYkmo=; b=rb2BqBojvfIHu3Aj9qLnfpynlBO8oVCL4QQeXFQIL2fM962T9sTOZxh3kz5hRyE4qW 32vsYu0gFYqDAjc332LDUDdVlzcKUPpRJdrlxjhF9z/jbDGhNzu9yrghwFU8YWrKgpJr Oa0vfjTM8AJKVVM1NjQuJpLYS7EzrL5Hzx12SkfffwIhIHnUKdjs5gwLOvhm/q4QyaQg k1Yak6l/PejVcWKnw4OA5jnFcVsDcLxfB3d+evfkXYytcUmJ+fT1Vn7pbiCPEmqWs+Kp XfcQm7o20LnU5YtH6bw/8NDPgwTVYGnnm8rEbgHdgK0kWlAskfNsRRQbmSSy/fm1D0o3 CqKQ== X-Gm-Message-State: AOJu0YzhUPs2ZH7WiGO0JJ48FKFcTGdB8TcbK3/jr3bhzrfmzJ/+gjq3 StZL9r9Tgr51iNZEfsxdUNLFiG4YdqepOin79HlIPain1xYTycN0gORsQBb6lrEyyatqkalpcGi 0rLs= X-Received: by 2002:a05:600c:502a:b0:406:545a:f8fe with SMTP id n42-20020a05600c502a00b00406545af8femr7214588wmr.29.1698050859288; Mon, 23 Oct 2023 01:47:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGW+2mBG4OHMCDUby53tPI9fABW+D3mOdsA1+Zm48JdS3ZFv4/n9z/J+ttA1vYad7RcvkgWPQ== X-Received: by 2002:a05:600c:502a:b0:406:545a:f8fe with SMTP id n42-20020a05600c502a00b00406545af8femr7214577wmr.29.1698050858937; Mon, 23 Oct 2023 01:47:38 -0700 (PDT) Received: from [192.168.0.36] ([78.19.74.205]) by smtp.gmail.com with ESMTPSA id r4-20020a05600c458400b00405391f485fsm8746446wmo.41.2023.10.23.01.47.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Oct 2023 01:47:38 -0700 (PDT) Message-ID: <918876a3-3fb0-a2af-f466-d24a58e117af@redhat.com> Date: Mon, 23 Oct 2023 09:47:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 To: Joyce Kong , David Marchand , "dev@dpdk.org" Cc: "thomas@monjalon.net" , "techboard@dpdk.org" , Tyler Retzlaff References: <20231018091123.1594324-1-david.marchand@redhat.com> From: Kevin Traynor Subject: Re: [PATCH] bitops: mark new symbols as stable In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 23/10/2023 08:09, Joyce Kong wrote: >> -----Original Message----- >> From: David Marchand >> Sent: Wednesday, October 18, 2023 5:11 PM >> To: dev@dpdk.org >> Cc: thomas@monjalon.net; techboard@dpdk.org; Joyce Kong >> ; Tyler Retzlaff >> Subject: [PATCH] bitops: mark new symbols as stable >> >> Calling an experimental symbol from an inline helper triggers a warning when >> such code is not compiled with experimental API. >> This can be seen when rte_bitops.h gets (indirectly) included in OVS builds. >> >> On the other hand, rte_clz32, rte_clz64, rte_ctz32, rte_ctz64, rte_popcount32, >> rte_popcount64 are inline helpers for abstracting common bit counting >> functions. This part of the API is unlikely to change. >> >> Mark those symbols as stable. >> >> Fixes: 18898c4d06f9 ("eal: use abstracted bit count functions") >> >> Signed-off-by: David Marchand > > Reviewed-by: Joyce Kong > Acked-by: Kevin Traynor >> --- >> Copying Techboard for info, as this goes against the usual policy of marking >> new API as experimental. >> Approved in techboard meeting: http://inbox.dpdk.org/dev/0520f6a2-d98f-260d-8998-9bff8b8797e8@redhat.com/ >> --- >> lib/eal/include/rte_bitops.h | 48 ------------------------------------ >> 1 file changed, 48 deletions(-) >> >> diff --git a/lib/eal/include/rte_bitops.h b/lib/eal/include/rte_bitops.h index >> 6b8ae8d3ac..174d25216d 100644 >> --- a/lib/eal/include/rte_bitops.h >> +++ b/lib/eal/include/rte_bitops.h >> @@ -280,9 +280,6 @@ rte_bit_relaxed_test_and_clear64(unsigned int nr, >> volatile uint64_t *addr) #ifdef RTE_TOOLCHAIN_MSVC >> >> /** >> - * @warning >> - * @b EXPERIMENTAL: this API may change, or be removed, without prior >> notice >> - * >> * Get the count of leading 0-bits in v. >> * >> * @param v >> @@ -290,7 +287,6 @@ rte_bit_relaxed_test_and_clear64(unsigned int nr, >> volatile uint64_t *addr) >> * @return >> * The count of leading zero bits. >> */ >> -__rte_experimental >> static inline unsigned int >> rte_clz32(uint32_t v) >> { >> @@ -302,9 +298,6 @@ rte_clz32(uint32_t v) } >> >> /** >> - * @warning >> - * @b EXPERIMENTAL: this API may change, or be removed, without prior >> notice >> - * >> * Get the count of leading 0-bits in v. >> * >> * @param v >> @@ -312,7 +305,6 @@ rte_clz32(uint32_t v) >> * @return >> * The count of leading zero bits. >> */ >> -__rte_experimental >> static inline unsigned int >> rte_clz64(uint64_t v) >> { >> @@ -324,9 +316,6 @@ rte_clz64(uint64_t v) } >> >> /** >> - * @warning >> - * @b EXPERIMENTAL: this API may change, or be removed, without prior >> notice >> - * >> * Get the count of trailing 0-bits in v. >> * >> * @param v >> @@ -334,7 +323,6 @@ rte_clz64(uint64_t v) >> * @return >> * The count of trailing zero bits. >> */ >> -__rte_experimental >> static inline unsigned int >> rte_ctz32(uint32_t v) >> { >> @@ -346,9 +334,6 @@ rte_ctz32(uint32_t v) } >> >> /** >> - * @warning >> - * @b EXPERIMENTAL: this API may change, or be removed, without prior >> notice >> - * >> * Get the count of trailing 0-bits in v. >> * >> * @param v >> @@ -356,7 +341,6 @@ rte_ctz32(uint32_t v) >> * @return >> * The count of trailing zero bits. >> */ >> -__rte_experimental >> static inline unsigned int >> rte_ctz64(uint64_t v) >> { >> @@ -368,9 +352,6 @@ rte_ctz64(uint64_t v) } >> >> /** >> - * @warning >> - * @b EXPERIMENTAL: this API may change, or be removed, without prior >> notice >> - * >> * Get the count of 1-bits in v. >> * >> * @param v >> @@ -378,7 +359,6 @@ rte_ctz64(uint64_t v) >> * @return >> * The count of 1-bits. >> */ >> -__rte_experimental >> static inline unsigned int >> rte_popcount32(uint32_t v) >> { >> @@ -386,9 +366,6 @@ rte_popcount32(uint32_t v) } >> >> /** >> - * @warning >> - * @b EXPERIMENTAL: this API may change, or be removed, without prior >> notice >> - * >> * Get the count of 1-bits in v. >> * >> * @param v >> @@ -396,7 +373,6 @@ rte_popcount32(uint32_t v) >> * @return >> * The count of 1-bits. >> */ >> -__rte_experimental >> static inline unsigned int >> rte_popcount64(uint64_t v) >> { >> @@ -406,9 +382,6 @@ rte_popcount64(uint64_t v) #else >> >> /** >> - * @warning >> - * @b EXPERIMENTAL: this API may change, or be removed, without prior >> notice >> - * >> * Get the count of leading 0-bits in v. >> * >> * @param v >> @@ -416,7 +389,6 @@ rte_popcount64(uint64_t v) >> * @return >> * The count of leading zero bits. >> */ >> -__rte_experimental >> static inline unsigned int >> rte_clz32(uint32_t v) >> { >> @@ -424,9 +396,6 @@ rte_clz32(uint32_t v) } >> >> /** >> - * @warning >> - * @b EXPERIMENTAL: this API may change, or be removed, without prior >> notice >> - * >> * Get the count of leading 0-bits in v. >> * >> * @param v >> @@ -434,7 +403,6 @@ rte_clz32(uint32_t v) >> * @return >> * The count of leading zero bits. >> */ >> -__rte_experimental >> static inline unsigned int >> rte_clz64(uint64_t v) >> { >> @@ -442,9 +410,6 @@ rte_clz64(uint64_t v) } >> >> /** >> - * @warning >> - * @b EXPERIMENTAL: this API may change, or be removed, without prior >> notice >> - * >> * Get the count of trailing 0-bits in v. >> * >> * @param v >> @@ -452,7 +417,6 @@ rte_clz64(uint64_t v) >> * @return >> * The count of trailing zero bits. >> */ >> -__rte_experimental >> static inline unsigned int >> rte_ctz32(uint32_t v) >> { >> @@ -460,9 +424,6 @@ rte_ctz32(uint32_t v) } >> >> /** >> - * @warning >> - * @b EXPERIMENTAL: this API may change, or be removed, without prior >> notice >> - * >> * Get the count of trailing 0-bits in v. >> * >> * @param v >> @@ -470,7 +431,6 @@ rte_ctz32(uint32_t v) >> * @return >> * The count of trailing zero bits. >> */ >> -__rte_experimental >> static inline unsigned int >> rte_ctz64(uint64_t v) >> { >> @@ -478,9 +438,6 @@ rte_ctz64(uint64_t v) } >> >> /** >> - * @warning >> - * @b EXPERIMENTAL: this API may change, or be removed, without prior >> notice >> - * >> * Get the count of 1-bits in v. >> * >> * @param v >> @@ -488,7 +445,6 @@ rte_ctz64(uint64_t v) >> * @return >> * The count of 1-bits. >> */ >> -__rte_experimental >> static inline unsigned int >> rte_popcount32(uint32_t v) >> { >> @@ -496,9 +452,6 @@ rte_popcount32(uint32_t v) } >> >> /** >> - * @warning >> - * @b EXPERIMENTAL: this API may change, or be removed, without prior >> notice >> - * >> * Get the count of 1-bits in v. >> * >> * @param v >> @@ -506,7 +459,6 @@ rte_popcount32(uint32_t v) >> * @return >> * The count of 1-bits. >> */ >> -__rte_experimental >> static inline unsigned int >> rte_popcount64(uint64_t v) >> { >> -- >> 2.41.0 > > IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. >