From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 876CFA00B8; Sun, 27 Oct 2019 23:35:30 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 996EB1BEFD; Sun, 27 Oct 2019 23:35:28 +0100 (CET) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by dpdk.org (Postfix) with ESMTP id 5E9871BEFA for ; Sun, 27 Oct 2019 23:35:26 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 3597B65C; Sun, 27 Oct 2019 18:35:23 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 27 Oct 2019 18:35:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=P1Sb4RvCPKQNmh3Gp6SAKv4QJxLQqgiYa+Iff3qh7aI=; b=c/LPifuTomrI c9+NKvX5FW2RbB67C/ANN04ZZ5ieCylB0hYXyMU4LMyDSTC1NvvtOu2XJIbXfMIW 4mPRtEYYyb/fU7SPjLXPvbAPrp04bXIiMQEFt6PCoI6WDnx7QviPVOYzWVOd8wcB jqVtKVY9ILfxTWUcM7WL5x6VFPMBbdk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=P1Sb4RvCPKQNmh3Gp6SAKv4QJxLQqgiYa+Iff3qh7 aI=; b=H1Z7MYAVNIfEwgePoZC5EGNjgB3WkfpEOLrEwxRQ7CkyMyv9oF0nARZUi BlVzpKPqWRdl6z88nn3gh7yAzidltqCWmmCs7Q/xCJa63D0JmLfJNhZEKEa405mn lS0yNkPY8wiMJ4ZC0fR3cgNhiEy+zLh2iBjTP4EkV3szxj8P5wkwdqMqg8XvyRBQ OboUYu4lTrp8H4U+kIJj4m1BKhSbAOLMNnp+mHiUri3QZOOv8JIa8AScsYIjQ/Sm SW7Ou/xrbaaZhJNWgvdudUUZTqvrPC6BUq00+fhbru6T5CVURPVsvGaqPgiC40ng Q63Swd8xcO45Q7axf9DBrK5dSxQCA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrleejgdduieejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 87E1D8005A; Sun, 27 Oct 2019 18:35:21 -0400 (EDT) From: Thomas Monjalon To: "Di, ChenxuX" Cc: dev@dpdk.org, "Yigit, Ferruh" , "Lu, Wenzhuo" , "Yang, Qiming" Date: Sun, 27 Oct 2019 23:35:20 +0100 Message-ID: <9195060.g7C8rkA94r@xps> In-Reply-To: <3B926E44943CB04AA3A39AC16328CE39B5BDB6@SHSMSX101.ccr.corp.intel.com> References: <20191024010310.35882-1-chenxux.di@intel.com> <3B926E44943CB04AA3A39AC16328CE39B5BDB6@SHSMSX101.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix device hotplug remove X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 25/10/2019 03:48, Di, ChenxuX: > From: Yigit, Ferruh > > On 10/24/2019 2:03 AM, Di ChenxuX wrote: > > > Hotplug remove cause infinite loops. Fix by canceling port_close > > > before port_detach function when rmv_port_callback. > > > > Can you please give more details/backtrace of how loop happens? > > How can trigger it? > > Here is the test case > > Environment > Os: Ubuntu 18.04 > Device: X710 nic > Software: qemu > > 1. Bind pf0 to vfio-pci > > [root@xxxxxxxxx dpdk]# modprobe vfio-pci > [root@ xxxxxxxxx dpdk]# usertools/dpdk-devbind.py --force --bind=vfio-pci 0000:81:00.0 > 2. Passthrough PF and start qemu > > [root@ xxxxxxxxx dpdk]# taskset -c 0-7 qemu-system-x86_64 -enable-kvm -pidfile /tmp/.vm0.pid -m 10240 -cpu host -smp 8 -name vm0 -monitor unix:/tmp/vm0_monitor.sock,server,nowait -chardev socket,path=/tmp/vm0_qga0.sock,server,nowait,id=vm0_qga0 -device virtio-serial -device virtserialport,chardev=vm0_qga0,name=org.qemu.guest_agent.0 -device e1000,netdev=nttsip1 -netdev user,id=nttsip1,hostfwd=tcp: xxxxxxxxx:6000-:22 -monitor stdio -drive file=/home/image/test_vfio.img -vnc :5 -device vfio-pci,host=0000:81:00.0,id=dev1 > 3. Log in VM, bind passthrough port 0 to vfio-pci > > virtdut. xxxxxxxxx:6000: modprobe -r vfio_iommu_type1 > virtdut. xxxxxxxxx:6000: modprobe -r vfio > virtdut. xxxxxxxxx:6000: modprobe vfio enable_unsafe_noiommu_mode=1 > virtdut. xxxxxxxxx:6000: modprobe vfio-pci > > virtdut. xxxxxxxxx:6000: ./usertools/dpdk-devbind.py -b vfio-pci 0000:00:05.0 > 4. Start testpmd with "--hot-plug" enable > > virtdut. xxxxxxxxx:6000: ./x86_64-native-linuxapp-gcc/app/testpmd -l 0,1,2,3,4,5,6,7 -n 1 -w 0000:00:05.0 --file-prefix=dpdk_24610_20191014100036 -- -i --hot-plug > 5. Remove device from qemu interface > > (qemu) device_del dev1 > > 6.before change > Removing a device... > EAL: Driver cannot detach the device (0000:00:05.0) > EAL: Failed to detach device on primary process > testpmd: Failed to detach device 0000:00:05.0 > EAL: can not get port by device 0000:00:05.0! > EAL: can not get port by device 0000:00:05.0! > ... > EAL: can not get port by device 0000:00:05.0! > ... > ... > after change: > Removing a device... > EAL: Error disabling MSI-X interrupts for fd 47 > EAL: Releasing pci mapped resource for 0000:00:05.0 > EAL: Calling pci_unmap_resource for 0000:00:05.0 at 0x1100800000 > EAL: Calling pci_unmap_resource for 0000:00:05.0 at 0x1101000000 > Device of port 0 is detached > Now total ports is 0 > Done > Invalid port_id=0 > EAL: Cannot find device (0000:00:05.0) on bus (pci) > > > > > > > > > > Fixes: ac89d46096d5 ("net/i40e: release port upon close") > > > > > > Signed-off-by: Di ChenxuX > > > --- > > > app/test-pmd/testpmd.c | 1 - > > > 1 file changed, 1 deletion(-) > > > > > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index > > > 5701f3141..a264644a1 100644 > > > --- a/app/test-pmd/testpmd.c > > > +++ b/app/test-pmd/testpmd.c > > > @@ -2708,7 +2708,6 @@ rmv_port_callback(void *arg) > > > no_link_check = 1; > > > stop_port(port_id); > > > no_link_check = org_no_link_check; > > > - close_port(port_id); > > > detach_port_device(port_id); > > > if (need_to_start) > > > start_packet_forwarding(0); I disagree with this patch. You are removing a call to the "close" function because it does not work properly with your driver. Please do not blame the tool which is showing the error.