From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Adrien Mazarguil <adrien.mazarguil@6wind.com>,
Gaetan Rivet <gaetan.rivet@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v1 0/7] Flow API helpers enhancements
Date: Fri, 6 Oct 2017 02:13:14 +0100 [thread overview]
Message-ID: <919ab2dc-1081-d139-50a3-c797fbeb7284@intel.com> (raw)
In-Reply-To: <cover.1507193185.git.adrien.mazarguil@6wind.com>
On 10/5/2017 10:49 AM, Adrien Mazarguil wrote:
> This series brings enhancements to various rte_flow helpers:
>
> - Allow applications to use rte_flow_error_set() by making it part of the
> public interface and documenting it as such.
>
> - Address rte_flow_copy()'s limitations by replacing it with the more
> versatile rte_flow_conv(). This new function allows retrieving other
> properties such as item/action names, enabling testpmd to finally use it
> and get rid of duplicated code.
>
> - Add a script (gen-rte_flow_conv-h.sh) to help with generating the
> resources used by rte_flow_conv(). Developers should run it when adding or
> modifying pattern items or actions (done as part of this series to add the
> missing "fuzzy" pattern item).
>
> - Future plans for rte_flow_conv() include translating error codes to
> human-readable messages, so applications do not have to make their own.
>
> All these changes address concerns raised a couple of months ago [1]. Work
> on these patches actually started at the time but I was unable to complete
> and clean them up until recently.
>
> [1] http://dpdk.org/ml/archives/dev/2017-July/070492.html
>
> Adrien Mazarguil (7):
> ethdev: expose flow API error helper
> ethdev: replace flow API object copy function
> ethdev: add flow API item/action name conversion
> app/testpmd: rely on flow API conversion function
> ethdev: enhance flow API item/action descriptions
> ethdev: generate flow API conversion header
> ethdev: update flow API conversion header
Hi Adrien,
This received too late for this release cycle, and changes in rte_flow
library may effect PMDs.
I suggest deferring the set to next release, what do you think?
Thanks,
ferruh
next prev parent reply other threads:[~2017-10-06 1:13 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 9:49 Adrien Mazarguil
2017-10-05 9:49 ` [dpdk-dev] [PATCH v1 1/7] ethdev: expose flow API error helper Adrien Mazarguil
2017-10-11 9:23 ` Thomas Monjalon
2017-10-11 11:56 ` Adrien Mazarguil
2017-10-11 19:05 ` Aaron Conole
2017-10-12 13:37 ` Neil Horman
2017-10-12 14:02 ` Adrien Mazarguil
2017-10-05 9:49 ` [dpdk-dev] [PATCH v1 2/7] ethdev: replace flow API object copy function Adrien Mazarguil
2017-10-05 9:49 ` [dpdk-dev] [PATCH v1 3/7] ethdev: add flow API item/action name conversion Adrien Mazarguil
2017-10-05 9:49 ` [dpdk-dev] [PATCH v1 4/7] app/testpmd: rely on flow API conversion function Adrien Mazarguil
2017-10-05 9:49 ` [dpdk-dev] [PATCH v1 5/7] ethdev: enhance flow API item/action descriptions Adrien Mazarguil
2017-10-05 9:49 ` [dpdk-dev] [PATCH v1 6/7] ethdev: generate flow API conversion header Adrien Mazarguil
2017-10-05 9:49 ` [dpdk-dev] [PATCH v1 7/7] ethdev: update " Adrien Mazarguil
2017-10-06 1:13 ` Ferruh Yigit [this message]
2017-10-06 8:05 ` [dpdk-dev] [PATCH v1 0/7] Flow API helpers enhancements Adrien Mazarguil
2017-10-10 18:05 ` Ferruh Yigit
2017-10-11 9:57 ` Adrien Mazarguil
2017-10-11 18:07 ` Ferruh Yigit
2017-10-12 12:53 ` Adrien Mazarguil
2017-10-12 16:37 ` Ferruh Yigit
2017-10-13 10:42 ` Adrien Mazarguil
2018-08-03 13:36 ` [dpdk-dev] [PATCH v2 0/7] ethdev: add flow API object converter Adrien Mazarguil
2018-08-03 13:36 ` [dpdk-dev] [PATCH v2 1/7] " Adrien Mazarguil
2018-08-03 13:36 ` [dpdk-dev] [PATCH v2 2/7] ethdev: add flow API item/action name conversion Adrien Mazarguil
2018-08-03 13:36 ` [dpdk-dev] [PATCH v2 3/7] app/testpmd: rely on flow API conversion function Adrien Mazarguil
2018-08-03 13:36 ` [dpdk-dev] [PATCH v2 4/7] net/failsafe: switch to flow API object " Adrien Mazarguil
2018-08-03 13:36 ` [dpdk-dev] [PATCH v2 5/7] net/bonding: " Adrien Mazarguil
2018-08-03 13:36 ` [dpdk-dev] [PATCH v2 6/7] ethdev: deprecate rte_flow_copy function Adrien Mazarguil
2018-08-03 13:36 ` [dpdk-dev] [PATCH v2 7/7] ethdev: add missing item/actions to flow object converter Adrien Mazarguil
2018-08-03 14:06 ` [dpdk-dev] [PATCH v2 0/7] ethdev: add flow API " Thomas Monjalon
2018-08-23 13:48 ` Ferruh Yigit
2018-08-27 15:14 ` Adrien Mazarguil
2018-08-24 10:58 ` Ferruh Yigit
2018-08-27 14:12 ` Adrien Mazarguil
2018-08-31 9:00 ` [dpdk-dev] [PATCH v3 " Adrien Mazarguil
2018-08-31 9:01 ` [dpdk-dev] [PATCH v3 1/7] " Adrien Mazarguil
2018-08-31 9:01 ` [dpdk-dev] [PATCH v3 2/7] ethdev: add flow API item/action name conversion Adrien Mazarguil
2018-08-31 9:01 ` [dpdk-dev] [PATCH v3 3/7] app/testpmd: rely on flow API conversion function Adrien Mazarguil
2018-08-31 9:01 ` [dpdk-dev] [PATCH v3 4/7] net/failsafe: switch to flow API object " Adrien Mazarguil
2018-08-31 9:01 ` [dpdk-dev] [PATCH v3 5/7] net/bonding: " Adrien Mazarguil
2018-08-31 9:01 ` [dpdk-dev] [PATCH v3 6/7] ethdev: add missing items/actions to flow object converter Adrien Mazarguil
2018-08-31 9:01 ` [dpdk-dev] [PATCH v3 7/7] ethdev: deprecate rte_flow_copy function Adrien Mazarguil
2018-10-04 14:21 ` Ferruh Yigit
2018-08-31 11:32 ` [dpdk-dev] [PATCH v3 0/7] ethdev: add flow API object converter Nélio Laranjeiro
2018-10-03 20:31 ` Thomas Monjalon
2018-10-04 14:25 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=919ab2dc-1081-d139-50a3-c797fbeb7284@intel.com \
--to=ferruh.yigit@intel.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=gaetan.rivet@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).