Re: [PATCH v4 4/4] dma/acc: add doc

[fengchengwen <fengchengwen@huawei.com>]

On 2025/10/15 20:01, Thomas Monjalon wrote:
> 15/10/2025 13:10, fengchengwen:
>> On 2025/10/15 18:05, Thomas Monjalon wrote:
>>> 13/10/2025 11:11, Chengwen Feng:
>>>> +HISILICON Accelerator DMA Driver
>>>> +================================
>>>> +
>>>> +Kunpeng SoC has an internal accelerator unit which includes zip function, and
>>>> +the zip also supports data copy and fill. This driver exposes this capability to
>>>> +DPDK application.
>>> How is it different of drivers/dma/hisilicon/ ?
>>>
>>> "
>>> Kunpeng SoC has an internal DMA unit which can be used by application
>>> to accelerate data copies.
>>> "
>>>
>>> If it is the same hardware (Kunpeng),
>>> I recommend having a single driver, or a single directory.
>>> Also we already have a driver named "acc" in baseband.
>>
>> they belong to different hardware IP of Kunpeng platform, /dma/hisilicon
>> is the PCIE subsystem DMA's driver, while this acc is the
>> Accelerator(ZIP) subsystem DMA's driver.  they don't exist in the same
>> specific Kunpeng Soc.
>>
>> a single driver will add complex.
>>
>> as for a single directory, should we do for all vendor?  I see there
>> are  dpaa and dpaa2, ioat and idxd both belong to vendor platform.
> When it is really different driver, it is OK to keep them separate.
>
>> if there are no rule to have same name with different subsystem driver,
>> I prefer keep it.
> OK but why it does not contain HiSilicon or Kunpeng in its name?
> "acc" is a really short name, and already used.
> Please find something else.

how about hacc and kacc ?   Hisilicon / Kunpeng accelerator DMA

I will send v5 with one of them

>
>