From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E87BF4551D; Fri, 28 Jun 2024 08:56:00 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 254B242DC3; Fri, 28 Jun 2024 08:56:00 +0200 (CEST) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id D13984029B for ; Fri, 28 Jun 2024 08:55:23 +0200 (CEST) Received: from mail.maildlp.com (unknown [172.19.88.105]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4W9R0Z5x6ZzZcFk; Fri, 28 Jun 2024 14:50:54 +0800 (CST) Received: from dggpeml500011.china.huawei.com (unknown [7.185.36.84]) by mail.maildlp.com (Postfix) with ESMTPS id 8620D1400C9; Fri, 28 Jun 2024 14:55:21 +0800 (CST) Received: from [10.67.121.193] (10.67.121.193) by dggpeml500011.china.huawei.com (7.185.36.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 28 Jun 2024 14:55:21 +0800 Message-ID: <921929af-52dd-4d0b-b7fa-194832aaeb6a@huawei.com> Date: Fri, 28 Jun 2024 14:55:21 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] devtools: fix version variable not initialized Content-Language: en-US To: David Marchand CC: , , , , , References: <20240417093236.3786106-1-huangdengdui@huawei.com> From: huangdengdui In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.121.193] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpeml500011.china.huawei.com (7.185.36.84) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2024/6/27 22:28, David Marchand wrote: > On Wed, Apr 17, 2024 at 11:32 AM Dengdui Huang wrote: >> >> The version variable is not initialized. Therefore, if the -V option >> is not specified, the value of $version is obtained from the context, >> which may cause the version map parsing failure. >> >> Fixes: 6edec7f202ac ("devtools: list symbols by version") >> Cc: stable@dpdk.org >> >> Signed-off-by: Dengdui Huang > > This is an internal script and I wonder how the mentionned issue is hit. > In any case this fix is correct. > > Reviewed-by: David Marchand > > Thanks for your review. The project build script may pass version information through environment variables. This problem occurs if the following execution sequence exists: export version=devel meson build ninja -C build