From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2F99A433FD; Tue, 5 Dec 2023 03:55:42 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 04D2B42DA7; Tue, 5 Dec 2023 03:55:26 +0100 (CET) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id C128C42D97 for ; Tue, 5 Dec 2023 03:55:24 +0100 (CET) Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4SklVs66d9zWjJw; Tue, 5 Dec 2023 10:54:29 +0800 (CST) Received: from [10.67.121.161] (10.67.121.161) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 5 Dec 2023 10:55:22 +0800 Subject: Re: [PATCH 0/7] refactor kvargs test From: fengchengwen To: , CC: References: <20231103095325.47843-1-fengchengwen@huawei.com> Message-ID: <922e1c77-e2ca-439e-b9f6-bb275cc20fc3@huawei.com> Date: Tue, 5 Dec 2023 10:55:22 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20231103095325.47843-1-fengchengwen@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.121.161] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Thomas, Could you please apply the commits 1~6 ? There commits are independent and could use for current code. Thanks On 2023/11/3 17:53, Chengwen Feng wrote: > When developing patchset [1], I found the kvargs test is hard to > understand when tried to add some testcase. > > So refactor kvargs by: > 1. introduce UT suite framework. > 2. extract big test_valid_kvargs() to five part. > > And add myself for voluntary maintenance of the kvargs library. > > Note: to ensure patch independenct, new API which in patchset [1] > are not included in this patchset. > > [1] https://patchwork.dpdk.org/project/dpdk/cover/20231103073811.13196-1-fengchengwen@huawei.com/ > > Chengwen Feng (7): > app/test: introduce UT suite framework for kvargs > app/test: extract basic token count testcase for kvargs > app/test: extract without keys testcase for kvargs > app/test: extract with keys testcase for kvargs > app/test: extract parse list value testcase for kvargs > app/test: extract parse empty elements testcase for kvargs > maintainers: update for kvargs library > > MAINTAINERS | 1 + > app/test/test_kvargs.c | 256 ++++++++++++++++++++--------------------- > 2 files changed, 128 insertions(+), 129 deletions(-) >