From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93DD84339B; Wed, 22 Nov 2023 12:51:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 816E040E36; Wed, 22 Nov 2023 12:51:00 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 5C79A40E25; Wed, 22 Nov 2023 12:50:59 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 9EEB95C00F4; Wed, 22 Nov 2023 06:50:58 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 22 Nov 2023 06:50:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1700653858; x=1700740258; bh=wDPNtlCLwiVIJMom+Zr0CSUgMznPeCNCusa qp8tYVeM=; b=xqBrOXNjAjVjBSYF8H/y28kDDxXprMPD7N7vX94FKbHarnhHHtU PfXxW69IRAjLPQOPfZU2WFlxzI/0mWDa6tJAHw2Mc5dbos5gS1CRpbXvMCCpgycU CcDlM/cap/BD1/p3lJ9nCOaiu78OumWh99xC1rXdD6l+E0OO81AiLCrMxUoayyhR WQK96RfDz+E2/AemPaSUUA8IAM1w1Id+PDUxmPCvYpR6ydunRYt3iMMHNSESy99l mE+R0/n6DY31rRGdOx/Ptd3EI7y5oc3hhuVxMxHVnYH4HcApyvyyl4AYWBV0eOx5 T5G3eA2NQn/m4fRXtpjqdlfgh+e1SebDBUA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1700653858; x=1700740258; bh=wDPNtlCLwiVIJMom+Zr0CSUgMznPeCNCusa qp8tYVeM=; b=cySxH3XcSWJY2u0vwjXF3bx6fCG621ehpOHOLFXsoOzuA27K5MX nNeSkLhef96ISOpCB/IHKGrQflat5+GlKqc8McCtqrtPylVOD9YijS70DMGwU/B7 WHvVigJqQh0G+k2H2P2SEC8tBG9yeUEqkS2GGUnyW+EJXa1HT67jBpf4uLiVRCw6 bSU0n1qwCwcvA7siShla4NnrUP6x1xe/QXmlQzXRroyT7wryKG0o2bdAE6iLfhAz EGq0a1mnC3KJ4SNMp+Wx1ACBGQxjX85EnlDXh8WZY9BrDKQU0ws3jOu0vsmlVIDX cv1wMtYQCDhNO1cdpQ+CsD9UGC0ZIPzVy/g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudehuddgfeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 22 Nov 2023 06:50:57 -0500 (EST) From: Thomas Monjalon To: Chaoyong He Cc: dev@dpdk.org, stable@dpdk.org, oss-drivers@corigine.com, Long Wu , Peng Zhang Subject: Re: [PATCH 3/5] common/nfp: fix integer handling issues Date: Wed, 22 Nov 2023 12:50:55 +0100 Message-ID: <9244382.rMLUfLXkoz@thomas> In-Reply-To: <20231115032310.756221-4-chaoyong.he@corigine.com> References: <20231115032310.756221-1-chaoyong.he@corigine.com> <20231115032310.756221-4-chaoyong.he@corigine.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 15/11/2023 04:23, Chaoyong He: > CI found integer handling issues, overflow before widen. > > Coverity issue: 405351 > Fixes: 87f5b35ba4e8 ("common/nfp: move queue logic") > Cc: stable@dpdk.org [...] > - enabled_queues |= (1 << i); > + enabled_queues |= (1ULL << i); That's a very bad fix. You should use RTE_BIT64() which is more explicit. Please read rte_bitops.h, that's a nice set of macros and functions.