From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 5CD762D13 for ; Thu, 28 Mar 2019 20:02:06 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Mar 2019 12:02:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,281,1549958400"; d="scan'208";a="138110752" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.46]) ([10.237.221.46]) by orsmga003.jf.intel.com with ESMTP; 28 Mar 2019 12:02:03 -0700 To: Adrien Mazarguil References: <20170929153749.9806-1-stephen@networkplumber.org> <20171002115317.GJ3871@6wind.com> <20171002134624.GA10500@bricha3-MOBL3.ger.corp.intel.com> <20171002162106.GQ3871@6wind.com> <20171003103813.GA20140@bricha3-MOBL3.ger.corp.intel.com> <20171003105612.GS3871@6wind.com> Cc: Stephen Hemminger , Bruce Richardson , Luca Boccassi , Thomas Monjalon , dpdk-dev From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJVBBMBAgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBNI2U4dCLsKE45mBx/kz60PfE2EfBQJbughWBQkHwjOGAAoJEPkz60Pf E2Eft84QAIbKWqhgqRfoiw/BbXbA1+qm2o4UgkCRQ0yJgt9QsnbpOmPKydHH0ixCliNz1J8e mRXCkMini1bTpnzp7spOjQGLeAFkNFz6BMq8YF2mVWbGEDE9WgnAxZdi0eLY7ZQnHbE6AxKL SXmpe9INb6z3ztseFt7mqje/W/6DWYIMnH3Yz9KzxujFWDcq8UCAvPkxVQXLTMpauhFgYeEx Nub5HbvhxTfUkapLwRQsSd/HbywzqZ3s/bbYMjj5JO3tgMiM9g9HOjv1G2f1dQjHi5YQiTZl 1eIIqQ3pTic6ROaiZqNmQFXPsoOOFfXF8nN2zg8kl/sSdoXWHhama5hbwwtl1vdaygQYlmdK H2ueiFh/UvT3WG3waNv2eZiEbHV8Rk52Xyn2w1G90lV0fYC6Ket1Xjoch7kjwbx793Kz/RfQ rmBY8/S4DTGn3oq3dMdQY+b6+7VMUeLMMh2CXYO9ErkOq+qNTD1IY+cBAkXnaDbQfz0zbste ZGWH74FAZ9nCpDOqbRTrBL42aMGhfOWEyeA1x7+hl6JZfabBWAuf4nnCXuorKHzBXTrf7u7p fXsKQClWRW77PF1VmzrtKNVSytQAmlCWApQIw20AarFipXmVdIjHmJPU611WoyxZPb4JTOxx 5cv9B+nr/RIB+v5dcStyHCCwO1be7nBDdCgd4F6kTQPLuQINBFfWTL4BEACnNA29e8TarUsB L5n6eLZHXcFvVwNLVlirWOClHXf44o2KnN3ww+eBEmKVfEFo9MSuGDNHS8Zw1NiGMYxLIUgd U6gGrVVs/VrQWL82pbMk6jCj98N+BXIri+6K1z+AImz7ax7iF1kDgRAnFWU0znWWBgM2mM8Y gDjcxfXk4sCKnvf6Gjo08Ey5zmqx7dekAKU2EEp8Q1EJY3jbymLdZWRP4AFFMTS1rGMk0/tt v71NBg1GobCcbNfn9chK/jhqxYhAJqq86RdJQkt3/9x1U1Oq0vXCt4JVVHmkxePtUiuWTTt+ aYlUAsKYZsWvncExvw77x2ArYDmaK0yfjh37wp0lY7DOJHFxoyT8tyWZlLci/VMRG2Ja33xj 0CN4C1yBg+QDeV3QFxQo42iA/ykdXPUR3ezmsND3XKvVLTC4DNb3V/EZQ7jBj64+bEK0VW4G B31VP00ApNQvSoczsIOAKdk97RNbpmPw6q10ILIB+9T1xbnFYzshzGF17oC0/GENIHATx8vZ masOZoDiOZQpeneLgnFE9JfzhLTxv6wNZcc/HLXRQVTkDsQr8ERtkAoHCf1E5+b5Yr7pfnE4 YuhET746o25S53ELUYPIs49qoJsEJL34/oexMfPGyPIlrbufiNyty5jc/1MRwUlhJlJ5IOHy ZUa+6CLR7GdImusFkPJUJwARAQABiQI8BBgBAgAmAhsMFiEE0jZTh0IuwoTjmYHH+TPrQ98T YR8FAlu6CHAFCQXE7zIACgkQ+TPrQ98TYR9nXxAAqNBgkYNyGuWUuy0GwDQCbu3iiMyH1+D7 llafPcK4NYy1Z4AYuVwC9nmLaoj+ozdqS3ncRo57ncRsKEJC46nDJJZYZ5LSJVn63Y3NBF86 lxQAgjj2oyZEwaLKtKbAFsXL43jv1pUGgSvWwYtDwHITXXFQto9rZEuUDRFSx4sg9OR+Q6/6 LY+nQQ3OdHlBkflzYMPcWgDcvcTAO6yasLEUf7UcYoSWTyMYjLB4QuNlXzTswzGVMssJF/vo V8lD1eqqaSUWG3STF6GVLQOr1NLvN5+kUBiEStHFxBpgSCvYY9sNV8FS6N24CAWMBl+10W+D 2h1yiiP5dOdPcBDYKsgqDD91/sP0WdyMJkwdQJtD49f9f+lYloxHnSAxMleOpyscg1pldw+i mPaUY1bmIknLhhkqfMmjywQOXpac5LRMibAAYkcB8v7y3kwELnt8mhqqZy6LUsqcWygNbH/W K3GGt5tRpeIXeJ25x8gg5EBQ0Jnvp/IbBYQfPLtXH0Myq2QuAhk/1q2yEIbVjS+7iowEZNyE 56K63WBJxsJPB2mvmLgn98GqB4G6GufP1ndS0XDti/2K0o8rep9xoY/JDGi0n0L0tk9BHyoP Y7kaEpu7UyY3nVdRLe5H1/MnFG8hdJ97WqnPS0buYZlrbTV0nRFL/NI2VABl18vEEXvNQiO+ vM8= Message-ID: <92660560-a08f-662c-293c-91d1a988e5f3@intel.com> Date: Thu, 28 Mar 2019 19:02:02 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20171003105612.GS3871@6wind.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] checkpatch: re-enable warnings about split long strings X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Mar 2019 19:02:07 -0000 On 10/3/2017 11:56 AM, adrien.mazarguil at 6wind.com (Adrien Mazarguil) wrote: > On Tue, Oct 03, 2017 at 11:38:13AM +0100, Bruce Richardson wrote: >> On Mon, Oct 02, 2017 at 06:21:06PM +0200, Adrien Mazarguil wrote: >>> On Mon, Oct 02, 2017 at 02:46:24PM +0100, Bruce Richardson wrote: >>>> On Mon, Oct 02, 2017 at 01:53:17PM +0200, Adrien Mazarguil wrote: >>>>> Hi Stephen, >>>>> >>>>> On Fri, Sep 29, 2017 at 08:37:49AM -0700, Stephen Hemminger wrote: >>>>>> The Linux kernel style policy about strings is that strings should >>>>>> be always put on one line. This makes sense since a typical use case >>>>>> is for a user to type the error message into a search engine or >>>>>> grep, and it won't be found if split across lines. This patch just >>>>>> re-enables that check. >>>>>> >>>>>> Yes, lots of DPDK code now splits strings, that doesn't make it >>>>>> right. >>>>>> >>>>>> Signed-off-by: Stephen Hemminger --- >>>>>> devtools/checkpatches.sh | 1 - 1 file changed, 1 deletion(-) >>>>>> >>>>>> diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh >>>>>> index a56c41a301c0..3e6081dd673e 100755 --- >>>>>> a/devtools/checkpatches.sh +++ b/devtools/checkpatches.sh @@ -44,7 >>>>>> +44,6 @@ options="$options --show-types" options="$options >>>>>> --ignore=LINUX_VERSION_CODE,FILE_PATH_CHANGES,\ >>>>>> VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,\ >>>>>> PREFER_KERNEL_TYPES,BIT_MACRO,CONST_STRUCT,\ >>>>>> -SPLIT_STRING,LONG_LINE_STRING,\ >>>>>> LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\ >>>>>> NEW_TYPEDEFS,COMPARISON_TO_NULL" >>>>> >>>>> I'm not sure, given that the main reason for splitting strings in the >>>>> first place is to avoid LONG_LINE_STRING warnings, I think we must >>>>> choose between the two options. If split strings are not allowed, then >>>>> long lines must be. >>>>> >>>>> Since checkpatches.sh is used by various automated scripts to complain >>>>> loudly about problems in submissions, the above change prevents >>>>> maintainers from writing long string at all (can't split and can't go >>>>> past 80 columns). >>>>> >>>>> As a result, they will be tempted to cripple their code with nasty >>>>> workarounds to shut up checkpatches.sh, we don't want that to happen. >>>>> >>>>> Also I think the reasons stated by original commit cf75514c8e2e are >>>>> still relevant. My vote would be to keep things as is. >>>>> >>>> In my experience, checkpatch is smart enough to recognise when a long >>>> line overflows the 80 character limit because of a single long string, >>>> so the two options are not mutually exclusive. In other words, long >>>> lines are not allowed except in the case where shortening the line >>>> involves splitting a string. There may be a small amount of work in >>>> getting checkpatch happy, i.e. by putting the string on a line on it's >>>> own, but we can indeed have our cake and eat it too in this case. >>> >>> I can't seem to get around warnings without ignoring either SPLIT_STRING or >>> LONG_LINE_STRING as of Linux v4.14-rc3's checkpatch.pl. I think you can only >>> get around them by fooling it somehow. You really need to ignore at least >>> LONG_LINE_STRING to meet the requirements of the commit log. >>> >>> However SPLIT_STRING still looks necessary to address part of cf75514c8e2e >>> ("devtools: ignore warning on long log string"): >>> >>> "...lines that make use of PRIx64 with string concatenation will still be >>> flagged if the beginning of the last string fragment begins after the 80 >>> character threshold." >>> >>> It's not all that uncommon in my opinion. >>> >> If you have PRIx64 in it, it's not part of a literal string you would >> grep, so it's reasonable to split there. The user cannot know what the >> specific %x formatting character used is. > > I agree, however in that case checkpatch would complain because our > configuration doesn't specify to ignore SPLIT_STRING since there is no comma > separator when concatenating them. > > My point is that the occasional exception is still necessary for split > strings, that ignoring LONG_LINE_STRING must remain either way and > unnecessary warnings cause more harm than good (they need to be worked > around if we enforce this rule). > > In short, long/split strings acceptability assessment should be left to > reviewers, as it cannot be automated in all cases through checkpatch.pl. > This patch is waiting in patchwork for a long time now. My experience is same with Adrien's, if 'LONG_LINE_STRING' is not ignored, it will complain about long log messages, so removing 'LONG_LINE_STRING' contradicts with the reason of the patch described in the commit log. Perhaps it can be an option to remove only 'SPLIT_STRING' from ignore list, to detect split messages. But overall, I am updating this patch as "Change Requested", if there is a demand for ignoring 'SPLIT_STRING' please send a new version. Thanks, ferruh From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 00628A0679 for ; Thu, 28 Mar 2019 20:02:07 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BD6BF4CB5; Thu, 28 Mar 2019 20:02:07 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 5CD762D13 for ; Thu, 28 Mar 2019 20:02:06 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Mar 2019 12:02:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,281,1549958400"; d="scan'208";a="138110752" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.46]) ([10.237.221.46]) by orsmga003.jf.intel.com with ESMTP; 28 Mar 2019 12:02:03 -0700 To: Adrien Mazarguil References: <20170929153749.9806-1-stephen@networkplumber.org> <20171002115317.GJ3871@6wind.com> <20171002134624.GA10500@bricha3-MOBL3.ger.corp.intel.com> <20171002162106.GQ3871@6wind.com> <20171003103813.GA20140@bricha3-MOBL3.ger.corp.intel.com> <20171003105612.GS3871@6wind.com> Cc: Stephen Hemminger , Bruce Richardson , Luca Boccassi , Thomas Monjalon , dpdk-dev From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJVBBMBAgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBNI2U4dCLsKE45mBx/kz60PfE2EfBQJbughWBQkHwjOGAAoJEPkz60Pf E2Eft84QAIbKWqhgqRfoiw/BbXbA1+qm2o4UgkCRQ0yJgt9QsnbpOmPKydHH0ixCliNz1J8e mRXCkMini1bTpnzp7spOjQGLeAFkNFz6BMq8YF2mVWbGEDE9WgnAxZdi0eLY7ZQnHbE6AxKL SXmpe9INb6z3ztseFt7mqje/W/6DWYIMnH3Yz9KzxujFWDcq8UCAvPkxVQXLTMpauhFgYeEx Nub5HbvhxTfUkapLwRQsSd/HbywzqZ3s/bbYMjj5JO3tgMiM9g9HOjv1G2f1dQjHi5YQiTZl 1eIIqQ3pTic6ROaiZqNmQFXPsoOOFfXF8nN2zg8kl/sSdoXWHhama5hbwwtl1vdaygQYlmdK H2ueiFh/UvT3WG3waNv2eZiEbHV8Rk52Xyn2w1G90lV0fYC6Ket1Xjoch7kjwbx793Kz/RfQ rmBY8/S4DTGn3oq3dMdQY+b6+7VMUeLMMh2CXYO9ErkOq+qNTD1IY+cBAkXnaDbQfz0zbste ZGWH74FAZ9nCpDOqbRTrBL42aMGhfOWEyeA1x7+hl6JZfabBWAuf4nnCXuorKHzBXTrf7u7p fXsKQClWRW77PF1VmzrtKNVSytQAmlCWApQIw20AarFipXmVdIjHmJPU611WoyxZPb4JTOxx 5cv9B+nr/RIB+v5dcStyHCCwO1be7nBDdCgd4F6kTQPLuQINBFfWTL4BEACnNA29e8TarUsB L5n6eLZHXcFvVwNLVlirWOClHXf44o2KnN3ww+eBEmKVfEFo9MSuGDNHS8Zw1NiGMYxLIUgd U6gGrVVs/VrQWL82pbMk6jCj98N+BXIri+6K1z+AImz7ax7iF1kDgRAnFWU0znWWBgM2mM8Y gDjcxfXk4sCKnvf6Gjo08Ey5zmqx7dekAKU2EEp8Q1EJY3jbymLdZWRP4AFFMTS1rGMk0/tt v71NBg1GobCcbNfn9chK/jhqxYhAJqq86RdJQkt3/9x1U1Oq0vXCt4JVVHmkxePtUiuWTTt+ aYlUAsKYZsWvncExvw77x2ArYDmaK0yfjh37wp0lY7DOJHFxoyT8tyWZlLci/VMRG2Ja33xj 0CN4C1yBg+QDeV3QFxQo42iA/ykdXPUR3ezmsND3XKvVLTC4DNb3V/EZQ7jBj64+bEK0VW4G B31VP00ApNQvSoczsIOAKdk97RNbpmPw6q10ILIB+9T1xbnFYzshzGF17oC0/GENIHATx8vZ masOZoDiOZQpeneLgnFE9JfzhLTxv6wNZcc/HLXRQVTkDsQr8ERtkAoHCf1E5+b5Yr7pfnE4 YuhET746o25S53ELUYPIs49qoJsEJL34/oexMfPGyPIlrbufiNyty5jc/1MRwUlhJlJ5IOHy ZUa+6CLR7GdImusFkPJUJwARAQABiQI8BBgBAgAmAhsMFiEE0jZTh0IuwoTjmYHH+TPrQ98T YR8FAlu6CHAFCQXE7zIACgkQ+TPrQ98TYR9nXxAAqNBgkYNyGuWUuy0GwDQCbu3iiMyH1+D7 llafPcK4NYy1Z4AYuVwC9nmLaoj+ozdqS3ncRo57ncRsKEJC46nDJJZYZ5LSJVn63Y3NBF86 lxQAgjj2oyZEwaLKtKbAFsXL43jv1pUGgSvWwYtDwHITXXFQto9rZEuUDRFSx4sg9OR+Q6/6 LY+nQQ3OdHlBkflzYMPcWgDcvcTAO6yasLEUf7UcYoSWTyMYjLB4QuNlXzTswzGVMssJF/vo V8lD1eqqaSUWG3STF6GVLQOr1NLvN5+kUBiEStHFxBpgSCvYY9sNV8FS6N24CAWMBl+10W+D 2h1yiiP5dOdPcBDYKsgqDD91/sP0WdyMJkwdQJtD49f9f+lYloxHnSAxMleOpyscg1pldw+i mPaUY1bmIknLhhkqfMmjywQOXpac5LRMibAAYkcB8v7y3kwELnt8mhqqZy6LUsqcWygNbH/W K3GGt5tRpeIXeJ25x8gg5EBQ0Jnvp/IbBYQfPLtXH0Myq2QuAhk/1q2yEIbVjS+7iowEZNyE 56K63WBJxsJPB2mvmLgn98GqB4G6GufP1ndS0XDti/2K0o8rep9xoY/JDGi0n0L0tk9BHyoP Y7kaEpu7UyY3nVdRLe5H1/MnFG8hdJ97WqnPS0buYZlrbTV0nRFL/NI2VABl18vEEXvNQiO+ vM8= Message-ID: <92660560-a08f-662c-293c-91d1a988e5f3@intel.com> Date: Thu, 28 Mar 2019 19:02:02 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20171003105612.GS3871@6wind.com> Content-Type: text/plain; charset="UTF-8" Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] checkpatch: re-enable warnings about split long strings X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190328190202.3HXTiKP9aRfpmOyuMgcisTjwCN4Yy-k3re5cls1nKS0@z> On 10/3/2017 11:56 AM, adrien.mazarguil at 6wind.com (Adrien Mazarguil) wrote: > On Tue, Oct 03, 2017 at 11:38:13AM +0100, Bruce Richardson wrote: >> On Mon, Oct 02, 2017 at 06:21:06PM +0200, Adrien Mazarguil wrote: >>> On Mon, Oct 02, 2017 at 02:46:24PM +0100, Bruce Richardson wrote: >>>> On Mon, Oct 02, 2017 at 01:53:17PM +0200, Adrien Mazarguil wrote: >>>>> Hi Stephen, >>>>> >>>>> On Fri, Sep 29, 2017 at 08:37:49AM -0700, Stephen Hemminger wrote: >>>>>> The Linux kernel style policy about strings is that strings should >>>>>> be always put on one line. This makes sense since a typical use case >>>>>> is for a user to type the error message into a search engine or >>>>>> grep, and it won't be found if split across lines. This patch just >>>>>> re-enables that check. >>>>>> >>>>>> Yes, lots of DPDK code now splits strings, that doesn't make it >>>>>> right. >>>>>> >>>>>> Signed-off-by: Stephen Hemminger --- >>>>>> devtools/checkpatches.sh | 1 - 1 file changed, 1 deletion(-) >>>>>> >>>>>> diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh >>>>>> index a56c41a301c0..3e6081dd673e 100755 --- >>>>>> a/devtools/checkpatches.sh +++ b/devtools/checkpatches.sh @@ -44,7 >>>>>> +44,6 @@ options="$options --show-types" options="$options >>>>>> --ignore=LINUX_VERSION_CODE,FILE_PATH_CHANGES,\ >>>>>> VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,\ >>>>>> PREFER_KERNEL_TYPES,BIT_MACRO,CONST_STRUCT,\ >>>>>> -SPLIT_STRING,LONG_LINE_STRING,\ >>>>>> LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\ >>>>>> NEW_TYPEDEFS,COMPARISON_TO_NULL" >>>>> >>>>> I'm not sure, given that the main reason for splitting strings in the >>>>> first place is to avoid LONG_LINE_STRING warnings, I think we must >>>>> choose between the two options. If split strings are not allowed, then >>>>> long lines must be. >>>>> >>>>> Since checkpatches.sh is used by various automated scripts to complain >>>>> loudly about problems in submissions, the above change prevents >>>>> maintainers from writing long string at all (can't split and can't go >>>>> past 80 columns). >>>>> >>>>> As a result, they will be tempted to cripple their code with nasty >>>>> workarounds to shut up checkpatches.sh, we don't want that to happen. >>>>> >>>>> Also I think the reasons stated by original commit cf75514c8e2e are >>>>> still relevant. My vote would be to keep things as is. >>>>> >>>> In my experience, checkpatch is smart enough to recognise when a long >>>> line overflows the 80 character limit because of a single long string, >>>> so the two options are not mutually exclusive. In other words, long >>>> lines are not allowed except in the case where shortening the line >>>> involves splitting a string. There may be a small amount of work in >>>> getting checkpatch happy, i.e. by putting the string on a line on it's >>>> own, but we can indeed have our cake and eat it too in this case. >>> >>> I can't seem to get around warnings without ignoring either SPLIT_STRING or >>> LONG_LINE_STRING as of Linux v4.14-rc3's checkpatch.pl. I think you can only >>> get around them by fooling it somehow. You really need to ignore at least >>> LONG_LINE_STRING to meet the requirements of the commit log. >>> >>> However SPLIT_STRING still looks necessary to address part of cf75514c8e2e >>> ("devtools: ignore warning on long log string"): >>> >>> "...lines that make use of PRIx64 with string concatenation will still be >>> flagged if the beginning of the last string fragment begins after the 80 >>> character threshold." >>> >>> It's not all that uncommon in my opinion. >>> >> If you have PRIx64 in it, it's not part of a literal string you would >> grep, so it's reasonable to split there. The user cannot know what the >> specific %x formatting character used is. > > I agree, however in that case checkpatch would complain because our > configuration doesn't specify to ignore SPLIT_STRING since there is no comma > separator when concatenating them. > > My point is that the occasional exception is still necessary for split > strings, that ignoring LONG_LINE_STRING must remain either way and > unnecessary warnings cause more harm than good (they need to be worked > around if we enforce this rule). > > In short, long/split strings acceptability assessment should be left to > reviewers, as it cannot be automated in all cases through checkpatch.pl. > This patch is waiting in patchwork for a long time now. My experience is same with Adrien's, if 'LONG_LINE_STRING' is not ignored, it will complain about long log messages, so removing 'LONG_LINE_STRING' contradicts with the reason of the patch described in the commit log. Perhaps it can be an option to remove only 'SPLIT_STRING' from ignore list, to detect split messages. But overall, I am updating this patch as "Change Requested", if there is a demand for ignoring 'SPLIT_STRING' please send a new version. Thanks, ferruh