From: Dharmik Thakkar <Dharmik.Thakkar@arm.com> To: Stephen Hemminger <stephen@networkplumber.org> Cc: Wenzhuo Lu <wenzhuo.lu@intel.com>, Konstantin Ananyev <konstantin.ananyev@intel.com>, dev <dev@dpdk.org>, Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>, "Ruifeng Wang (Arm Technology China)" <Ruifeng.Wang@arm.com>, nd <nd@arm.com> Subject: Re: [dpdk-dev] [RFC 1/3] net/ixgbe: avoid multpile definitions of 'bool' Date: Thu, 5 Sep 2019 20:10:05 +0000 Message-ID: <92C6BFD2-6165-44D1-99CA-D0290DD197CD@arm.com> (raw) In-Reply-To: <20190905082647.63966b21@hermes.lan> > On Sep 5, 2019, at 10:26 AM, Stephen Hemminger <stephen@networkplumber.org> wrote: > > On Sun, 1 Sep 2019 06:58:08 +0000 > Dharmik Thakkar <dharmik.thakkar@arm.com> wrote: > >> Compilation issue arises due to multiple definitions of 'bool' >> in 'ixgbe_ethdev.h'. >> (Please note that this issue showed up when 'rte_rcu_qsbr.h' got included >> within 'rte_hash.h', because 'rte_rcu_qsbr.h' includes 'stdbool.h'. This >> is a temporary fix. Recommend suggesting better solution.) >> >> Signed-off-by: Dharmik Thakkar <dharmik.thakkar@arm.com> >> --- >> drivers/net/ixgbe/ixgbe_ethdev.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.h b/drivers/net/ixgbe/ixgbe_ethdev.h >> index 6e9ed2e10f3c..dd4d6c022545 100644 >> --- a/drivers/net/ixgbe/ixgbe_ethdev.h >> +++ b/drivers/net/ixgbe/ixgbe_ethdev.h >> @@ -18,6 +18,7 @@ >> #include <rte_flow.h> >> #include <rte_time.h> >> #include <rte_hash.h> >> +#undef bool >> #include <rte_pci.h> >> #include <rte_bus_pci.h> >> #include <rte_tm_driver.h> > > Just fix ixgbe_ethdev.h to include stdbool itself? Conflicts with 'typedef int bool;’ in ixgbe_osdep.h:86 > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.h b/drivers/net/ixgbe/ixgbe_ethdev.h > index 6e9ed2e10f3c..cf32b1761acb 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.h > +++ b/drivers/net/ixgbe/ixgbe_ethdev.h > @@ -6,6 +6,7 @@ > #define _IXGBE_ETHDEV_H_ > > #include <stdint.h> > +#include <stdbool.h> > > #include "base/ixgbe_type.h" > #include "base/ixgbe_dcb.h"
next prev parent reply other threads:[~2019-09-05 20:10 UTC|newest] Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-09-01 6:58 [dpdk-dev] [RFC 0/3] RCU integration with hash library Dharmik Thakkar 2019-09-01 6:58 ` [dpdk-dev] [RFC 1/3] net/ixgbe: avoid multpile definitions of 'bool' Dharmik Thakkar 2019-09-05 15:26 ` Stephen Hemminger 2019-09-05 20:10 ` Dharmik Thakkar [this message] 2019-09-05 20:23 ` Stephen Hemminger 2019-09-01 6:58 ` [dpdk-dev] [RFC 2/3] lib/hash: integrate RCU QSBR Dharmik Thakkar 2019-09-01 6:58 ` [dpdk-dev] [RFC 3/3] test/hash: add tests for integrated " Dharmik Thakkar 2019-09-05 21:31 ` [dpdk-dev] [RFC 0/3] RCU integration with hash library Wang, Yipeng1 2020-08-19 4:05 ` [dpdk-dev] [RFC v2] lib/hash: integrate RCU QSBR Dharmik Thakkar 2020-08-25 19:59 ` Dharmik Thakkar 2020-08-31 20:47 ` Wang, Yipeng1 2020-09-01 22:01 ` Dharmik Thakkar 2020-10-16 13:53 ` David Marchand 2020-10-16 15:04 ` Dharmik Thakkar 2020-10-16 17:38 ` [dpdk-dev] [PATCH 0/3] hash: " Dharmik Thakkar 2020-10-16 17:38 ` [dpdk-dev] [PATCH v3 1/3] lib/hash: " Dharmik Thakkar 2020-10-19 9:43 ` Kinsella, Ray 2020-10-16 17:38 ` [dpdk-dev] [PATCH v3 2/3] test/hash: replace rte atomic with C11 atomic APIs Dharmik Thakkar 2020-10-16 17:38 ` [dpdk-dev] [PATCH v3 3/3] test/hash: add tests for integrated RCU QSBR Dharmik Thakkar 2020-10-19 14:48 ` [dpdk-dev] [PATCH 0/3] hash: integrate " David Marchand 2020-10-19 16:35 ` [dpdk-dev] [PATCH v4 " Dharmik Thakkar 2020-10-19 16:35 ` [dpdk-dev] [PATCH v4 1/3] lib/hash: " Dharmik Thakkar 2020-10-19 16:35 ` [dpdk-dev] [PATCH v4 2/3] test/hash: replace rte atomic with C11 atomic APIs Dharmik Thakkar 2020-10-19 16:35 ` [dpdk-dev] [PATCH v4 3/3] test/hash: add tests for integrated RCU QSBR Dharmik Thakkar 2020-10-19 21:05 ` [dpdk-dev] [PATCH v4 0/3] hash: integrate " David Marchand 2020-10-20 4:08 ` Dharmik Thakkar 2020-10-20 16:12 ` [dpdk-dev] [PATCH v5 0/4] " Dharmik Thakkar 2020-10-20 16:12 ` [dpdk-dev] [PATCH v5 1/4] rcu: build on Windows Dharmik Thakkar 2020-10-20 16:12 ` [dpdk-dev] [PATCH v5 2/4] lib/hash: integrate RCU QSBR Dharmik Thakkar 2020-10-21 2:42 ` Wang, Yipeng1 2020-10-21 4:52 ` Dharmik Thakkar 2020-10-20 16:13 ` [dpdk-dev] [PATCH v5 3/4] test/hash: replace rte atomic with C11 atomic APIs Dharmik Thakkar 2020-10-21 2:52 ` Wang, Yipeng1 2020-10-20 16:13 ` [dpdk-dev] [PATCH v5 4/4] test/hash: add tests for integrated RCU QSBR Dharmik Thakkar 2020-10-21 3:54 ` Wang, Yipeng1 2020-10-21 4:55 ` Dharmik Thakkar 2020-10-21 22:34 ` Honnappa Nagarahalli 2020-10-21 22:50 ` [dpdk-dev] [PATCH v6 0/4] hash: integrate " Dharmik Thakkar 2020-10-21 22:50 ` [dpdk-dev] [PATCH v6 1/4] rcu: build on Windows Dharmik Thakkar 2020-10-22 9:05 ` David Marchand 2020-10-22 18:35 ` Kadam, Pallavi 2020-10-21 22:50 ` [dpdk-dev] [PATCH v6 2/4] lib/hash: integrate RCU QSBR Dharmik Thakkar 2020-10-23 21:46 ` Dharmik Thakkar 2020-10-23 22:08 ` Wang, Yipeng1 2020-10-21 22:50 ` [dpdk-dev] [PATCH v6 3/4] test/hash: replace rte atomic with C11 atomic APIs Dharmik Thakkar 2020-10-21 22:50 ` [dpdk-dev] [PATCH v6 4/4] test/hash: add tests for integrated RCU QSBR Dharmik Thakkar 2020-10-23 22:11 ` Wang, Yipeng1 2020-10-24 9:09 ` [dpdk-dev] [PATCH v6 0/4] hash: integrate " David Marchand 2020-10-26 13:56 ` Dharmik Thakkar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=92C6BFD2-6165-44D1-99CA-D0290DD197CD@arm.com \ --to=dharmik.thakkar@arm.com \ --cc=Honnappa.Nagarahalli@arm.com \ --cc=Ruifeng.Wang@arm.com \ --cc=dev@dpdk.org \ --cc=konstantin.ananyev@intel.com \ --cc=nd@arm.com \ --cc=stephen@networkplumber.org \ --cc=wenzhuo.lu@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git