From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0061.outbound.protection.outlook.com [104.47.37.61]) by dpdk.org (Postfix) with ESMTP id 9EB011B025 for ; Mon, 8 Jan 2018 12:28:44 +0100 (CET) Received: from DM5PR03CA0054.namprd03.prod.outlook.com (10.174.189.171) by CY1PR03MB2363.namprd03.prod.outlook.com (10.166.207.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.366.8; Mon, 8 Jan 2018 11:28:43 +0000 Received: from BY2FFO11OLC004.protection.gbl (2a01:111:f400:7c0c::156) by DM5PR03CA0054.outlook.office365.com (2603:10b6:4:3b::43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.386.5 via Frontend Transport; Mon, 8 Jan 2018 11:28:42 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BY2FFO11OLC004.mail.protection.outlook.com (10.1.15.184) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.345.12 via Frontend Transport; Mon, 8 Jan 2018 11:28:12 +0000 Received: from [10.232.134.49] ([10.232.134.49]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id w08BScQ3007382; Mon, 8 Jan 2018 04:28:39 -0700 To: Radu Nicolau , CC: , , , , References: <1513083027-11741-1-git-send-email-radu.nicolau@intel.com> From: Akhil Goyal Message-ID: <92a56e18-5af4-8154-6fa1-13deacfa4933@nxp.com> Date: Mon, 8 Jan 2018 16:58:37 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <1513083027-11741-1-git-send-email-radu.nicolau@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131598844927436460; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(39380400002)(39860400002)(346002)(376002)(396003)(2980300002)(1110001)(1109001)(3190300001)(339900001)(189003)(199004)(24454002)(2950100002)(305945005)(106466001)(8676002)(76176011)(83506002)(77096006)(67846002)(2906002)(4326008)(81166006)(97736004)(229853002)(81156014)(105606002)(64126003)(356003)(2486003)(8936002)(36756003)(53936002)(65956001)(110136005)(86362001)(47776003)(6246003)(316002)(31696002)(23676004)(230700001)(85426001)(59450400001)(31686004)(104016004)(50466002)(65826007)(68736007)(498600001)(5660300001)(54906003)(53546011)(65806001)(58126008); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR03MB2363; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11OLC004; 1:1U4pp7EVY8CRuxTBIM+w3Gnxxs/Q8ZqTa1pASI1u35GGKKI1Dt+gtaeWRq2IqEAVtYc6aXP2A+C1QmKIwKSEWq3VMTuW/BSmkcz3PJ9fNa4QlxVtJpeknwl8uwOj8rjC X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3d1b0e15-cb40-4909-66ac-08d5568ae737 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4628075)(201703131517081)(5600026)(4604075)(2017052603307); SRVR:CY1PR03MB2363; X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB2363; 3:99R3RJK4ZKF9nX/TSBIcfJ+x0EKnN/ELRZg+4EjczkybXE96M9bkgDuevKDTSuBXOUvInqnNXoKiT5YBzvZkR2mrx39vOLBft0QJqTuXTEWQu+4jCOb6FpOrAzZcU1IGHiujorsqOsXKsRo7H5DkWGiSXRTKapoLYLGidIXHc8tJfuvuOGxidkr526rV5fhkuEMYR7scqGFiJIgY48NYub+Xw3iblSQCx4uzx7F4o//ZDF1h78if08HjOp3MjmtakkhIkeML+p4C/fsv4HnsxtyJ3TBnY8oGKksFrN1DiqiQxTEXGO/8P3ZJu65kQI2lgz9CtbiBMqyB/IScbFP1NvcFnf8VDSXIU3kw7kHZZ6E=; 25:x5nGx7rgADbX0blacUlcWOGbEhvElbIhruupAbD7qgOOEnJphTOzI//JZodxJyYAuEgubCjDhBwU/gAzbQvDDxpVBNbcVH8BHkaVTfOvDUfJAKjLe5gHgPw5VxtAZzhSx1qD6uU5tqF2qyuT1LRg6kwxEyZ6cr8IoqMuMQ1ps/8vid+TppoekXH28TH7CNUb5Xdcra0WBnzXQhm0lCbihdsFBzhpzQgHCRdEuqk7+2Ml0opO3GU0mIYNtpsNKKD7/fzbOcvnPmUEZq0NYa4Bq8+LL7XKn9MPReLNuTfCNjWttBrYdtW4TTQfgRr6IJ7g7cMB8NwJbqAaphImfa9iFA== X-MS-TrafficTypeDiagnostic: CY1PR03MB2363: X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB2363; 31:PKjE6jqSOCEUUjvi2LHt2DIVQiJd2WVszbLEcsbv8w78wgV5MEzOP/Pws1/25/85HJgMg2GWNaCOOH31J/oFnwgnmUtvU2L+3T32PAotHiooISPSqngB/d5tpP8nsa7SRR9scLSl2viA6a27qhVXo6M9naCvqmNhMqr/8ge6rjjKzHL1pULsoKzjwhYN3JYls1/F1JAErEzxCiALJrFd82Okgn+I2rImVzoiYXPvo7k=; 4:iPHlI8f1DPOMw5U8m2jQAw3XA18jMD3xBWO6NixdTW+duBoZ0B8LLg8Wl70CQTfh1qVBvdadjkfb9xHFywNxFzfqE5BP5VmGUcS6Sx/ZhKD3+DyUPOWUpwqZ+tNihEpxg+5vMy1Jlme2TU3vccGkwdVSkL0pEczx3jvSoAoTjDni5wxpoxgI9EcWT0cMjjxZiKiBx/wdLo61EKAsX40Kb+GFGKjy9anMbxbnUJhyXkUjc/qJFVXSqEFfgg3VAKu06AOokpqoxm3XGxapRDxUCAUjQiJCM708BfEfUZiPuQbpwIteUcYzfVGOpnd5N4YjrSygG8BC5CwR2pltdZq5RnKshMvrLlJxlGWnTKWMyf4= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192374486261705)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095135)(2401047)(8121501046)(5005006)(3231023)(944510075)(944921075)(946801075)(946901075)(3002001)(10201501046)(93006095)(93001095)(6055026)(6096035)(201703131430075)(201703131448075)(201703131433075)(201703161259150)(201703151042153)(20161123559100)(20161123563025)(20161123561025)(20161123565025)(20161123556025)(201708071742011); SRVR:CY1PR03MB2363; BCL:0; PCL:0; RULEID:(100000803101)(100110400095)(400006); SRVR:CY1PR03MB2363; X-Forefront-PRVS: 054642504A X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjAzTUIyMzYzOzIzOmo5UHA5SFMwQzhTdGIxY21vaFdnK1dLbEFB?= =?utf-8?B?L2hBZlhBSkpLRjNvSFBZRU5EVGpCMVdkeVp6SG8ySXNBeVN4YUowTmRVbGhk?= =?utf-8?B?Y1pNN3REZGU1aFQydUYzMjNZQkpwRjlUMWxkWUxabmo2bFNmWG1oSGdpaTR3?= =?utf-8?B?bHYyOE9zQ0JpRHFCR25pNGo4WnNMYTR2eklBUHhISGEwOEpNSmNJMDA3amVp?= =?utf-8?B?VmxYNStBRjBxUEdiNkltRFpRZ0ZiWmZzZVByZXVBQ3AvRHRRNzF4N05tT0tU?= =?utf-8?B?V2MzRHhWYlRVdUw3cG5TcTE2V3hJZ2ZKSm9FYXVOc3pWZkJwY1lVQ0M5d3Vv?= =?utf-8?B?ODVlZGNuV216dWtRd0tNQjlGZW1wcVdvbjZXTHhDaGRWdDJ2anFaclFsQmJC?= =?utf-8?B?RW9zbnN0bVZydDJzdVNpVU1MNjZRZDNXbFlpbGtaWG0wVitzV08ydDJuTHI2?= =?utf-8?B?NkxoRHRvWnVINWlnL1U4ZGlWTW5PblcrVFllbFpmUnJGdE1yNzlSMHBYNG4x?= =?utf-8?B?K2M4YjVuZlVmdVhzU2tmQy9HUVJYbC9pRDkybjdramNObFdDSC9HRnAwQjd2?= =?utf-8?B?c25HaWx0U2Q2c0JUdkYyNUpnYlhpTG1LZzVPbnVRbXlqZFNOMUwwL2xtUlRT?= =?utf-8?B?RlVjVVN5Y0paWmJuVkF3NElJa3JMa0pKNzlZSG5QRjRtM0NhWitycmNxSm1K?= =?utf-8?B?eW1TM1JBUXdPbFpGeHRDYUxCM2lqS05LcU1ISFBvQmFCSmphaXkwcUxqc1kz?= =?utf-8?B?Uy9DMEU1d2g1eGdNS094ZzREL1NwLzUxeGR6M21wRTAxdG1pVHlGKzk5RWhY?= =?utf-8?B?d3F5bXZqQVIvM3I3Q21VVFhZbG96TUFyV3dKM2N2NzlUajhqRVVrTGlibmVE?= =?utf-8?B?eklxd0ZHaG05VWF3TkNQbkRac0hQNG16TlBkNi9RNVFFT2VrT3ZOa3ZyeHR5?= =?utf-8?B?MDRwWmdhTDZiZ1NIWFdFMmxzME5RWVVOTldXUTA5cXU5UmhrZUk5c2U5YWVt?= =?utf-8?B?VGx2aWZvYTVqZ2xzS0NjaklMYkxVQWhFVnVvZW1iTTZJQnhnZ0F6VW5peDZy?= =?utf-8?B?dDAvVUI4VTJOc3dvZUs1UUcvY0h0MTBlS2svcE5aTXgwUWdpc2ZpN2ZvQ0Vh?= =?utf-8?B?SG4xUk5sdWJsWExNR0NJcm8vTndhTGRrZlFvbEtQTk9RZlA0NTNZcmpXcm4z?= =?utf-8?B?UzRoZENDZGZvVG53L1N3T3gyRExKL0FlSFIxQTFwbTVSZnFITlRtMldCZS80?= =?utf-8?B?YTdXcENzaVNSWnJBenRiSXhiaG9qV2hBUHhQeEtEMDFaL0VIdkVJZGVUc2Qz?= =?utf-8?B?WWMvS0ZueHFkeEg3Q3FsSjlNOFBFWm53d0d5T1lvL0FGand1cEZYaEZ3dXIr?= =?utf-8?B?dUt0bXhHcHA3dVBXaExtVXhyZDFYa3VaSFpzVmdjeDZvdXlEbnpxQ2luUW5z?= =?utf-8?B?clVMNHpYZ091QWY1T1FzZThmU1BwanRHUVNlNmlwMjRvRlVOa0xWbkpMMExE?= =?utf-8?B?bEZXVWJoTjRRaHIzN1p6dVJaQVp2VWJTSHRmNnczNk11NWFwMTZmOEU1ZUFQ?= =?utf-8?B?c3VQMHBhWVMyR2gzM05WbVh6Tll0OFJEdk00aG9YQnVCL1ptMUdKRFgrWG91?= =?utf-8?B?QVluMGUrMzg1ZlFUNlFta2NpMVRmZ0RucWUxdmZLTlh5U1VDY2NXMlFqbDBw?= =?utf-8?B?TWk2eDJ3c0VSMUtINGlBNVVkYXlvNW9abFE0ODRNdEo5RmJ6LzhKZ3dCR0E2?= =?utf-8?Q?QtNbZYeYG5UN3hAgYY0gOw5KVq/nZ83W4E81s=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB2363; 6:WbTur4+Y3wQ3fhVHF4lzhuFLbqlBdLBklnDdN5muAxmP2gB+akL5F2C40iauvj0dQ7WeyMBUw2nJJWySpwOC0Lh5VNgw18chsNEB0M0UcpUMB8ekb06d2QhV+ooeBbHCL0sdPugQH45MnGLFo1/88q7nPKMJDtvGNyZpy4Hia/5NU+UCQgYiNAzllqjgjKOwYArV0eeNR8yKynZVrC/k2L0nQZfmd0S56Uxq+HMi7tZ6mzsoLtFWrKoKlD7Ljl/ftsSeb5tT97cRblyTQYei2MGH+aUCD872O/dDR5eNSITcwWWBnjZEk414xOuhLQR3TZv/mGy63x76AG8x2uZwTHNjqk/SdSNoFRyHJUl8wvQ=; 5:I8lE6T2vxziIQTmymfCYHPdiHSWBgOBKf6+tJ9kqaoeBaRxEPK6nJPXY/QBUyESEBNUWM3pakTKt3FwUkR56MXZS5y5lUA4rZqxBu2GCNtAEhlJQvLEeySbpx1LDl6p6s4NArU4912vCBhvGGCZaL5JIccsS0zoUVUzBtODsgYo=; 24:AuyMxEDxMfmYQ7lmmDUdpAdW9V2x8eBSEWEAQBB2pDc+P/I9rbP+t0fXz481rXdeY0Pv8m0Ui4x1RaQUEhEIjiAkUneWaUDSlVcOJx+pElY=; 7:v67BqSDSZVvFHTcMSwkK4WfxBCayWsZrAoVdMO5Oh1HW62E9qL7+AD2QeG25M3P2OX5eqVOaVYZOzl+W3Uyz85V/ByLf8hGpVIH8nEvMT+Fnucjhycs9bkFo/PrJ0oIkxPjbdAs6gtblJe3wJpr5BTYfNwJwb0CtLxr2gfcItJuh/wQkbPgoowxWhxjHIsXVkh+MvC6MHPGfY2Q4oLuiMuiI+9jygnT634Ls13EdV1Hlyu2bYwCL0J7LoJDaugIo SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jan 2018 11:28:12.5564 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3d1b0e15-cb40-4909-66ac-08d5568ae737 X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB2363 Subject: Re: [dpdk-dev] [PATCH 1/3] lib/librte_security: added get size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Jan 2018 11:28:45 -0000 On 12/12/2017 6:20 PM, Radu Nicolau wrote: > Signed-off-by: Radu Nicolau > --- > lib/librte_security/rte_security.c | 7 +++++++ > lib/librte_security/rte_security.h | 12 ++++++++++++ > lib/librte_security/rte_security_driver.h | 14 ++++++++++++++ > lib/librte_security/rte_security_version.map | 1 + > 4 files changed, 34 insertions(+) > > diff --git a/lib/librte_security/rte_security.c b/lib/librte_security/rte_security.c > index 1227fca..56f2345 100644 > --- a/lib/librte_security/rte_security.c > +++ b/lib/librte_security/rte_security.c > @@ -70,6 +70,13 @@ rte_security_session_update(struct rte_security_ctx *instance, > return instance->ops->session_update(instance->device, sess, conf); > } > > +unsigned int > +rte_security_session_get_size(struct rte_security_ctx *instance) > +{ > + RTE_FUNC_PTR_OR_ERR_RET(*instance->ops->session_get_size, 0); > + return instance->ops->session_get_size(instance->device); > +} > + > int > rte_security_session_stats_get(struct rte_security_ctx *instance, > struct rte_security_session *sess, > diff --git a/lib/librte_security/rte_security.h b/lib/librte_security/rte_security.h > index 653929b..2c5429f 100644 > --- a/lib/librte_security/rte_security.h > +++ b/lib/librte_security/rte_security.h > @@ -312,6 +312,18 @@ rte_security_session_update(struct rte_security_ctx *instance, > struct rte_security_session_conf *conf); > > /** > + * Get the size of the security session data for a device. > + * > + * @param instance security instance. > + * > + * @return > + * - Size of the private data, if successful > + * - 0 if device is invalid or does not support the operation. > + */ > +unsigned int > +rte_security_session_get_size(struct rte_security_ctx *instance); > + > +/** > * Free security session header and the session private data and > * return it to its original mempool. > * > diff --git a/lib/librte_security/rte_security_driver.h b/lib/librte_security/rte_security_driver.h > index 997fbe7..3839d45 100644 > --- a/lib/librte_security/rte_security_driver.h > +++ b/lib/librte_security/rte_security_driver.h > @@ -91,6 +91,18 @@ typedef int (*security_session_destroy_t)(void *device, > typedef int (*security_session_update_t)(void *device, > struct rte_security_session *sess, > struct rte_security_session_conf *conf); > + > +/** > + * Get the size of a security session > + * > + * @param device Crypto/eth device pointer > + * > + * @return > + * - On success returns the size of the session structure for device > + * - On failure returns 0 > + */ > +typedef int (*security_session_get_size)(void *device); I believe this should be unsigned int. For rest of the patch Acked.