From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 229E745616; Mon, 22 Jul 2024 00:56:20 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A03E2402CD; Mon, 22 Jul 2024 00:56:19 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2065.outbound.protection.outlook.com [40.107.244.65]) by mails.dpdk.org (Postfix) with ESMTP id 5833E40270; Mon, 22 Jul 2024 00:56:17 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=s6F4OQOi5QUfo+B2ElipEupGa6l3GYv/opeNFzk6WlKivWzHpDrmZGm3h7tFxRAFkn4l1PpK4qqFe032VfBaoLb0uNfzOv54Foeuj50QDt9long2n4XgaZfTWtzMCc1tf69rgSIFT47lzaBrsDLxU2hs0AcntYX4fJm7nNI1kUKUOtqAU5u7gjzBREoqrbHIPeaJFgo9/f3ZB1GGaEDdVqcVh8UjiwMogs7g4KcUvHlTkPPjerAAoZz/5doi63hop/P2xjWS7gbEufoYcZlBFJCRZYXR1aeeuV7qlev/cDp0ChRnTB8BkHL/NkOwJu6dxgJnEfQE7gFT0p10Z+esvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XVFb2on+Hl6kZB4kC/dSpTOzZx/C0/8P3mXPCFoyU8s=; b=Syfs/NfJ0r7OZ6tS+v4y6zTAxndJJAbbihN2U1aR4PTWgT/5Eat0obaFyhsoEhicTdZL9twO/XhhajNvKkDq2DM8WHANdpDzBnVz64fW5iUDDy7hSwIQE2u4C04IBI0Zruy3A2ExpeRf+UpRKJ4fQRM5nxKqBn5vv5l5YnrW4JrHwpBYnqhm6vDkc4EU3FesIZaHNvmsdPZjhDTxvRKR3BM17ee0OUeNPZyIhMEURytbl7RMGcviZGeDJS7mQqaBrVcII9czD9TfIwfcN7A7IqfqRc2TQ3QBfpFwny1M5sk221++jFqnXyrVXqpiCR6GMRicNXGPhhX+PUlFYPdQQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XVFb2on+Hl6kZB4kC/dSpTOzZx/C0/8P3mXPCFoyU8s=; b=yteS91eEsmoqE2EpgzGTWRgHvlmr02bnZ1mr/d7T9Ke4EO0xDaqlCcdwPVOZkel8Amw22SIzwbM0H9EWrSgknzfqUS2Sb7gY0uNg3XU4Tndw1S4m877+E8bdgDDvmbBUCdQw2p3Jy9Mn0nVL7cN+AodILgR0cI5iJyeDYoL+nLg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CYYPR12MB8704.namprd12.prod.outlook.com (2603:10b6:930:c2::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.29; Sun, 21 Jul 2024 22:56:14 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd%4]) with mapi id 15.20.7784.017; Sun, 21 Jul 2024 22:56:13 +0000 Message-ID: <92bc58fd-4a77-464e-bc49-e012b428834f@amd.com> Date: Sun, 21 Jul 2024 23:56:08 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ethdev: fix device init without socket-local memory To: Bruce Richardson Cc: dev@dpdk.org, stable@dpdk.org, Padraig Connolly References: <20240711123500.483119-1-bruce.richardson@intel.com> <4f7e619a-0398-41cc-90a9-3c52b73d1c49@amd.com> <57b08bdb-5f45-4343-a8d2-598d66d82fe8@amd.com> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR4P281CA0135.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b9::20) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CYYPR12MB8704:EE_ X-MS-Office365-Filtering-Correlation-Id: 495cc246-9cd1-4f84-7207-08dca9d85211 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?aFEwTi9LaG5JYkhMc2o5YlBIcHFvTHAvV2dyNFFqd0h0RmxVd1p0Rm1mK3k5?= =?utf-8?B?UUFpek1aVW9CVGZpZU5ybUZDKzJHNnhqUjhhaXpGbzM3UHVzWlZSaFJJN3dl?= =?utf-8?B?N1FBbDZwZng1Z2tvVWdFa1ZsTFNJcVMxekN1YVN3UlJQa2wrZWpGcHRWcU95?= =?utf-8?B?SjlGMVBDODJZZjNwTjR3VWVHOWo1cXExMTNlMlRma0VkYW90dFlrTDh1WUVp?= =?utf-8?B?VTI2eWJBNTBpQTZQRUlvanFWVWtWaU8vbEVFYUMrdGVjYmVrekl1bG8wenhV?= =?utf-8?B?OExYU0ZMcGxwSGlsd1J1RjN3QXNmK3VUYm5YOUhXd0ZBOUwzUU9icnMwT1R4?= =?utf-8?B?aENTOVNtVXVzak5TQ1M3dzdxS1YwT1FrTEl0TlNvUmIwRUdJcVVFclZreFFP?= =?utf-8?B?ZHcrSmY4cW5sRGpUb3JJaGZSK2V6Y1o3aGlFaVNBYzVFQ1BCNThIditxN21P?= =?utf-8?B?Y0R4aGhwVUthNzFKa3Ewa1dQckRMRlh0Y2tzUUVTWDZwNmdvdCtGbm53ZEJ4?= =?utf-8?B?TVBaS29zaHFGaUxIdzZrQjlWbVBXWklpcXdiTnRTbnl3N0Fib1FhQ0NxRXVV?= =?utf-8?B?cjBCK05YTWxTRUFOUDZMZDBTVGhiQmthWFJCUmtrRTJtSE1qeWdHR2duTmpn?= =?utf-8?B?QWtzb1owdkZKTjlPZWp5c01NdTI3MVZaZ0lYSG9JNFVLYWN6Q1diT3c5Vkc1?= =?utf-8?B?SFYrTnBKbXpOUytWQkc3bXRhMzBQb0U5VjlYcmFiYW5VSGduZi85bkIyWHhu?= =?utf-8?B?VG5NY3pVVW8xcW5rSTQxTk0xejJwbjdJL3JCWDcrYVZFdk1ndW1rMVNlRGgr?= =?utf-8?B?SjNjb2hHWmk5aFpwS1R2UVk1WkpLcUpuSXRzSndveWEwekVJSzYzZFhqSGV1?= =?utf-8?B?N0J6V3FZUnExMzhFbHBvYWNBS0VkSmpaUitrUFJQSkdCWmV2VjhNTTgwM0dH?= =?utf-8?B?WHFQb2ZUOE1iWGxsM1NNMi9nY3dISXJ2eGFXOUtWQ290c0pPZU9GNHVjdzB0?= =?utf-8?B?MVZ6Qjc4dDEyQVVSTkU1dEJpTUNNTlgwRUFmUnA4WmxnWlpNOFNYcWxLc2ls?= =?utf-8?B?b3ppSjVhNzRXbE1aeURkQk43eWE2cTJGVVR3Q3pNcUtRYWw4bVRpZFFuS3RQ?= =?utf-8?B?N3dVNFVTVU1rYURSdnZlMmU0dnJrTWMyNXRtQXBYNzlJMFhicklhK2ZYeFRl?= =?utf-8?B?VU5pNTdoM2lFTTA4OXVBWjdPa3B0b1lNa2ZnVTluT21SdnBoUTQ2TFlzVlQz?= =?utf-8?B?SEJKdGgvQ2hCRVlGRENvMnFVWmwyTlZJLzBsMkpwYnhqYXpwMUxzSXZ1VHpo?= =?utf-8?B?RWZFRUZ6YzRISi9yWjBaRmlpQ0RQa3laQ0diQlZFNTZXSXZCUlFOdktSNjQ3?= =?utf-8?B?WHNmeDQzY05KTVh5eTI3N1BaOVpmUmYvM1Y4Y2k0eXcySWx6UWVDSHZMV0Rm?= =?utf-8?B?Sy9aSlREM3FwN2UyYXBaZDBzSHVHWkE5K2R2aGUvdkppcEJBQTM5R2ttdWo3?= =?utf-8?B?ZTF6bldXb0lqVnoxd1ROMkZpanJmcDFQY3gvVDZNNlZETHAxN1BSdmRaVnVF?= =?utf-8?B?Uk1lYVNYQmJ5SW1RaWlRRVVRWmhiM1NkY1RHMHpVMElLNnA2UW94WXVhbDc3?= =?utf-8?B?eFZQbGhPR2JqSlFnNGZZYXc4d3ZmcFZTOWI1WVk2eXorQkg0aXBMc3BWdVdp?= =?utf-8?B?TyticUVsb1lCT0VPSlMxWC9iTFFKdm44VmxaYXQ5a1JWWkNTYlNFamFKUkdY?= =?utf-8?B?NmtqM3p0aE1HcThsWVUzc3ZJRGNBQnVkWWk1ZTZ0UTRkOFZPQk1vdjNqa0Vm?= =?utf-8?B?b3o5QXdWeXpGOWdLMEJGZz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NFNLZENTMFFxTytpcEhJN0ZBOTF6OFhselRaSUQzZ1hEeFpHbko4d094L2t6?= =?utf-8?B?RGdPZE51azk0OEpmOWw3RXVma2ptbVg3ZW5haUNreTZLNW5mK3N4V3ZRVjdo?= =?utf-8?B?d3hhVlFtbGdEZ1BVOFNaVXF5WHYvMjJsaHk3ck9aUjJOQXBscVEvZTE4N2dE?= =?utf-8?B?UXRueDRIaDNDN2NUcVU1SG5HcWlVeU1ycTdBSTgyVDVVMTRQd1krdG51S3R3?= =?utf-8?B?SDVwWnpiR1F2Qlc0OEU3Sy9NYjV6ZFhlSlcyRUhZYXVlMTEzcDFLWkRPK1lR?= =?utf-8?B?ZnFnT1pNckd4NGpnMjh6ZWlQVnhGTXZWQTNLNWdzS2RKaE1sd1g2SmtmYkdK?= =?utf-8?B?VW56Q2VlOUJIbjZHUXREUE1UTnZ1V3RuZjNoemxTa2NuRFVnT1BnVE9JeHkr?= =?utf-8?B?Q0pPOThjd0NENUYycDBQU21hNnE5aXR6dVdSR0RCbWt4enpwbFhRUzFnYTZl?= =?utf-8?B?Njhnb3lmR3pvVDRBY2FsdWJDMkQ0alBQQVZzQWVkMURYUHBCa1lZZmp3NS9y?= =?utf-8?B?dlA1ZG1VR2hGU3E2YSt1YUZCN0lRMHJhSmtRcEwxR3hhV2IvOGhvZDlrRlFt?= =?utf-8?B?OE1VZWdGSTBFT001Q0dRSGJLK0huQVhZdTFlU2x4c3ZySXpJMmJNb1IzYjdS?= =?utf-8?B?T01wK0lFQWxQbHAyamt5UDkzcVFsK05KcitOditwY3BvUHFxSG8zclpRM3BX?= =?utf-8?B?Y0w0aHZWeDF6ZGM1SU16V0hIUnhGOG5sQzhuclVBei9NN09xQmZFM2RocjVw?= =?utf-8?B?SjN1S0NmSDE1R3JWQjVRdW1mVHF5eWdWb3lTMmkyU2RiWW12OGp0UkFxcVda?= =?utf-8?B?Q0Ftb3BqK1hMNERpc1d4YXp0RUI4UTgwV1FSWmpQNk1ISzFvVzdhQkc0NUdL?= =?utf-8?B?NzB5b1lpd3BjK3A4R0dSNHZVRjhkclNWSGdkQW54endxanA1dGk3V0ZMeWFH?= =?utf-8?B?d0FMcnhZR0QrdmYzczcxUDRrUzNpRmlaTGlwQkNXRWpYT3ZhY0ZZSGxuN2lO?= =?utf-8?B?VTYxY0xib0FHZFZXaEZtOXF0cmlLMytmY2FOZ1N0YXA3MGdJejlIMEI3ZW1r?= =?utf-8?B?YnpSeDBEZStwdHZaVWJlVjEzaG4rZHpZV0F6bHd1L2FPaGFFcThheFVHUEZS?= =?utf-8?B?MWRha3hHYWthRFBiekg2ck52SFAxWndXaDVLUm1zZ3ZYNXVETkhORUNNMnBU?= =?utf-8?B?c0JUUzFLQTVlY0tpcWdjdUlVcU1Yd0FnYnZ4djV2NlU0ZWQrQ2VGNmIreVF6?= =?utf-8?B?MjE5blc4a0ljT0JxNGpLRFdnNkpSZzU1WEoxYy80MlJxbVdTblZEQ2hRak8x?= =?utf-8?B?TlNWKzBmODEzK28wd3NQYk9SNEFzZ0lwRlAzUDVWcUJnSHZ3WkpCa24vd1RR?= =?utf-8?B?TjVOcnczUXl3MDVhSkd1Z0RRYlIvd0lMbVdzMGxJc0tFNDNtZlpKc05HYWQz?= =?utf-8?B?dSs0UkF5T054YXo5V216aElRN1RPUVk1ZGkzMGJJYTZUSGQ0bXh4WDZDRnFN?= =?utf-8?B?bTBHTldXQ0FQM0lvdzVKdVdBMC90a0ZQVlVjcEdyVWN1Z3QzZnpJZnJMYzM5?= =?utf-8?B?WWdKSEtFd1lkT1VoUU9xb0Y2OXdPQzBUZkV3RFdYZlh3aCsrd2dFWmM5ZVR5?= =?utf-8?B?Q2hISTdRWlN3ZHk2WVR5a3JVOW9MSUo2UnR2aEEvRy9PaDJad3VjQXY4K08w?= =?utf-8?B?aS9kUEtDZ0VKU2IySWppVmx3UHhGQ3BLNEtWb2Z2d2hLVm9QeWNabUpnaGdN?= =?utf-8?B?M1Z4aEtnbUIwaWNCRVIxaExQN1h2dkhSc2NzVVRlL05EbkpzenJqbkdraXNG?= =?utf-8?B?UDlhNG9xTWpHdnFCTldaRVprUkVHdUJ0UHVJZTRYRzBaa0NsN0JqUkJIVmpv?= =?utf-8?B?YUFqNFNSK2tiZHE2YlQzemJnU21KY2JUU2VBVlVtZGR4S2RCQ3o3Wm0rSHlF?= =?utf-8?B?YWV0QlhZZ09aUmR3MHpNTitDUUN4RlRqVjErb3VFdjd4cURGUVZnY2kxZW9W?= =?utf-8?B?cFNDRkhNM2k2RjFZcFNDWUJJZXhoRTdvM21SZWViMGJLMk9uYmV0SVorUHFV?= =?utf-8?B?cEg4emdqQ3BoeHZtdGNYTWNqU0xYbk9uOWtDbGtpS1dCaVc3WUw3cWdGelND?= =?utf-8?Q?qo4M=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 495cc246-9cd1-4f84-7207-08dca9d85211 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2024 22:56:13.7357 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HtZlcLhveJxcfKYZeVCR5YKKUD2gNF4szMexW1PUWGZ99uuyBRTOHwDYlDm1R9vT X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR12MB8704 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 7/19/2024 5:10 PM, Bruce Richardson wrote: > On Fri, Jul 19, 2024 at 04:31:11PM +0100, Ferruh Yigit wrote: >> On 7/19/2024 2:22 PM, Bruce Richardson wrote: >>> On Fri, Jul 19, 2024 at 12:10:24PM +0100, Ferruh Yigit wrote: >>>> One option can be adding a warning log to the fallback case, saying that >>>> memory allocated from non-local socket and performance will be less. >>>> Although this message may not mean much to a new user, it may still help >>>> via a support engineer or internet search... >>>> >>> >>> Yes, we could add a warning, but that is probably better in the app itself. >>> Thinking about where we get issues, they primarily stem from running the >>> cores on a different numa node Since the private_data struct is accessed >>> by cores not devices, any perf degradation will come from having it remote >>> to the cores. Because of that, I actually think the original implementation >>> should really have used "rte_socket_id()" rather than the device socket id >>> for the allocation. >>> >> >> Yes I guess private_data is not accessed by device, but it may be >> accessed by cores that is running the datapath. >> >> This API may be called by core that is not involved to the datapath, so >> it may not correct to allocate memory from its numa. >> >> Will it be wrong to assume that cores used for datapath will be same >> numa with device, if so allocating memory from that numa (which device >> is in) makes more sense. Am I missing something? >> > > It depends on which you think is more likely for the polling cores: > - they will be on the same socket as the device, but different socket to > the main lcore. > - they will be on the same socket as the main lcore, but different socket > to the device. > > Personally, I'd suspect both to be unlikely, but also both to be possible. > For the first scenario, I don't see anything being broken or affected by > the proposed fix here, since priority is still being given to memory on the > same socket as the device. It just opens up the possibility of scenario > two. > My comment was on suggestion to use "rte_socket_id()" rather than the device socket id, if both nodes have memory, memory should be allocated from the one where device is in, because although device doesn't use private_data, polling cores will and polling cores will be most likely in the same node with device and memory, but we don't know main core is in. So I think first try for memory allocation should be node where device is in, which is the existing code. If node that has device doesn't have any memory attached, your change enables this case, as already there is memory only in one node, it doesn't matter if we check device node or main core node anyway. Briefly, I am OK to current patch with a warning log in fallback, but not to "rte_socket_id()" change.