From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 85A85A0548; Fri, 3 Jun 2022 01:08:31 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2E6AD40691; Fri, 3 Jun 2022 01:08:31 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2076.outbound.protection.outlook.com [40.107.243.76]) by mails.dpdk.org (Postfix) with ESMTP id 592834021E; Fri, 3 Jun 2022 01:08:30 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K0F07IxfKpo4QTpwkkhE71dU/bBR804M7OOvv3piQ8kSvcKDPvSdplWmhSHbeRTQdcfFj+GG4b3vLcD/ISJrsbi/umspmky055FlsS0ddRx3qsTjnNKSIpdJRbysjsWBTy7/iAKcsRHTe3ehA51OprtR+th7XseAhjK7h9sCowS+0/w4kHnpM/I5boT6gO2EWW3g8l3r2fpWXVq+6eLWp0FCqQXK/agy64LG6w0+a+cCSZNS8x9ElizLiTg+oEZ7+VNNgLcGCHre1Rv8On1hvSPFXICokADdmPtA/1S5A8jhkfGx7hR8UWOzQaqwnctdOvMhq9/bvyl6jMNTWxxzHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JG6KziaS5uPylrLKXLdcqNZhPax7Er9dLZgoddAgYZA=; b=QQZQ95eoTBqSqAylW1BwegXGMctvdQV4jqU6/823Hcr7348DByLXVyp3YQTT8rr3pv7dBhz82gwb9kIJP1TOIp6EwQRIru8QGfKvwptUHXS59D85UW3qEFmdmMAtHXu9sWe84UjYeJ4oGGyl7LOeiLD8QQrj/Tw+0ADfSsqIAessYvwyU8A3AnV4fnL6xFQIUluqcKixt9GBj2m5bHKZ6fxroLA4ua2n9UNLu7/Rrgc/O/DaPbsIn1+wufs/Ryl1ol2shEsuLqiikkwXftMU7nWGqpI5oKn8tJ7tfPJWQ9+YoptwQV8xDSb1OxjJF5glNvNArMBMvOuQSGbM5O5yEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=huawei.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JG6KziaS5uPylrLKXLdcqNZhPax7Er9dLZgoddAgYZA=; b=EGIUz/cB+BVlEtwyuw313H6IVXMAcrv2pClmbCGtxtxRDBfgyIScMTcUU6DH5H6Q8Pl59sQXnDtMDMZ/GIXhKcSuBoWScpc9ER4f20HDnMp5RWCVu2RXGTwsDlgyq25Kswrh6riMyDyCrz9htv1UXXVlCaHUpPnoOjn5XDKXHXI= Received: from SN6PR05CA0036.namprd05.prod.outlook.com (2603:10b6:805:de::49) by CO6PR02MB7697.namprd02.prod.outlook.com (2603:10b6:303:ad::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.13; Thu, 2 Jun 2022 23:08:26 +0000 Received: from SN1NAM02FT0064.eop-nam02.prod.protection.outlook.com (2603:10b6:805:de:cafe::48) by SN6PR05CA0036.outlook.office365.com (2603:10b6:805:de::49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.4 via Frontend Transport; Thu, 2 Jun 2022 23:08:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch02.xlnx.xilinx.com; pr=C Received: from xir-pvapexch02.xlnx.xilinx.com (149.199.80.198) by SN1NAM02FT0064.mail.protection.outlook.com (10.97.4.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5314.12 via Frontend Transport; Thu, 2 Jun 2022 23:08:25 +0000 Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Fri, 3 Jun 2022 00:08:24 +0100 Received: from smtp.xilinx.com (172.21.105.197) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Fri, 3 Jun 2022 00:08:24 +0100 Envelope-to: humin29@huawei.com, dev@dpdk.org, lihuisong@huawei.com, stable@dpdk.org, xiaoyun.li@intel.com, aman.deep.singh@intel.com, yuying.zhang@intel.com, oulijun@huawei.com, ajit.khaparde@broadcom.com Received: from [10.71.116.16] (port=10803) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nwtvT-0006Lm-GN; Fri, 03 Jun 2022 00:08:24 +0100 Message-ID: <92d5d8fa-2e40-1b47-d44c-9801e1069129@xilinx.com> Date: Fri, 3 Jun 2022 00:08:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v5] app/testpmd: add help messages for multi-process Content-Language: en-US To: "Min Hu (Connor)" , CC: Huisong Li , , Xiaoyun Li , Aman Singh , Yuying Zhang , Lijun Ou , Ajit Khaparde References: <20220228032617.46618-1-humin29@huawei.com> <20220307010435.56784-1-humin29@huawei.com> <856292cb-de33-507e-1de0-4625d7253694@huawei.com> From: Ferruh Yigit In-Reply-To: <856292cb-de33-507e-1de0-4625d7253694@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: de6fff78-c967-4eff-b22b-08da44eccc87 X-MS-TrafficTypeDiagnostic: CO6PR02MB7697:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WPPHHidCpvVu07a24hHaFgOi6nXKUac4n5tXrVeEz5MhndKf1ThothrNQWCudT2AGWGdW58f1bRG5ZRZMcDCIdFw3l9qxXsconu2H6N4xDtw/iJuVM9jr28xn5DMaLHmAhvO3vPyk4292/TqJp43YX4lAmcxWCs+g4GZmUFNs/8weWdZ6NyubvZ/iPlHwXG0ddW7QPd+3vfBx4q5UhKeDgghhdOWyYkP6b0YB8UVe5fapV+YocIRoQtqvs5w1dKKaFFO2eX+7zFiAWhHrpnMWFS0q/nOwc0Vs1n2aauMfn+3dlui+hubDyZUq/NcnewRSWH0S9ZxawxH/v3q1psLkbsDzxOzbdQ+d15EVPdsS8AExCj/jYr6SWKHLsqBuPNzcFy+wf6KZoHUsjAno1bJdIPPugZOj1vcpU27uAxBsMDqRoeq/8vZGm04CN1mUALyF5JHflSKOULL75iM7/1Qw3FeTPa7pRAmxpqHiEU+fqm0lm9gAlhlsV5NOcRIEGpDhMZSu1y+oepEsd83K6NJWDbpNdemzHRZvHo0X7WT72EmRPNcv4UvuzJ6anm48vWF1UoOmQhjHXJvwBiFeJq39Gtzxq+bMm9pY2d7jWqEsDq1I75RUbUtHJLz1HKjjEL7BfjadjwSh0Wjw6EFct3hB15KBe3/jXDXpgU3T8UAL5tSAfl0FGlm0wBEANUWQceNQmKVMC94MUP+K/Et+Wb6xhvGKXGFDl+yfE93N9Bucd8= X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch02.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(356005)(8676002)(70586007)(70206006)(4326008)(15650500001)(31696002)(508600001)(7636003)(40460700003)(336012)(36860700001)(54906003)(110136005)(5660300002)(53546011)(186003)(2616005)(44832011)(316002)(26005)(2906002)(9786002)(36756003)(8936002)(31686004)(83380400001)(82310400005)(47076005)(426003)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jun 2022 23:08:25.7949 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: de6fff78-c967-4eff-b22b-08da44eccc87 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT0064.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR02MB7697 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/2/2022 3:24 AM, Min Hu (Connor) wrote: > Hi, all, >    any comments? > > 在 2022/3/7 9:04, Min Hu (Connor) 写道: >> From: Huisong Li >> >> This patch adds help messages for multi-process. >> --num-procs=N: set the total number of multi-process instances >> --proc-id=id:  set the id of the current process from multi-process >> instances(0 <= id < num-procs) >> >> Fixes: a550baf24af9 ("app/testpmd: support multi-process") >> Cc: stable@dpdk.org >> >> Signed-off-by: Huisong Li >> Signed-off-by: Min Hu (Connor) >> --- >> v6: >> * fix comments. >> v5: >> * delete space >> v4: >> * update description for parameters. >> v3,v2: >> * adjust the position of parameters. >> --- >>   app/test-pmd/parameters.c | 3 +++ >>   1 file changed, 3 insertions(+) >> >> diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c >> index daf6a31b2b..2834e9e180 100644 >> --- a/app/test-pmd/parameters.c >> +++ b/app/test-pmd/parameters.c >> @@ -61,6 +61,9 @@ usage(char* progname) >>              "extended statistics to show. Used with --stats-period " >>              "specified or interactive commands that show Rx/Tx >> statistics " >>              "(i.e. 'show port stats').\n"); >> +    printf("  --num-procs=N: set the total number of multi-process >> instances\n"); >> +    printf("  --proc-id=id:  set the id of the current process from >> multi-process instances\n" >> +           "(0 <= id < num-procs).\n"); >>       printf("  --nb-cores=N: set the number of forwarding cores " >>              "(1 <= N <= %d).\n", nb_lcores); >>       printf("  --nb-ports=N: set the number of forwarding ports " >> Hi Connor, output is as following [1], is "(0 <= id < num-procs)." part break into next line intentionally? This breaks the output. I assume the line is broken in source code to fit into line length, but it doesn't have to break the line in output, what do you think? [1] ... --num-procs=N: set the total number of multi-process instances --proc-id=id: set the id of the current process from multi-process .. (0 <= id < num-procs). --nb-cores=N: set the number of forwarding cores (1 <= N <= 55). ...