From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E06C643C93; Tue, 12 Mar 2024 17:47:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AB2E740ED9; Tue, 12 Mar 2024 17:47:25 +0100 (CET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2087.outbound.protection.outlook.com [40.107.92.87]) by mails.dpdk.org (Postfix) with ESMTP id CA42F402D8; Tue, 12 Mar 2024 17:47:23 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h4UhSeD1RepBAUGICfb4Ag9v77G80yOGuGjsu0SuwjVSpWkk+9zmd923yMj0Vm732Kkz5eu+Eh1yju3TQ9sZs8JDgmee8iOCxczRUKPFfJstL1u4D7Rl5lVRtN0QHupFylS47yYXcyWCiQFzW7ITMx2CcrWzupQUQCHyIqmB6f0z2ewz2ZTLW7Ny4IZXbYO4WRO7nOozci8gSyb9biDSyvYaw7zIn4AtGhycvg9LaS/Vo6O+C8p+gApD/dFZleCarx3kHLi4759UcmUgZq03TwDSQ+nmzdLyyb8mlUVb802hdStSzOoExi/U1HPOzmHwTmy+Hlc742b6cOZOcxMojg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GJ1Btj3kiIRBb4+Yzqxae/GFLg4lzngUK1P6lvGWAiw=; b=QNLbBkxrCo6R2BjxXLxLs2hVDRI4BLfV/UYIgnEKAk6Q7eNBu7TLvoWlLWnS6zwiQxmA4c3vX8aA6HZ/TwqpyOT/pubXpK59HN82p5KyOEAKBnSuwRyfbPPJJvr0y5K288v4wWMjI9CyEf6AgEpDEC9lCZct39H/wz/juJEY1OuLbRtIFKG6f8qyuMX/JPJuAJ0M/ddlSHZ/GkD/tyQ7Ehk4j8KFxWK+nnm02HnqotHnrkLCx22F9X0k53kCzNX0ShokOdpBx6iBmPCyucVVgrttUhxE+SXt+79R18G21DmUzIsHWVQFLFGSzLqRz+ldcJZRwqXzeC4nUFdlxnfirw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GJ1Btj3kiIRBb4+Yzqxae/GFLg4lzngUK1P6lvGWAiw=; b=fLUR1vCz6+Xx+ME09Pxk22m6T7wq+ef0s1wgYB3veyQ0D0dv2tH+S7wjq5osa8/ubZdWvecwJ3WMNRsJ9sA+LA0SmLeV/ygx6bKTLLFU2eFb1w5HEioArVeIoYHIiEc22QrMTNugiwc0ccsbaOnX8bJQTn6CifEDQrR6DpjZH/k= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DS0PR12MB8526.namprd12.prod.outlook.com (2603:10b6:8:163::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.35; Tue, 12 Mar 2024 16:47:20 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529%5]) with mapi id 15.20.7362.035; Tue, 12 Mar 2024 16:47:20 +0000 Message-ID: <92e9792e-9054-4c8e-a409-739176707175@amd.com> Date: Tue, 12 Mar 2024 16:47:16 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] app/testpmd: fix burst option parsing Content-Language: en-US To: David Marchand , dev@dpdk.org Cc: stable@dpdk.org, Aman Singh , Yuying Zhang , Ivan Ilchenko , Andrew Rybchenko , Bernard Iremonger References: <20240308144841.3615262-1-david.marchand@redhat.com> <20240308144841.3615262-3-david.marchand@redhat.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240308144841.3615262-3-david.marchand@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU2PR04CA0200.eurprd04.prod.outlook.com (2603:10a6:10:28d::25) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DS0PR12MB8526:EE_ X-MS-Office365-Filtering-Correlation-Id: 15f75052-a731-4395-f5ed-08dc42b41573 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: un6QZ3P5K60aYWRJeKEz0Ua1kin0U7vZ4DiHhw9TbfXhE0WhBmQb8ZSdwmQoCb4SU6GaIP56cQJQKw2gT7M0DFa+TuwKlzHoGNZTJzcNzp64/XJSXLsZ+A2EzRpR15akiz0ETjBq3PZfk1tu6bmQTafnboOU+Yjjsxpfhhtx5Gu7sZHQkRAsCo6mPm8cle94heHBhG5spkzX5ShvX9/YARVNcIyeEmurytVsW9uQdSY++66VaczxfvmRR/cHIjY5vSM13c0I71ysLfTy9uIUX/A7lYI3BkeFXIkRRI5ELkDFBBHty/LPMSTl5CFiEOCu9WHZL2HgycXd77er93PL7TqS481xgUyvqiAwjjXcXerVGGteU7r4TIj8kMQxFPnvXH19bhH/aE1gFA9sfNLOpT0gPctnTPhpSt6x0sxe4JnuOVCR1ZoUsObd9RS/kb4zVr4ToIFtPdiUM0xfc3zpcpATTR4VV5OiNSQhko3JB4WVblxzUMMJHCuXuafN/fs4Ke5K/Bk9t3TcbmyjDPvqbx0bXRGKeutzvUeFJnywut46cRahVyrRpoon+aNrbQQZkmQ8fdz8eD6v2943eMCTXXR89D62lG94TnKtRWRotKsgqDka1DkyDDTpT2mhu2UzxOSGJ04cwBkYW+TkAT/iG/yrJeJWgXmvixEedmyGLNI= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(1800799015); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MnRtZzdZcDFVS3MzUmppRTRHQWM2ZDd5eDBHWEdkcWsvRUJ4Wjdpcnd6N3VJ?= =?utf-8?B?YnV4TFBsRTlCenlWVWVNYnA5M3ZuWkZrTi9QNUg1RjJaUjdBazFjTzN6K3hz?= =?utf-8?B?L2k2aDlPY0NqYWsrenVFK29QWVN1YnFuVDU4QnprVGFQT1dDSFRTY3R6alQ0?= =?utf-8?B?LzA1TVhoakpHRklrVXF4OFlxSG10L1gydnVWRGJpVUhXQkJWV09ETkswdERt?= =?utf-8?B?Q0NGTEtvbXFYa0NiVEk4Z0NsOC9SK3NEb0N3dDJTNUpkMWhHaGVRNHN1YW8w?= =?utf-8?B?WlJKblQ3cU9mc1QrSVMzTXMvQUlKTzJ1cmFoaXdocjhJUm1IOFpjTkFaRFgz?= =?utf-8?B?a01NT1hyRllkQis0dWdBWmdUQWtta2JWRHhDUXBGRGZFZDZUV2lEU0c0TDVO?= =?utf-8?B?SnJqL3ZCaHcvRjk4RXg0ZEk3RytTdnh1b3BTTjY3MmVSM2JNVlB2TU9WemtG?= =?utf-8?B?d0p5RGlZSmhoRytOUjkwV2xGVDVPTndzZDE3LzdWQWhZM2dseUJ5bzl1bCta?= =?utf-8?B?SVJTM2srVmIzdzl4QnZQV1pBWmZUeFZWdjNkYStIZTNFVTFOaWZXdlpjSjBh?= =?utf-8?B?YlYvbjRkZUJacWZ4QWU3N1hCU3dKcjlQQ2pPSUc2bm15OUF4K2s1ekZBRWcw?= =?utf-8?B?WG1RbWZxbFZrM2dONTdGV1F6YUFIT3M4SFl6amNWOTJkVXlTZEN2UjR1VlR3?= =?utf-8?B?dEY1Rk9rN3g0dCttMGVyL2xWL1JxUWdYU3NtMVJUNjFxSmNkVFVVd0dBbXNT?= =?utf-8?B?KzRydkRBQU5yMUlCRGhYVUZNcTN1TlVKRWEzV1AzNG9oV3J1djdyakZidk5k?= =?utf-8?B?K0dmNUZmSVVIcm1lOGR0RlpmVTN3QXFDcHo5UC96YlRqM21aNHliOHowUzg5?= =?utf-8?B?cFZodnFnQXkxVVdwM1ZpczhRNUZrUy9DVEtIR2ZDYUFpUU5NOEpNeUdIckJw?= =?utf-8?B?U3k3V0I1dXV2cjJrZ1Zpa1NLaHdjdk1XM0RIdDJxTXlRUnY2QWpUaUNFWndC?= =?utf-8?B?eElkVlk2Tm1Lc1RiRVpnb1kyZG1PcFZhYmZjV1dJSEJjeE1aUVplT25SQ2ts?= =?utf-8?B?YWpLRlBYNXdrdW9xandoM3BuSms3VE1lZUJvM291TUQ1eGc1SFNlc2Zncmo1?= =?utf-8?B?QkxBUVB6d0JVUHlhYXcyWndDWGFvUThZZ0tDbjNNd1NMVDM4dkFIckJHaS84?= =?utf-8?B?c0VQeFZNRnpaV0lSMkZYQkhkeFBWY09XU3NDYjJPWHdUQzdNdWRPWit4eks1?= =?utf-8?B?ZUN5cVRlaDl0NUFXa3FqTXJ4cDIxeDN5cmM1akxybFVJNmVBb3hXQ2Ivdmhl?= =?utf-8?B?bm5VL3BUazQ4TW5DVDdCVXFTL09xY3IyY2tMWVNodUg0YWVZTnloSHZUM080?= =?utf-8?B?Yjh3NDFaSnZYMGh6WHA5ZmY3UXFWUGVLbUlxSUNpa2pvSjZ0M3hya0syVWFo?= =?utf-8?B?a21NSldNTk9WbUs0bDFjZDRoOVk5SFBkRUVTNXdzV1JTcldiS1BaV1pWVHRq?= =?utf-8?B?Skhadjkyd0hDSFQxenRad1p0S0pwMkRoNTl2TXFOMHIyUEVUWUx2RUErZkZs?= =?utf-8?B?UjJuR3Z2SjUySlRFZC9ZVTdvM3FQV1VwVXQ5TUtTQWhCK2E5djljT2xYbnFl?= =?utf-8?B?RHV3RE5idWdaYVgrSFgzMTJUWHh0TjI2Si8vQzhNYTlCdkJXRmZjdWU5d1pu?= =?utf-8?B?QWpTY1RJdmJrTDdiQUw4QWpiNGlTRE9iOHNnN2x4azVOMURuUVhZVU4zMGhZ?= =?utf-8?B?Y1E2Zm5ndGFIU1F4Q0pLUEFTdUsrbVd4QktUQ3BNMHZoMnBNdnJNQzJ2aTF3?= =?utf-8?B?VVlWVTB4NXJNVExMQzNUQWxDZGYxOVVibkI1bkxKbVRYVzVMeklpWlRjM3Jv?= =?utf-8?B?YzNFTFNGTHJ3dlhiMElhaXdodlNKRDJFTlZOYkVaQkhlZEZZcFc4RDRhK0ZF?= =?utf-8?B?aGJVOTNlY1JMbTNsVEFnR1BDM1U2TTd3VlJMVWFDSDNFUUh3b1Zuc3kycG5l?= =?utf-8?B?MjFuZ21SbnJHSXNQd2VzZmY0bWdiUmFxOXRrTFZ4WE55QXFMTmFidld0Qitk?= =?utf-8?B?aHdxTFkzc1FrYjFXL1d0Vk9OQTZHaDlHVVNQTFJsZkozbFdZOEVpU2dVVFNq?= =?utf-8?Q?3pT/Es8iEy5ng17s0Mp+qhncX?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 15f75052-a731-4395-f5ed-08dc42b41573 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2024 16:47:20.3120 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YA7gJS5AtbPZ/1+kG4x6ivMpmBmQxk8h+5GEzlGpUuMQVsc3VVCru4JwvT1i4cBg X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8526 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/8/2024 2:48 PM, David Marchand wrote: > rte_eth_dev_info_get() is not supposed to fail for a valid port_id, but > for the theoretical case when it would fail, raise an error rather than > skip subsequent options. > > Fixes: 6f51deb903b2 ("app/testpmd: check status of getting ethdev info") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand > --- > app/test-pmd/parameters.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c > index d715750bb8..8c21744009 100644 > --- a/app/test-pmd/parameters.c > +++ b/app/test-pmd/parameters.c > @@ -1128,9 +1128,9 @@ launch_args_parse(int argc, char** argv) > 0, > &dev_info); > if (ret != 0) > - return; > - > - rec_nb_pkts = dev_info > + rec_nb_pkts = 0; > + else > + rec_nb_pkts = dev_info > .default_rxportconf.burst_size; > > if (rec_nb_pkts == 0) 'eth_dev_info_get_print_err()' already fail, but it may not be very clear to the user, OK to print a failure log, but setting 'rec_nb_pkts = 0;' as above also will generate an error message that also may be confusing to the user. What about print an explicit error message for the 'eth_dev_info_get_print_err()' failed case?