From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E28CDA0C43; Thu, 26 Aug 2021 12:14:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7AAE840140; Thu, 26 Aug 2021 12:14:42 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 338204013F; Thu, 26 Aug 2021 12:14:41 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10087"; a="281432466" X-IronPort-AV: E=Sophos;i="5.84,353,1620716400"; d="scan'208";a="281432466" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Aug 2021 03:14:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,353,1620716400"; d="scan'208";a="686919141" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga005.fm.intel.com with ESMTP; 26 Aug 2021 03:14:39 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Thu, 26 Aug 2021 03:14:39 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Thu, 26 Aug 2021 03:14:38 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Thu, 26 Aug 2021 03:14:38 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.170) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Thu, 26 Aug 2021 03:14:38 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nFXTHPW2635fhvmbMlSk5Nx2CW8e7jyaj+VbE/MR7Rd2uV+pNLSZUFVzCYLBXyRChILuWar1AWkFej3ST5wZqaKvQDV7QdZPKaW8fXstThKc1Q2cSyXpM8CwujmBUU0oFl7dLD/FHxHwAVyxkK7YJIKiy219fkNGyXxnC+12hsG7OyJDne9GDVDowDyAaDWscuSwl2OrXCIvuJqhfl9HzzozO+cJYR3bdVbRI/PC8nQlVHLzgRx5eHaGcZ/seeX5MP7rNJlTO5Wr1wVu/1IX6rkEh/g+MecpmRsZdfsUGdGVHFkrwnekqqq4AYTzCQ+ftSTV7JDXYHVs6yuNGydgRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+ySubJF1bglZaYVJd+XB/UBlaYYz53jdoWuZgirTmno=; b=X9wIjosY8xzoGU5mjh5uh7PsEPHKU4tjJFn5CNpBRz2O/WsQUyCyY3eQhsb5bc5zKuTqKwbwF/LVQ3FzbcwS//ExbU7miMCx7+MxkpHOa/yunwduObQNIE6gHVX8IKGZO2vbZPapQfPBjVpyFwxrPG4Y++KhyeyjfNZh5dV37/9K7e3+bwj5nNh+/19W61wifPILdhgEpPLdASgT4RnT/OlwMVDyRHZQS4+ZdDUPlYzK4ub16VGa+tpYFis7ZHvvSzm4AlZgM8JDb1lLIa+5t9y01ynbRo3IdaBZ18/EsyJHAuO1UsJxcOBclDpQEP4eAmVPZfkLKD/2qRYcZ12QsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+ySubJF1bglZaYVJd+XB/UBlaYYz53jdoWuZgirTmno=; b=jE4opzPq+y8WWejtGgeSMg4AV9i2SjsscdKKrA5+m6Pb9bzDBz02NNIyoAVyW21GgZ/TagapsipcxuzMSkO29usiltOgLH1hgACfFXzblciLoSR7l3MyIhhUFmyzmKGYvRobJYBtYH6fR+pP5dpVZKNrBGQLmvFmmZ6PMzhY7Os= Authentication-Results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5093.namprd11.prod.outlook.com (2603:10b6:510:3e::23) by PH0PR11MB5207.namprd11.prod.outlook.com (2603:10b6:510:32::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.19; Thu, 26 Aug 2021 10:14:36 +0000 Received: from PH0PR11MB5093.namprd11.prod.outlook.com ([fe80::d145:710a:1bac:7e91]) by PH0PR11MB5093.namprd11.prod.outlook.com ([fe80::d145:710a:1bac:7e91%7]) with mapi id 15.20.4457.020; Thu, 26 Aug 2021 10:14:36 +0000 To: Bruce Richardson CC: Ferruh Yigit , Xuan Ding , , , , , "techboard@dpdk.org" , "David Marchand" References: <20210825112700.83810-1-xuan.ding@intel.com> <8aef3f20-8edf-7e6a-5e59-f325a2d3383a@intel.com> <886efb65-32aa-adb9-63de-9ca41d87ac4b@intel.com> From: "Burakov, Anatoly" Message-ID: <92ee7059-ef00-41f3-7fb4-f3708d18b5f2@intel.com> Date: Thu, 26 Aug 2021 11:14:30 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.13.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB6PR0402CA0005.eurprd04.prod.outlook.com (2603:10a6:4:91::15) To PH0PR11MB5093.namprd11.prod.outlook.com (2603:10b6:510:3e::23) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.1.12] (212.17.34.161) by DB6PR0402CA0005.eurprd04.prod.outlook.com (2603:10a6:4:91::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.20 via Frontend Transport; Thu, 26 Aug 2021 10:14:34 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0063e812-5adc-4408-58ec-08d9687a4e47 X-MS-TrafficTypeDiagnostic: PH0PR11MB5207: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VebP730/R1XItKUV09EUPcWZCe7aYDwRSF3hyD65q5LOqRUqntq55UwL2F3iHpkT2e6QRKnq2lzgZ4zHJ9m++7dvwqPxjA4FxU/1UEk50tLSuwp20v06qNR0Asq5Jq5fxuy6fjShgAjLG+wmIE9jrM4CFMK9aHbeUh6wZrsoTvbhfCpWlnywvHiY4oMdk0kUscT/PaUC+VGWOW/CT/JW42w6vbq7Zwla3KN6iV849oFWrCz1JFi56WqKmfYatIUsANquXQB5hisxiEe2Z/nng698VnVW6PHeTu6A1BgRFFIMjpyoa+DIMbiAO/mNFOqU+QtWBnvJCktr1wRMM69tuWhHjTf8HtuOpFo047f0kHqh0soQGWcQgLCr6MzWdgzL32l9VgZ4bD6nzcnko9khlr8mDk06RVUW2n5X/hNVppxxgSKmOQFSGv3aa8fgtawJ/EugozNOEySLn0R+60g97EliwSM13PyBc1tShvHFfbI5ts9eb3LP0NPzi0ar9kf2FUhQLx0xnOAyyIzt6rIDU8xat7mX+PwKOyKtooxi071K8ZOvAROxmlnofUwKyfzTmy1JQR69DWrynGUa/O0uGKEngL4Y5tOyBV5VQIxgXePuiJZ3PworrE5rWbRyvoHrMI0dvjgD+z0yGrkBSWHauFjeV6K+l3eDICXmgMsg+plFfIt+Q6mkjVSUr+hQiNKRphC0TMAh++Nydjr4cW6SlrHdfU6vDDrvSC1egPCPt29zSvLY80d0I5rHQXb5pudhCjef6MjMEBh5//4j9GPoT+MB/6vJxqK6D7p92TFOAWGDMTCQvqtfaV7brKuGprA3sVRMY+oN2Mu673Lbz93Y1A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5093.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(396003)(346002)(39860400002)(366004)(376002)(478600001)(66476007)(316002)(8936002)(966005)(5660300002)(66556008)(16576012)(6666004)(31696002)(37006003)(54906003)(6636002)(86362001)(38100700002)(4326008)(66946007)(8676002)(6862004)(53546011)(2616005)(956004)(83380400001)(31686004)(2906002)(6486002)(36756003)(186003)(26005)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Qk5IQ21aKzAwUjIzS2Q0WmYxc0FicXJ2ZW0vdXhodTNVRmJNMFU3SFBCREVH?= =?utf-8?B?YzRXYmpXRXZCT05SNTJKK0xvUm9ucWVSSjNFUEVPbTh5aXJhRk82cDJzTU9W?= =?utf-8?B?a3oxS24rSURmSHhMVS9PWTZkcFY0L0poelA0OFZ1VlFmOHZER2J2NVljZTc4?= =?utf-8?B?MCtuMndNTjN1VUtMMGdWVS8vcHJTcGhGd3ZuQ0kzRUFvWDZ2WTM0Zm5vTlU3?= =?utf-8?B?WGo5WW05SHU3NEsvWklNa3g1T3M3T0xsdlRFZ3ord0RrdVdmVHcyWFhSMHkr?= =?utf-8?B?MFJXREw4VkppaU5SUXpIS3RDTHBNK3dpY2R5MjkyNTl5WTR4ZVVDWk9vVzRC?= =?utf-8?B?WkJ1d3R5U3Q3WFVUaVlid2c2VjdoekxqOTlNZmZ4UFNPZC91bWNoQjNva0Y5?= =?utf-8?B?VStyQlEzR01OQ1cxUWpYeEZsWEFTbkxkK0luSGdldFNhbUU0WXBpZm5OTU9D?= =?utf-8?B?OWNKNlhtcFduYWphMHZ1MTFNZitaN2Zzc0dYRGUvOWZMOWc2bzdBVkZXb1M0?= =?utf-8?B?V1Y3ZmZiWW8yWkpTYU1VV2szNnVNcEJnMW9RNW82R3Q3YTBRa05IUkd4V0lC?= =?utf-8?B?MSsvaFlBeVVGSmg3RGJsQ2NaMzcrcmpYYTFaaUE1ZlpYZGIvWTFuUzdEVCtG?= =?utf-8?B?dTF3SHlUbUF4c1FqeGJkV1FVUHNvT0IzVS9zc3ZiZGxTb1FKbDR3OG5zWDBx?= =?utf-8?B?T0dZaVBtRXBlZzYra1RmVGN6ZWQvdGVKMFYxUzlsemw0WEFoN3hiQ2g3Tzll?= =?utf-8?B?d0ZFUXZrTzFrc3ZYeEVoRDl6WTFUcWpkU1IxZHR6aXUzSlVJb3BjQlg5eWlx?= =?utf-8?B?NDFoRlNwbXU3SDg0MGZLMm84TTEwcDJ1d0hOc2dzTmg3TFRnOXJLZXpORUlE?= =?utf-8?B?amwvUFJ0Q0dyNXc5Qk5YamFMQzI2OUlYcUFmYXJ3a3VLczNNMmhmZlltWS94?= =?utf-8?B?bWlEVHVGakZlTzFOTU95LytIZXE5Nmwrb0I4UEFkcTY4Z3RwMmRWM3R0K2VO?= =?utf-8?B?SGpvcGx6cFFTTEphVmpuZ2hGbXVTSStLN3BQRDRmdnZMS3NxdDZOdFQ4V0NZ?= =?utf-8?B?N1FLWU9sVFUvQkU0cVluakhvMUNBVCtPMnBNWjZTa3BqNmVUTU5wWUpOcy9a?= =?utf-8?B?QmpBMXRUcjFtREs2YnJxeWxrelBaSnFyVng0bUlQZnNFS2dPdk4zTTI4SFkx?= =?utf-8?B?Mjd5d0VxV2doN2gwT0Q3aFU0dWdON2lMWm93Uk9ob0U4elFtTUhrTmswcVMw?= =?utf-8?B?a0U3VWo2Si9OZk0yeGdKWlFWcjduTC9CV2JZTkJVMjd3OWxGMFlEdzV4RlQ1?= =?utf-8?B?Nm9KYytiZG5qNnF1RGJYRE9XUWRHS0l5a0JYRXc2OXcvTW9oYTdCZEJWeCsz?= =?utf-8?B?T0hiYTRWNTJlNDkvbXVhQ3lSMkZ1WHNYcXVJK3N5Mmx2dFhZUVFpSmUyQjdh?= =?utf-8?B?bFd4WFZGMUF2Y28wZnRUSUFiWS81Wnh6V0JaeWZ3Z0dkMlFuYjR6M0wxbUtU?= =?utf-8?B?OFlYUGVpWHVBN0ZkV0djSDAyRmJRU2Y4WmNxb3djcHlkVHdIODc4K0kxL3gr?= =?utf-8?B?SjBVaGdIZGtFNmJDZVRMK2NITTR0eGVSOVdnYlNNcW1uM3dUaTcvNXNBUktF?= =?utf-8?B?dHNtN2FGMUNoWnFXUHJacE9oaXNoalVZbnd5RDgrTUNEY05qdm1SdzFxYWFk?= =?utf-8?B?R0tVaFNpbnBEaisvZCtUbU52bUNMdE9tQU4wUURSWmthTXhSemk1ZWZpbXpG?= =?utf-8?Q?iiP0PYY6IPeRFWzNdh4WiOH4iJ4lgV9fxN0PR5U?= X-MS-Exchange-CrossTenant-Network-Message-Id: 0063e812-5adc-4408-58ec-08d9687a4e47 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5093.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2021 10:14:36.1021 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IQs6FRCv74IDi7W79mOOmRWq818S0M4KOBqNZ/Z7Auc+qTMmQgqEo59TQyFsGdKdFYew9zCwM3zmM4hXn3xl0QCrvHtp36R32r8ifXls4Ro= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5207 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] doc: announce change in dma mapping/unmapping X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 26-Aug-21 11:09 AM, Bruce Richardson wrote: > On Thu, Aug 26, 2021 at 10:46:07AM +0100, Burakov, Anatoly wrote: >> On 26-Aug-21 10:29 AM, Ferruh Yigit wrote: >>> On 8/25/2021 12:47 PM, Burakov, Anatoly wrote: >>>> On 25-Aug-21 12:27 PM, Xuan Ding wrote: >>>>> Currently, the VFIO subsystem will compact adjacent DMA regions for the >>>>> purposes of saving space in the internal list of mappings. This has a >>>>> side effect of compacting two separate mappings that just happen to be >>>>> adjacent in memory. Since VFIO implementation on IA platforms also does >>>>> not allow partial unmapping of memory mapped for DMA, the current DPDK >>>>> VFIO implementation will prevent unmapping of accidentally adjacent >>>>> maps even though it could have been unmapped [1]. >>>>> >>>>> The proper fix for this issue is to change the VFIO DMA mapping API to >>>>> also include page size, and always map memory page-by-page. >>>>> >>>>> [1] https://mails.dpdk.org/archives/dev/2021-July/213493.html >>>>> >>>>> Signed-off-by: Xuan Ding >>>>> --- >>>>>   doc/guides/rel_notes/deprecation.rst | 3 +++ >>>>>   1 file changed, 3 insertions(+) >>>>> >>>>> diff --git a/doc/guides/rel_notes/deprecation.rst >>>>> b/doc/guides/rel_notes/deprecation.rst >>>>> index 76a4abfd6b..272ffa993e 100644 >>>>> --- a/doc/guides/rel_notes/deprecation.rst >>>>> +++ b/doc/guides/rel_notes/deprecation.rst >>>>> @@ -287,3 +287,6 @@ Deprecation Notices >>>>>     reserved bytes to 2 (from 3), and use 1 byte to indicate warnings and other >>>>>     information from the crypto/security operation. This field will be used to >>>>>     communicate events such as soft expiry with IPsec in lookaside mode. >>>>> + >>>>> +  * vfio: the functions `rte_vfio_container_dma_map` and >>>>> `rte_vfio_container_dma_unmap` >>>>> +  will be amended to include page size. This change is targeted for DPDK 21.11. >>>>> >>>> >>>> Acked-by: Anatoly Burakov >>>> >>> >>> Techboard decision was to add a new API, instead of updating existing ones, to >>> not break the apps using this API. >>> >>> @Xuan, @Anatoly, can you please confirm if this will solve your problem? >>> >> >> I don't think adding a new API is a particularly good solution. The "new" >> API will be almost exactly as the old one, but adding one parameter. I don't >> expect code duplication to be an issue, but having two API's that do the >> same thing seems like it's rife for potential confusion. >> > Well, if one API is marked as deprecated, then there will be no confusion > for users, since using the wrong one will give a warning pointing to the > right one. > >> If we add a new API, we can then either remove the old API entirely in >> 22.11 (effectively renaming it), or we remove the new API in 22.11 and >> rename it back to the old function name. I don't think neither of these >> is a good solution, as we risk introducing more users for the API that >> will later change. > The new API will not be renamed to the old one, since that would break apps > using it without proper deprecation process. Removing the old one alone > would be the approach to be used, but it would be correctly following the > deprecation process and giving users at least 1 year, if no 2, of notice > about the change. > >> >> I think the pain of updating current software for 21.11 (while keeping >> compatibility with 20.11 ABI!) is going to happen regardless, and whether we >> decide to add a "temporary" new API or permanently rename the old one. It's >> (in my opinion) easier to just bite the bullet and update the function in >> 21.11. > I fail to see the issue with adding a new function. Whether we add a new > function or add a parameter to the existing one, code will have to change > either way. The advantage of the former scheme, adding the new function, is > that it shows that we are serious about our ABI/API compatibility process, > and are not lax about passing exceptions when other options are available. > >> >> However, if the tech board feels like adding a new API is a good solution, >> then okay, but we need to flesh out roadmap a bit better. Do we rename the >> old API, or do we add a temporary new API? > > New API added, old API deprecated. In future old API goes away leaving new > API as the only option. > > /Bruce > Okay, so it's settled then. I revoke my ack for this patch, and we need a new deprecation notice. -- Thanks, Anatoly