From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CCE1F43BE9; Tue, 27 Feb 2024 10:48:36 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9FB254027D; Tue, 27 Feb 2024 10:48:36 +0100 (CET) Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by mails.dpdk.org (Postfix) with ESMTP id 7165A40150 for ; Tue, 27 Feb 2024 10:48:35 +0100 (CET) Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4TkXcr5Mw3z67XH2; Tue, 27 Feb 2024 17:44:12 +0800 (CST) Received: from frapeml100006.china.huawei.com (unknown [7.182.85.201]) by mail.maildlp.com (Postfix) with ESMTPS id 17C74140D26; Tue, 27 Feb 2024 17:48:34 +0800 (CST) Received: from frapeml500007.china.huawei.com (7.182.85.172) by frapeml100006.china.huawei.com (7.182.85.201) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 27 Feb 2024 10:48:33 +0100 Received: from frapeml500007.china.huawei.com ([7.182.85.172]) by frapeml500007.china.huawei.com ([7.182.85.172]) with mapi id 15.01.2507.035; Tue, 27 Feb 2024 10:48:33 +0100 From: Konstantin Ananyev To: Tyler Retzlaff , "dev@dpdk.org" CC: Anatoly Burakov , Ashish Gupta , Chenbo Xia , "Cristian Dumitrescu" , David Hunt , Fan Zhang , Hemant Agrawal , Honnappa Nagarahalli , Jasvinder Singh , Jerin Jacob , Konstantin Ananyev , Maxime Coquelin , Reshma Pattan , "Sachin Saxena" , Sivaprasad Tummala , Srikanth Yalavarthi , Stephen Hemminger , Sunil Kumar Kori , "bruce.richardson@intel.com" , "mb@smartsharesystems.com" , "thomas@monjalon.net" Subject: RE: [PATCH v3 02/16] bpf: stop using variadic argument pack extension Thread-Topic: [PATCH v3 02/16] bpf: stop using variadic argument pack extension Thread-Index: AQHaaPFGQFPTqQdkjEqoX9hqg66qZbEd8k1w Date: Tue, 27 Feb 2024 09:48:33 +0000 Message-ID: <9316d3c7b3c54e8e89821eaa7baa71c9@huawei.com> References: <1707774557-16012-1-git-send-email-roretzla@linux.microsoft.com> <1708978786-6740-1-git-send-email-roretzla@linux.microsoft.com> <1708978786-6740-3-git-send-email-roretzla@linux.microsoft.com> In-Reply-To: <1708978786-6740-3-git-send-email-roretzla@linux.microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.206.138.42] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > Subject: [PATCH v3 02/16] bpf: stop using variadic argument pack extensio= n >=20 > Use RTE_LOG_LINE_PREFIX instead of RTE_LOG_LINE in macro expansions > which allow a prefix and arguments to be inserted into the log line > without the need to use the ## args variadic argument pack extension. >=20 > Signed-off-by: Tyler Retzlaff > --- > lib/bpf/bpf_impl.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/lib/bpf/bpf_impl.h b/lib/bpf/bpf_impl.h > index 1a3d97d..680b1e5 100644 > --- a/lib/bpf/bpf_impl.h > +++ b/lib/bpf/bpf_impl.h > @@ -29,8 +29,8 @@ struct rte_bpf { > extern int rte_bpf_logtype; > #define RTE_LOGTYPE_BPF rte_bpf_logtype >=20 > -#define RTE_BPF_LOG_LINE(lvl, fmt, args...) \ > - RTE_LOG_LINE(lvl, BPF, fmt, ##args) > +#define RTE_BPF_LOG_LINE(level, ...) \ > + RTE_LOG_LINE_PREFIX(level, BPF, "%s(): ", __func__, __VA_ARGS__) >=20 > static inline size_t > bpf_size(uint32_t bpf_op_sz) > -- Acked-by: Konstantin Ananyev =20 > 1.8.3.1