From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 7C8971B281 for ; Wed, 1 Nov 2017 07:32:47 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Oct 2017 23:32:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,327,1505804400"; d="scan'208";a="916119145" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.254.27.219]) ([10.254.27.219]) by FMSMGA003.fm.intel.com with ESMTP; 31 Oct 2017 23:32:45 -0700 To: "Tan, Jianfeng" , Thomas Monjalon , "Richardson, Bruce" , "Gonzalez Monroy, Sergio" Cc: "dev@dpdk.org" , Santosh Shukla References: <20171101010726.17781-1-ferruh.yigit@intel.com> From: Ferruh Yigit Message-ID: <9339bd0d-b9be-21ef-5aa8-1f5b8b5af11f@intel.com> Date: Tue, 31 Oct 2017 23:32:45 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] eal: disable IOVA mode detection by default X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Nov 2017 06:32:47 -0000 On 10/31/2017 7:17 PM, Tan, Jianfeng wrote: > > >> -----Original Message----- >> From: Yigit, Ferruh >> Sent: Wednesday, November 1, 2017 9:07 AM >> To: Thomas Monjalon; Richardson, Bruce; Gonzalez Monroy, Sergio >> Cc: dev@dpdk.org; Yigit, Ferruh; Tan, Jianfeng; Santosh Shukla >> Subject: [PATCH] eal: disable IOVA mode detection by default >> >> Fix kernel crash with KNI because KNI requires physical addresses. >> >> A config option introduced to disable IOVA mode detection and to set it >> to physical address by default. Disabling config option will enable IOVA >> mode detection. >> >> When there is no intension to use KNI, it is safe to enable detection. >> >> Config option disable IOVA mode detection by default to be sure only who >> is aware of result enable it. >> >> Fixes: 72d013644bd6 ("mem: honor IOVA mode in malloc virt2phy") >> >> Signed-off-by: Ferruh Yigit >> --- >> Cc: Jianfeng Tan >> Cc: Santosh Shukla >> Cc: Thomas Monjalon > > Refer to how vhost-kernel works, we may leverage a memory region table to do the translation. The bad side is it's less efficient than current phys_to_virt. Hi Jianfeng, Can you please elaborate? Thanks, ferruh > Another side, we did not check the result of phys_to_virt, that's why kernel crashes. > > Thanks, > Jianfeng >