From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 71A6BA09DF; Fri, 13 Nov 2020 12:51:46 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AB9804CA6; Fri, 13 Nov 2020 12:51:44 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id B50024C96 for ; Fri, 13 Nov 2020 12:51:42 +0100 (CET) IronPort-SDR: c9ZuM1GrSw8sDZjT9NAOoC4CQgr/uWHKZ0RmQ5AEqBa/ZQA9Ukt3QRMShX1B3A3giWG4THHuQ8 WIVZtSt9G95g== X-IronPort-AV: E=McAfee;i="6000,8403,9803"; a="150311048" X-IronPort-AV: E=Sophos;i="5.77,475,1596524400"; d="scan'208";a="150311048" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Nov 2020 03:51:40 -0800 IronPort-SDR: jJuE+/Yl0JxRNGNLXnzaXaZGb0fYs9peTadgP8ZKKAmDYDzaX2TUpn0vMCFx/TpUkrJnHFOcnT KDza857p/Jwg== X-IronPort-AV: E=Sophos;i="5.77,475,1596524400"; d="scan'208";a="474636093" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.3.208]) ([10.252.3.208]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Nov 2020 03:51:38 -0800 To: Murphy Yang , dev@dpdk.org Cc: qiming.yang@intel.com, qi.z.zhang@intel.com, stevex.yang@intel.com, leyi.rong@intel.com, wenzhuo.lu@intel.com References: <20201104092652.34744-1-murphyx.yang@intel.com> <20201109060647.63093-1-murphyx.yang@intel.com> From: Ferruh Yigit Message-ID: <9350dc7a-776a-bc99-7e06-ad68ede0c45e@intel.com> Date: Fri, 13 Nov 2020 11:51:34 +0000 MIME-Version: 1.0 In-Reply-To: <20201109060647.63093-1-murphyx.yang@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v6] net/ice: fix outer checksum on cvl unknown X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/9/2020 6:06 AM, Murphy Yang wrote: > Currently, driver does not support parse UDP outer checksum flag of > tunneled packets. > > When execute 'csum set outer-udp hw 0' and 'csum parse-tunnel on 0' > commands to enable hardware UDP outer checksum. This patch supports > parse UDP outer checksum flag of tunneled packets. > > Fixes: dbf3c0e77a22 ("net/ice: handle Rx flex descriptor") > Fixes: 4ab7dbb0a0f6 ("net/ice: switch to Rx flexible descriptor in AVX path") > Fixes: ece1f8a8f1c8 ("net/ice: switch to flexible descriptor in SSE path") > > Signed-off-by: Murphy Yang <...> > @@ -217,10 +253,10 @@ ice_rx_desc_to_olflags_v(struct ice_rx_queue *rxq, __m128i descs[4], > * appropriate flags means that we have to do a shift and blend for > * each mbuf before we do the write. > */ > - rearm0 = _mm_blend_epi16(mbuf_init, _mm_slli_si128(flags, 8), 0x10); > - rearm1 = _mm_blend_epi16(mbuf_init, _mm_slli_si128(flags, 4), 0x10); > - rearm2 = _mm_blend_epi16(mbuf_init, flags, 0x10); > - rearm3 = _mm_blend_epi16(mbuf_init, _mm_srli_si128(flags, 4), 0x10); > + rearm0 = _mm_blend_epi32(mbuf_init, _mm_slli_si128(flags, 8), 0x04); > + rearm1 = _mm_blend_epi32(mbuf_init, _mm_slli_si128(flags, 4), 0x04); > + rearm2 = _mm_blend_epi32(mbuf_init, flags, 0x04); > + rearm3 = _mm_blend_epi32(mbuf_init, _mm_srli_si128(flags, 4), 0x04); Hi Murphy, This change is in the 'ice_rxtx_vec_sse.c' file, but is the '_mm_blend_epi32' intrinsic, an SSE intrinsic? Since it is causing a compile error with default target, you can test with './devtools/test-meson-builds.sh' script.