From: "Min Hu (Connor)" <humin29@huawei.com>
To: "Li, Xiaoyun" <xiaoyun.li@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Yigit, Ferruh" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix Tx/Rx descriptor query error log
Date: Mon, 29 Mar 2021 14:47:51 +0800 [thread overview]
Message-ID: <93514100-a32f-121c-635d-76a9b35ce0e3@huawei.com> (raw)
In-Reply-To: <DM4PR11MB5534E65211014582F354A27A997E9@DM4PR11MB5534.namprd11.prod.outlook.com>
Hi, xiaoyun,
All has been done in v2, please review it, thanks.
在 2021/3/29 13:49, Li, Xiaoyun 写道:
> Hi
>
>> -----Original Message-----
>> From: Min Hu (Connor) <humin29@huawei.com>
>> Sent: Saturday, March 27, 2021 15:35
>> To: dev@dpdk.org
>> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Li, Xiaoyun <xiaoyun.li@intel.com>
>> Subject: [PATCH] app/testpmd: fix Tx/Rx descriptor query error log
>>
>> From: Hongbo Zheng <zhenghongbo3@huawei.com>
>>
>> Currently in testpmd, if we input "show port 0 rxq 0 desc 9999 status"
>> and if rte_eth_rx_descriptor_status return a negative value, testpmd will print
> returns
>> "Invalid queueid = 0", seems user input an invalid queueid, while the actual
> Users input/ user inputs
>> situation may be that 9999 is out of bounds, current information is misleading to
>> users.
>>
>> This patch modify the Tx/Rx descriptor query error information in testpmd by
> modifies
>> add offset information, now if we fail to query Tx/Rx descriptor, testpmd will
> adding
>> print "Invalid queueid = 0, offset = 9999", then we can check our input.
>
> The commit log has grammar mistakes. And I think you can simply explain what the patch does like:
> This patch adds more err info for Tx/Rx descriptor query command.
>
> And the print should be "Invalid input: queue id = 0, desc id = 9999" because you still don't tell users if it's queue id err or desc id err.
>
> BRs
> Xiaoyun
>>
>> Fixes: fae9aa717d6c ("app/testpmd: support checking descriptor status")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Hongbo Zheng <zhenghongbo3@huawei.com>
>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
>> ---
>> app/test-pmd/cmdline.c | 6 ++++--
>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
>> 287d7a0..1a74a61 100644
>> --- a/app/test-pmd/cmdline.c
>> +++ b/app/test-pmd/cmdline.c
>> @@ -16633,7 +16633,8 @@ cmd_show_rx_tx_desc_status_parsed(void
>> *parsed_result,
>> rc = rte_eth_rx_descriptor_status(res->cmd_pid, res->cmd_qid,
>> res->cmd_did);
>> if (rc < 0) {
>> - printf("Invalid queueid = %d\n", res->cmd_qid);
>> + printf("Invalid queueid = %d, offset = %d\n",
>> + res->cmd_qid, res->cmd_did);
>> return;
>> }
>> if (rc == RTE_ETH_RX_DESC_AVAIL)
>> @@ -16646,7 +16647,8 @@ cmd_show_rx_tx_desc_status_parsed(void
>> *parsed_result,
>> rc = rte_eth_tx_descriptor_status(res->cmd_pid, res->cmd_qid,
>> res->cmd_did);
>> if (rc < 0) {
>> - printf("Invalid queueid = %d\n", res->cmd_qid);
>> + printf("Invalid queueid = %d, offset = %d\n",
>> + res->cmd_qid, res->cmd_did);
>> return;
>> }
>> if (rc == RTE_ETH_TX_DESC_FULL)
>> --
>> 2.7.4
>
> .
>
next prev parent reply other threads:[~2021-03-29 6:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-27 7:34 Min Hu (Connor)
2021-03-29 5:49 ` Li, Xiaoyun
2021-03-29 6:47 ` Min Hu (Connor) [this message]
2021-03-29 6:46 ` [dpdk-dev] [PATCH v2] " Min Hu (Connor)
2021-03-29 7:07 ` Li, Xiaoyun
2021-03-30 14:35 ` Ferruh Yigit
2021-03-30 14:29 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93514100-a32f-121c-635d-76a9b35ce0e3@huawei.com \
--to=humin29@huawei.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=xiaoyun.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).