From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 03DF1A04BC; Thu, 8 Oct 2020 23:17:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DFFA91BAE5; Thu, 8 Oct 2020 23:17:18 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 41CAC1BAE4 for ; Thu, 8 Oct 2020 23:17:17 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20201008211705euoutp01c38c8ea786a676dabb37b4566edf4dfc~8IPoPUCni1724217242euoutp012 for ; Thu, 8 Oct 2020 21:17:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20201008211705euoutp01c38c8ea786a676dabb37b4566edf4dfc~8IPoPUCni1724217242euoutp012 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1602191825; bh=vros+badXCYjxp4VWT/Wh1HgZG2l5fLgAmMnOrI8BKo=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=CGIs3KYm4m3TPQJtWwqmFB6G/8J1OH6npzekyYPhOt1zzkN0FRP5InGZxMcRodd6E wR/nQ/76YtFGp5QMv1R7q7xz8TSBKgAZWiYkgQBDCADtA09TgL7QlZfoLnzN8LD8SM IQnYkXmeadKvuXEABncHjNxIqZuBa0X1tobgDwmA= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20201008211658eucas1p10e535e9f0e62cd2cd2f1b5f3d0109905~8IPhh9d8C1017910179eucas1p1R; Thu, 8 Oct 2020 21:16:58 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 51.19.06456.AC18F7F5; Thu, 8 Oct 2020 22:16:58 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20201008211658eucas1p2c05f01cd94d9c4fcd4ee259019b1745c~8IPhCIpSd0069200692eucas1p2y; Thu, 8 Oct 2020 21:16:58 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20201008211658eusmtrp10a230b4f7efde1aa983165232b0d277f~8IPhBkNkJ2559325593eusmtrp1g; Thu, 8 Oct 2020 21:16:58 +0000 (GMT) X-AuditID: cbfec7f2-809ff70000001938-04-5f7f81caa1d7 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id D0.93.06314.9C18F7F5; Thu, 8 Oct 2020 22:16:58 +0100 (BST) Received: from [106.210.88.70] (unknown [106.210.88.70]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20201008211657eusmtip25f912b9cb0b406c41b80d16d12d71c80~8IPgeB6K-1512115121eusmtip29; Thu, 8 Oct 2020 21:16:57 +0000 (GMT) To: David Marchand , David Hunt , Honnappa Nagarahalli Cc: dev , Sarosh Arif , "\"'Lukasz Wojciechowski'\"," From: Lukasz Wojciechowski Message-ID: <93539a05-31de-f973-028e-175d82d0eb29@partner.samsung.com> Date: Thu, 8 Oct 2020 23:16:55 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: Content-Transfer-Encoding: 8bit Content-Language: en-US X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrPKsWRmVeSWpSXmKPExsWy7djPc7qnGuvjDSbMVbDom/SRyWL7ii42 i3eftjNZzHzawm7xrGcdo8Wpdd/ZHdg81sxbw+jxa8FSVo/TP58weyze85LJ4+C7PUwe7/dd ZQtgi+KySUnNySxLLdK3S+DKOHJwGXPBWp6K10/vszQw/uLsYuTkkBAwkdjStoKli5GLQ0hg BaPEivezmSGcL4wSM879YodwPjNKTP64jxmmZeHGHqiq5YwST/buZ4Jw3jJKNDVfYgWpEhYI lDh/uIEVJCEi0AE0+NU5NhCHWaCBUaKr+T0LSBWbgK3EkZlfwTp4Bdwk+o98BNvBIqAicf3D JrC4qECcxISNLSwQNYISJ2c+AbM5gTb07rkMVsMsIC/RvHU2M4QtLnHryXywkyQEtrFLNJ+b DXW4i8SOJ8eZIGxhiVfHt7BD2DISpyf3sEA1MEpc/f2TEcLZzyhxvXcFVJW1xOF/v4F+4ABa oSmxfpc+RNhR4sbMy4wgYQkBPokbbwUhjuCTmLRtOjNEmFeio00IolpP4mnPVEaYtX/WPmGZ wKg0C8lrs5C8MwvJO7MQ9i5gZFnFKJ5aWpybnlpsmJdarlecmFtcmpeul5yfu4kRmIxO/zv+ aQfj10tJhxgFOBiVeHgZhOrjhVgTy4orcw8xSnAwK4nwOp09HSfEm5JYWZValB9fVJqTWnyI UZqDRUmc13jRy1ghgfTEktTs1NSC1CKYLBMHp1QD47a2rVkSj5fJGXn/dc77yHDn2qbwYNOJ QU1xFcnaWbUXrp/e2nX4a2bC7wOvJkx8dfV2QysbQ7P0g+S5gc/TjhW5qzCJbuur/W1u8kwv 1enV1oNFCyoZ72xMXVIuEaNy13XVsadtOzlMS3L3iJjyiFRmRzDm6WyuqS+87LdIPNLtvL8m 881mJZbijERDLeai4kQAEcvc0kIDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrPIsWRmVeSWpSXmKPExsVy+t/xe7qnGuvjDVa0Mlr0TfrIZLF9RReb xbtP25ksZj5tYbd41rOO0eLUuu/sDmwea+atYfT4tWApq8fpn0+YPRbvecnkcfDdHiaP9/uu sgWwRenZFOWXlqQqZOQXl9gqRRtaGOkZWlroGZlY6hkam8daGZkq6dvZpKTmZJalFunbJehl HDm4jLlgLU/F66f3WRoYf3F2MXJySAiYSCzc2MPcxcjFISSwlFHi5JUmIIcDKCEj8eGSAESN sMSfa11sILaQwGtGib3XYkFsYYFAifOHG1hBekWAKiU2nZsCNohZoIFR4s+L6+wQU+cwSbyd dZMVpIVNwFbiyMyvYDavgJtE/5GPzCA2i4CKxPUPm8DiogJxEj8m9rJB1AhKnJz5hAXE5gRa 17vnMlgNs4CZxLzND5khbHmJ5q2zoWxxiVtP5jNNYBSahaR9FpKWWUhaZiFpWcDIsopRJLW0 ODc9t9hQrzgxt7g0L10vOT93EyMw8rYd+7l5B+OljcGHGAU4GJV4eFfw18cLsSaWFVfmHmKU 4GBWEuF1Ons6Tog3JbGyKrUoP76oNCe1+BCjKdBzE5mlRJPzgUkhryTe0NTQ3MLS0NzY3NjM Qkmct0PgYIyQQHpiSWp2ampBahFMHxMHp1QDo/3pnv2bOLQ+eDNH7rlsKjBBfE80/4SqxMIr bBZ+EarrRXWkHt8RfvFt2trLV22MymK1utwvBri8k/pb+vDT6xVrej0nvDka993Zu/Th802p 3IEHxPW7zt42My4Q8JzkGJTBuv3BpYuv5HgeLHZ7FugvxNrHufGdS5vAHgnpedkPF3Vdrfwo qcRSnJFoqMVcVJwIAEI5o/jSAgAA X-CMS-MailID: 20201008211658eucas1p2c05f01cd94d9c4fcd4ee259019b1745c X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20201008052336eucas1p16b5b1600683e33ddba30479b7fd62ce6 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20201008052336eucas1p16b5b1600683e33ddba30479b7fd62ce6 References: <20200925224209.12173-1-l.wojciechow@partner.samsung.com> <20201008052323.11547-1-l.wojciechow@partner.samsung.com> Subject: Re: [dpdk-dev] [PATCH v5 00/15] fix distributor synchronization issues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" W dniu 08.10.2020 o 09:30, David Marchand pisze: > On Thu, Oct 8, 2020 at 7:24 AM Lukasz Wojciechowski > wrote: >> During review and verification of the patch created by Sarosh Arif: >> "test_distributor: prevent memory leakages from the pool" I found out >> that running distributor unit tests multiple times in a row causes fails. >> So I investigated all the issues I found. >> >> There are few synchronization issues that might cause deadlocks >> or corrupted data. They are fixed with this set of patches for both tests >> and librte_distributor library. >> >> --- >> v5: >> * implement missing functionality in burst mode - worker shutdown >> * fix shutdown test to always shutdown busy worker >> * use atomic stores instead of barrier in tests clear_packet_count() >> * reorder patches >> * new patch 7: fix call to return_pkt in single mode >> * new patch 11: replacing delays with spinlock on atomics in tests >> * new patch 12: fix scalar matching algorithm >> * new patch 13: new test with marking and checking every packet >> * new patch 14: flush also in flight packets >> * new patch 15: fix clearing returns buffer >> * minor fixes in other patches > Thanks for working on it, Lukasz. Sorry for the delay, but it was much to solve and test. > David, Honnappa, review please. I'm here if you have any questions or suggestions > > -- Lukasz Wojciechowski Principal Software Engineer Samsung R&D Institute Poland Samsung Electronics Office +48 22 377 88 25 l.wojciechow@partner.samsung.com