From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Lijun Ou <oulijun@huawei.com>, Ray Kinsella <mdr@ashroe.eu>,
David Marchand <david.marchand@redhat.com>,
dev@dpdk.org, linuxarm@openeuler.org,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Subject: Re: [dpdk-dev] [PATCH V3] ethdev: add queue state when retrieve queue information
Date: Thu, 15 Apr 2021 14:36:36 +0200 [thread overview]
Message-ID: <9356626.RYGqZy0Vls@thomas> (raw)
In-Reply-To: <41261214-284c-3f66-a5c7-14bbe0df65b0@intel.com>
15/04/2021 14:33, Ferruh Yigit:
> On 4/15/2021 3:40 AM, Lijun Ou wrote:
> > Currently, upper-layer application could get queue state only
> > through pointers such as dev->data->tx_queue_state[queue_id],
> > this is not the recommended way to access it. So this patch
> > add get queue state when call rte_eth_rx_queue_info_get and
> > rte_eth_tx_queue_info_get API.
> >
> > Note: After add queue_state field, the 'struct rte_eth_rxq_info' size
> > remains 128B, and the 'struct rte_eth_txq_info' size remains 64B, so
> > it could be ABI compatible.
> >
> > Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> > Signed-off-by: Lijun Ou <oulijun@huawei.com>
>
> Looks good to me, but it is causing an ABI error as we already discussed before
> as that is false positive.
>
>
> Ray, David,
>
> Should we add any exception to libabigail.abignore for this?
We do not tolerate any ABI warning.
If we are sure the ABI change is false positive,
it must be suppressed in libabigail.abignore in the same patch.
next prev parent reply other threads:[~2021-04-15 12:36 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 12:25 [dpdk-dev] [PATCH] " Lijun Ou
2021-03-22 9:22 ` Ferruh Yigit
2021-03-22 9:38 ` Kinsella, Ray
2021-03-22 9:39 ` oulijun
2021-03-22 14:49 ` Andrew Rybchenko
2021-03-22 15:45 ` Ananyev, Konstantin
2021-03-22 16:02 ` Andrew Rybchenko
2021-03-22 16:53 ` Ananyev, Konstantin
2021-03-22 17:07 ` Andrew Rybchenko
2021-03-22 18:53 ` Ananyev, Konstantin
2021-03-23 10:13 ` Ferruh Yigit
2021-03-23 10:19 ` Ferruh Yigit
2021-03-23 11:07 ` Ananyev, Konstantin
2021-03-25 10:01 ` oulijun
2021-03-25 10:18 ` Ananyev, Konstantin
2021-03-25 11:09 ` [dpdk-dev] [PATCH V2] " Lijun Ou
2021-04-06 0:49 ` oulijun
2021-04-06 1:55 ` Stephen Hemminger
2021-04-14 10:09 ` Ferruh Yigit
2021-04-06 14:02 ` Ananyev, Konstantin
2021-04-14 10:40 ` Ferruh Yigit
2021-04-14 10:56 ` Ananyev, Konstantin
2021-04-15 2:40 ` [dpdk-dev] [PATCH V3] " Lijun Ou
2021-04-15 12:33 ` Ferruh Yigit
2021-04-15 12:36 ` Thomas Monjalon [this message]
2021-04-15 12:45 ` Ferruh Yigit
2021-04-15 13:34 ` Thomas Monjalon
2021-04-16 0:58 ` [dpdk-dev] [Linuxarm] " oulijun
2021-04-16 7:31 ` Ferruh Yigit
2021-04-16 8:46 ` [dpdk-dev] [PATCH V4] " Lijun Ou
2021-04-16 8:58 ` Thomas Monjalon
2021-04-16 9:41 ` Ferruh Yigit
2021-04-16 9:57 ` Thomas Monjalon
2021-04-23 11:08 ` Kinsella, Ray
2021-04-25 16:42 ` Thomas Monjalon
2021-04-26 9:48 ` Kinsella, Ray
2021-04-16 9:55 ` oulijun
2021-04-16 9:19 ` Ananyev, Konstantin
2021-04-17 3:09 ` [dpdk-dev] [PATCH V5] " Lijun Ou
2021-04-17 22:00 ` Ferruh Yigit
2021-04-19 1:39 ` oulijun
2021-04-19 2:04 ` oulijun
2021-04-19 2:03 ` [dpdk-dev] [PATCH V6] " Lijun Ou
2021-04-19 8:41 ` Thomas Monjalon
2021-04-19 8:58 ` oulijun
2021-04-19 8:57 ` [dpdk-dev] [PATCH v7] " Lijun Ou
2021-04-19 9:03 ` Thomas Monjalon
2021-04-19 10:48 ` Ferruh Yigit
2021-04-23 11:17 ` [dpdk-dev] [PATCH V5] " Kinsella, Ray
2021-04-23 11:26 ` Ananyev, Konstantin
2021-04-23 15:43 ` Kinsella, Ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9356626.RYGqZy0Vls@thomas \
--to=thomas@monjalon.net \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=linuxarm@openeuler.org \
--cc=mdr@ashroe.eu \
--cc=oulijun@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).