From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3441A45CDF; Mon, 11 Nov 2024 00:41:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E2A154027C; Mon, 11 Nov 2024 00:41:00 +0100 (CET) Received: from fout-b6-smtp.messagingengine.com (fout-b6-smtp.messagingengine.com [202.12.124.149]) by mails.dpdk.org (Postfix) with ESMTP id F359E40151 for ; Mon, 11 Nov 2024 00:40:58 +0100 (CET) Received: from phl-compute-06.internal (phl-compute-06.phl.internal [10.202.2.46]) by mailfout.stl.internal (Postfix) with ESMTP id DCAC011401A5; Sun, 10 Nov 2024 18:40:57 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-06.internal (MEProxy); Sun, 10 Nov 2024 18:40:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1731282057; x=1731368457; bh=bUWBJmsSIuEjBxQftbVWiSb8x1e/DilOcn0p8X5mfkw=; b= RZjLta8Z/z3xAYR1BkOPWN5o5V/mJXp7ehSzCHI6eSleOrrwqjWsb+LKOp0KvGET wBfDtMseXq++0VXyvQE/nQObDAd0X0s3yK7Rc/rnmbbdGwToky73bfF2jJTFJEj/ MCyW5YI8ZfTqT29i0C3inCZynuFT2aTrZ5yl5Lbi5BCeBZWpHI8liZmG4Yh6hn05 tPBgH5+WIZJLhh16Dd4qHFLz/hKCcPRXPNh3R3WgDQQ5jqAuGLjnutVHX8HHA8aH axxmtpiY+zVE0fx+BIPKbFd/NHGWB/hEI+dfiG80z89igSzuXnQ8YfqKWhWJ+kG1 7ocsocWdRFh+o7kcAJ9NQA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1731282057; x= 1731368457; bh=bUWBJmsSIuEjBxQftbVWiSb8x1e/DilOcn0p8X5mfkw=; b=P Q8v7s5AzeQhReMnZo2XcNmJIkEunaHj4lYeeWuryAKIZyICfwyFxrJdHTDN/9/hm TiQFdHj8Y/gfhkmu8rdL6o6lkJ4R0xWyI2rh7zVR9oMZvy8ytCiKKhtiheATrzdJ BGcodR+wn1zyu3ogQEOlMUqYsrtNJ5r7kPaYzj2fzgP72EXY67kd5oP85myEOyrX JE4ZKzwkZhgtsyh/3/7oDxby2bNBqeWAr8tsT20APNMhcOApwt2XCzffBPcVuHON 4hvY3nMIFtRzEpEVuW+3to5gWcO0VXE+jYOExkKVcbTihQxRfBVmIOWRUqQwonRX +W2i5A/cwgb7kL7Pn5vyg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddruddugddufecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnth hsucdlqddutddtmdenucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttdejnecu hfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlh honhdrnhgvtheqnecuggftrfgrthhtvghrnhepjeduveehieevuddutdevfffgtdegkeeu veejffejgedtgeegkefgvdeugfefkeejnecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthdpnhgs pghrtghpthhtohepuddvpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehsthgvph hhvghnsehnvghtfihorhhkphhluhhmsggvrhdrohhrghdprhgtphhtthhopehsihhvrghp rhgrshgrugdrthhumhhmrghlrgesrghmugdrtghomhdprhgtphhtthhopegurghvihgurd hhuhhnthesihhnthgvlhdrtghomhdprhgtphhtthhopegrnhgrthholhihrdgsuhhrrghk ohhvsehinhhtvghlrdgtohhmpdhrtghpthhtohepjhgvrhhinhhjsehmrghrvhgvlhhlrd gtohhmpdhrtghpthhtoheprhgrughurdhnihgtohhlrghusehinhhtvghlrdgtohhmpdhr tghpthhtohepghgrkhhhihhlsehmrghrvhgvlhhlrdgtohhmpdhrtghpthhtoheptghrih hsthhirghnrdguuhhmihhtrhgvshgtuhesihhnthgvlhdrtghomhdprhgtphhtthhopehl ihhhuhhishhonhhgsehhuhgrfigvihdrtghomh X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 10 Nov 2024 18:40:55 -0500 (EST) From: Thomas Monjalon To: Stephen Hemminger Cc: Sivaprasad Tummala , david.hunt@intel.com, anatoly.burakov@intel.com, jerinj@marvell.com, radu.nicolau@intel.com, gakhil@marvell.com, cristian.dumitrescu@intel.com, lihuisong@huawei.com, ferruh.yigit@amd.com, konstantin.ananyev@huawei.com, dev@dpdk.org Subject: Re: [PATCH v10 0/6] power: refactor power management library Date: Mon, 11 Nov 2024 00:40:52 +0100 Message-ID: <9370571.alqRGMn8q6@thomas> In-Reply-To: <20241110112919.2afabde5@hermes.local> References: <20241023051139.1066426-1-sivaprasad.tummala@amd.com> <5996777.Isy0gbHreE@thomas> <20241110112919.2afabde5@hermes.local> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 10/11/2024 20:29, Stephen Hemminger: > On Sun, 10 Nov 2024 19:35:55 +0100 > Thomas Monjalon wrote: > > > 28/10/2024 20:55, Sivaprasad Tummala: > > > This patchset refactors the power management library, addressing both > > > core and uncore power management. The primary changes involve the > > > creation of dedicated directories for each driver within > > > 'drivers/power/core/*' and 'drivers/power/uncore/*'. > > > > > > This refactor significantly improves code organization, enhances > > > clarity, and boosts maintainability. It lays the foundation for more > > > focused development on individual drivers and facilitates seamless > > > integration of future enhancements, particularly the AMD uncore driver. > > > > > > Furthermore, this effort aims to streamline code maintenance by > > > consolidating common functions for cpufreq and cppc across various > > > core drivers, thus reducing code duplication. > > > > > > Sivaprasad Tummala (6): > > > power: refactor core power management library > > > power: refactor uncore power management library > > > test/power: removed function pointer validations > > > drivers/power: uncore support for AMD EPYC processors > > > maintainers: update for drivers/power > > > power: rename library sources for cpu frequency management > > > > I'm a bit sad there is not more reviews. > > > > I've moved the pointers check removal first, > > renamed intel_pstate files (not the functions), > > fixed few things like __cplusplus, include guards, > > sorting and maintainers file. > > > > Applied > > > > > > I think this broke the build. The next unrelated change in CI is failing. > Fixing the initialization in mlx5 patch failed. Indeed. Thanks for the notice. It should be fixed now.