From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A2E46A04FA; Wed, 5 Feb 2020 14:41:42 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 74A5B1C1E6; Wed, 5 Feb 2020 14:41:42 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 41C6F1C038; Wed, 5 Feb 2020 14:41:40 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Feb 2020 05:41:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,405,1574150400"; d="scan'208,217";a="254762487" Received: from vmedvedk-mobl.ger.corp.intel.com (HELO [10.237.220.123]) ([10.237.220.123]) by fmsmga004.fm.intel.com with ESMTP; 05 Feb 2020 05:41:37 -0800 To: Timothy Redaelli , dev@dpdk.org Cc: stable@dpdk.org References: From: "Medvedkin, Vladimir" Message-ID: <93926f34-404a-3de3-c320-8705354ab89b@intel.com> Date: Wed, 5 Feb 2020 13:41:37 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 2/3] app/test: fix building with GCC 10 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 05/02/2020 12:50, Timothy Redaelli wrote: > GCC 10 defaults to -fno-common, this means a linker error will now be > reported if the same global variable is defined in more than one > compilation unit. > > Fixes: 08e0c7581468 ("test/fib: add performance autotests") > Cc: vladimir.medvedkin@intel.com > Cc: stable@dpdk.org > Signed-off-by: Timothy Redaelli > --- > app/test/test_fib_perf.c | 2 +- > app/test/test_lpm_perf.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/app/test/test_fib_perf.c b/app/test/test_fib_perf.c > index 573087c3c..dd2e54db8 100644 > --- a/app/test/test_fib_perf.c > +++ b/app/test/test_fib_perf.c > @@ -35,7 +35,7 @@ struct route_rule { > uint8_t depth; > }; > > -struct route_rule large_route_table[MAX_RULE_NUM]; > +static struct route_rule large_route_table[MAX_RULE_NUM]; > > static uint32_t num_route_entries; > #define NUM_ROUTE_ENTRIES num_route_entries > diff --git a/app/test/test_lpm_perf.c b/app/test/test_lpm_perf.c > index a2578fe90..489719c40 100644 > --- a/app/test/test_lpm_perf.c > +++ b/app/test/test_lpm_perf.c > @@ -34,7 +34,7 @@ struct route_rule { > uint8_t depth; > }; > > -struct route_rule large_route_table[MAX_RULE_NUM]; > +static struct route_rule large_route_table[MAX_RULE_NUM]; > > static uint32_t num_route_entries; > #define NUM_ROUTE_ENTRIES num_route_entries Acked-by: Vladimir Medvedkin -- Regards, Vladimir