From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 24780A052A; Tue, 2 Feb 2021 09:08:31 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A70B52402AB; Tue, 2 Feb 2021 09:08:30 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id E208C2402AA; Tue, 2 Feb 2021 09:08:28 +0100 (CET) IronPort-SDR: wA8mQ6FdXgRIbnQSZGmqYcuz0uwrFIRkb2tN+4iFccgFW5FyG5qnmbifr95K2H0ds42dj+aAOb RJkhu7TVW9cw== X-IronPort-AV: E=McAfee;i="6000,8403,9882"; a="265647420" X-IronPort-AV: E=Sophos;i="5.79,394,1602572400"; d="scan'208";a="265647420" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2021 00:08:27 -0800 IronPort-SDR: NHriCcrSpwdNpwMgsYMXfsRcHNKKWHojIZjTcfsaC20aS9TYQkmF2krzdWTp+0P9qYnroXmylc 91sZADFEa0OQ== X-IronPort-AV: E=Sophos;i="5.79,394,1602572400"; d="scan'208";a="391341402" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.226.112]) ([10.213.226.112]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2021 00:08:24 -0800 To: Ruifeng Wang , Jan Viktorin , "jerinj@marvell.com" , Bruce Richardson , =?UTF-8?Q?Juraj_Linke=c5=a1?= , Honnappa Nagarahalli , Vimal Chungath Cc: "dev@dpdk.org" , "thomas@monjalon.net" , "stable@dpdk.org" , Thierry Herbelot , nd References: <7a4b591b-5e32-a3f8-a8ff-59a636217814@6wind.com> <20210201224150.2718693-1-ferruh.yigit@intel.com> From: Ferruh Yigit Message-ID: <939e6a81-86c4-5459-7094-b386388c9014@intel.com> Date: Tue, 2 Feb 2021 08:08:21 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] config/arm: fix typo in meson config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2/2/2021 2:19 AM, Ruifeng Wang wrote: >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Tuesday, February 2, 2021 6:42 AM >> To: Jan Viktorin ; Ruifeng Wang >> ; jerinj@marvell.com; Bruce Richardson >> ; Juraj Linkeš ; >> Honnappa Nagarahalli ; Vimal Chungath >> >> Cc: Ferruh Yigit ; dev@dpdk.org; >> thomas@monjalon.net; stable@dpdk.org; Thierry Herbelot >> >> Subject: [PATCH] config/arm: fix typo in meson config >> >> s/implementor/implementer >> >> Fixes: 3d01d65ba0d3 ("config: add aarch64 clang for Ubuntu 18.04") >> Fixes: c51401832147 ("config/arm: add Graviton2") > > 'implementor' -> 'implementer' change was made in 7870ae8994c6. > It seems 7870ae8994c6 missed Graviton2 config file which was added earlier. > Right, I missed the rename patch, so it should be: Fixes: 7870ae8994c6 ("config/arm: rename variables") And that rename patch does 'implementor_pn' -> 'part_number', so I will update this patch to do the same. > With the fix tag update, > Reviewed-by: Ruifeng Wang > >> Cc: stable@dpdk.org >> >> Reported-by: Thierry Herbelot >> Signed-off-by: Ferruh Yigit >> --- >> Cc: Juraj Linkeš >> Cc: Ruifeng Wang >> Cc: vcchunga@amazon.com >> --- >> config/arm/arm64_armv8_linux_clang_ubuntu1804 | 4 ++-- >> config/arm/arm64_graviton2_linux_gcc | 4 ++-- >> 2 files changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/config/arm/arm64_armv8_linux_clang_ubuntu1804 >> b/config/arm/arm64_armv8_linux_clang_ubuntu1804 >> index aa5ee0132065..ae3fb30c5da8 100644 >> --- a/config/arm/arm64_armv8_linux_clang_ubuntu1804 >> +++ b/config/arm/arm64_armv8_linux_clang_ubuntu1804 >> @@ -14,7 +14,7 @@ cpu = 'armv8-a' >> endian = 'little' >> >> [properties] >> -implementor_id = 'generic' >> -implementor_pn = 'default' >> +implementer_id = 'generic' >> +implementer_pn = 'default' >> c_args = ['-target', 'aarch64-linux-gnu', '--sysroot', '/usr/aarch64-linux-gnu'] >> c_link_args = ['-target', 'aarch64-linux-gnu', '-fuse-ld=lld', '--gcc- >> toolchain=/usr'] diff --git a/config/arm/arm64_graviton2_linux_gcc >> b/config/arm/arm64_graviton2_linux_gcc >> index cfe2397975fc..123f14eed29e 100644 >> --- a/config/arm/arm64_graviton2_linux_gcc >> +++ b/config/arm/arm64_graviton2_linux_gcc >> @@ -13,8 +13,8 @@ cpu = 'armv8-a' >> endian = 'little' >> >> [properties] >> -implementor_id = '0x41' >> -implementor_pn = '0xd0c' >> +implementer_id = '0x41' >> +implementer_pn = '0xd0c' >> max_lcores = 64 >> max_numa_nodes = 1 >> numa = false >> -- >> 2.29.2 >