From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id A1CF71B24B for ; Fri, 10 Nov 2017 00:07:40 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Nov 2017 15:07:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,371,1505804400"; d="scan'208";a="317736" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.224.59]) ([10.241.224.59]) by FMSMGA003.fm.intel.com with ESMTP; 09 Nov 2017 15:07:39 -0800 To: "Patil, Harish" , "Mody, Rasesh" , "dev@dpdk.org" , "thomas.monjalon@6wind.com" Cc: Dept-Eng DPDK Dev References: <1510210340-5433-1-git-send-email-rasesh.mody@cavium.com> <1510210340-5433-2-git-send-email-rasesh.mody@cavium.com> <299dcd47-ca68-afe9-34ca-6c6be7a5cd8b@intel.com> From: Ferruh Yigit Message-ID: <93aad5f1-7ed1-e872-30dd-ffadfdd830bb@intel.com> Date: Thu, 9 Nov 2017 15:07:37 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/2] net/qede: fix default config option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Nov 2017 23:07:41 -0000 On 11/9/2017 3:00 PM, Patil, Harish wrote: > -----Original Message----- > From: Harish Patil > Date: Thursday, November 9, 2017 at 3:57 PM > To: Ferruh Yigit , "Mody, Rasesh" > , "dev@dpdk.org" , > "thomas.monjalon@6wind.com" > Cc: Dept-Eng DPDK Dev > Subject: Re: [dpdk-dev] [PATCH 2/2] net/qede: fix default config option > >> -----Original Message----- >> From: Ferruh Yigit >> Date: Thursday, November 9, 2017 at 3:48 PM >> To: "Mody, Rasesh" , "dev@dpdk.org" >> , "thomas.monjalon@6wind.com" >> Cc: Harish Patil , Dept-Eng DPDK Dev >> >> Subject: Re: [dpdk-dev] [PATCH 2/2] net/qede: fix default config option >> >>> On 11/8/2017 10:52 PM, Rasesh Mody wrote: >>>> From: Harish Patil >>>> >>>> Restore the default configuration as in previous releases and >>>> add a debug msg. >>> >>> Is this reverting >>> "f07aa795c92a ("net/qede: disable per-VF Tx switching feature")" >>> >>> This will be same as code before f07aa795c92a , right? If so why not just >>> remove >>> the config option for this release and add a dynamic runtime in next >>> release? >>> >>> I am not clear for both f07aa795c92a and this one fixing, and why should >>> they be >>> included for rc3? >>> >>> Thanks, >>> Ferruh >> >> Hi Ferruh, >> Some customers are interested in getting better performance with 64B sized >> packets. For that, they would need to keep this config disabled. >> But in all other cases, by default, we would like to keep Tx switching >> enabled (at a reduced performance) as in previous releases. >> As stated in other email with Thomas, we shall remove this compile-time >> config option in next release and use runtime option instead. >> But for 17.08 we need it to be enabled by default. >> Thanks. > > Correction, I meant 17.11 release, not 17.08. Other patch just sent two days ago, to introduce the config option as disabled by default, so it was changing the behavior and accepted as a fix for rc3. Now two days later, this patch enables it as a fix again, only difference for two days ago becomes adding a config option? >> >>> >>>> >>>> Fixes: f07aa795c92a ("net/qede: disable per-VF Tx switching feature") >>>> >>>> Signed-off-by: Harish Patil >>>> Signed-off-by: Rasesh Mody >>>> --- >>>> config/common_base | 2 +- >>>> drivers/net/qede/qede_ethdev.c | 5 +++-- >>>> 2 files changed, 4 insertions(+), 3 deletions(-) >>>> >>>> diff --git a/config/common_base b/config/common_base >>>> index 34f04a9..e74febe 100644 >>>> --- a/config/common_base >>>> +++ b/config/common_base >>>> @@ -415,7 +415,7 @@ CONFIG_RTE_LIBRTE_QEDE_DEBUG_INFO=n >>>> CONFIG_RTE_LIBRTE_QEDE_DEBUG_DRIVER=n >>>> CONFIG_RTE_LIBRTE_QEDE_DEBUG_TX=n >>>> CONFIG_RTE_LIBRTE_QEDE_DEBUG_RX=n >>>> -CONFIG_RTE_LIBRTE_QEDE_VF_TX_SWITCH=n >>>> +CONFIG_RTE_LIBRTE_QEDE_VF_TX_SWITCH=y >>>> #Provides abs path/name of the firmware file. >>>> #Empty string denotes driver will use default firmware >>>> CONFIG_RTE_LIBRTE_QEDE_FW="" >>>> diff --git a/drivers/net/qede/qede_ethdev.c >>>> b/drivers/net/qede/qede_ethdev.c >>>> index 8832145..6f5ba2a 100644 >>>> --- a/drivers/net/qede/qede_ethdev.c >>>> +++ b/drivers/net/qede/qede_ethdev.c >>>> @@ -457,6 +457,7 @@ int qede_activate_vport(struct rte_eth_dev >>>> *eth_dev, bool flg) >>>> if (IS_VF(edev)) { >>>> params.update_tx_switching_flg = 1; >>>> params.tx_switching_flg = !flg; >>>> + DP_INFO(edev, "VF tx-switching is disabled\n"); >>>> } >>>> #endif >>>> for_each_hwfn(edev, i) { >>>> @@ -469,8 +470,8 @@ int qede_activate_vport(struct rte_eth_dev >>>> *eth_dev, bool flg) >>>> break; >>>> } >>>> } >>>> - DP_INFO(edev, "vport %s VF tx-switch %s\n", flg ? "activated" : >>>> "deactivated", >>>> - params.tx_switching_flg ? "enabled" : "disabled"); >>>> + DP_INFO(edev, "vport is %s\n", flg ? "activated" : "deactivated"); >>>> + >>>> return rc; >>>> } >>>> >>>> >>> >> >