From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B3E1D48B0C; Fri, 14 Nov 2025 18:41:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9ED314113C; Fri, 14 Nov 2025 18:40:45 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by mails.dpdk.org (Postfix) with ESMTP id 75ABE410FC for ; Fri, 14 Nov 2025 18:40:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1763142041; x=1794678041; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=FBelfQYJjYg2ZYRfUpWUNsbByV3340ukJgEOIb+xs7g=; b=Ai6duWnuTY60f1aTKYHmhcWf8dx9i84Ba9dEQqK9ZQwt7eusC11Fbjg5 Qkg1qYw2el0e/bBJvH/eH2nkUwmFY76o7AQkDmzhIsIx/OaUUjZu8kN4f /JAek0KBr47YcxfUMWgt2iDMs6RVMde4AStAqI7dA8/ilr9/G2YRelBMf buJYzoKPmibic6dSCkZt400qIRUDI0Ale0yS1NJu/Bogy7ljdCCdD5x3Q jcoXQ/xd8SYZYx72kXajjo+PFAwxSYLNgtBEOHjSoKam3r4pj4bFBrwdg xcnS7HEKv7KsC+IBcdIjvAa8sUvWC85XjdbD96DB1S7iWurmgbtJ7o0a0 A==; X-CSE-ConnectionGUID: hAR0oqjHRaSWxvLgGejAjg== X-CSE-MsgGUID: PYb+WcmKRX+7fVzG9StduQ== X-IronPort-AV: E=McAfee;i="6800,10657,11613"; a="68864264" X-IronPort-AV: E=Sophos;i="6.19,305,1754982000"; d="scan'208";a="68864264" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Nov 2025 09:40:41 -0800 X-CSE-ConnectionGUID: I7xWKafsT36RTf/IyPxynA== X-CSE-MsgGUID: ie5DRxpNR9CNP+BNoFldqw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.19,305,1754982000"; d="scan'208";a="189650749" Received: from silpixa00401119.ir.intel.com ([10.20.224.206]) by orviesa009.jf.intel.com with ESMTP; 14 Nov 2025 09:40:40 -0800 From: Anatoly Burakov To: dev@dpdk.org, Bruce Richardson , Tyler Retzlaff Subject: [PATCH v2 05/19] vfio: add container device assignment API Date: Fri, 14 Nov 2025 17:40:15 +0000 Message-ID: <93bb3f3800c9145debf188f9c520dd0c0d4907d0.1763142008.git.anatoly.burakov@intel.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Currently, VFIO has explicit group bind API's, but the way they're used is such that no one actually cares about VFIO groups, and the real goal of everyone using VFIO group bind API is to bind devices to particular VFIO container, such that when `rte_vfio_setup_device` call eventually comes, VFIO will pick up the correct container. To remove dependency on group API's, add a new "container assign device" API call that will do the same thing, but will not depend on managing VFIO group fd's. Signed-off-by: Anatoly Burakov --- lib/eal/freebsd/eal.c | 10 ++++++++++ lib/eal/include/rte_vfio.h | 26 ++++++++++++++++++++++++++ lib/eal/linux/eal_vfio.c | 32 ++++++++++++++++++++++++++++++++ 3 files changed, 68 insertions(+) diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c index 3142ccd4bd..a4d6cfe0a4 100644 --- a/lib/eal/freebsd/eal.c +++ b/lib/eal/freebsd/eal.c @@ -937,3 +937,13 @@ rte_vfio_container_dma_unmap(__rte_unused int container_fd, rte_errno = ENOTSUP; return -1; } + +RTE_EXPORT_INTERNAL_SYMBOL(rte_vfio_container_assign_device) +int +rte_vfio_container_assign_device(__rte_unused int vfio_container_fd, + __rte_unused const char *sysfs_base, + __rte_unused const char *dev_addr) +{ + rte_errno = ENOTSUP; + return -1; +} diff --git a/lib/eal/include/rte_vfio.h b/lib/eal/include/rte_vfio.h index 0ddeb08f94..aedb5fb41c 100644 --- a/lib/eal/include/rte_vfio.h +++ b/lib/eal/include/rte_vfio.h @@ -278,6 +278,32 @@ __rte_internal int rte_vfio_container_destroy(int container_fd); +/** + * @internal + * + * Assign a device to a VFIO container. + * + * Doing so will cause `rte_vfio_setup_device()` to set up the device with the VFIO container + * specified in this assign operation. + * + * This function is only relevant on Linux. + * + * @param vfio_container_fd + * VFIO container file descriptor. + * @param sysfs_base + * Sysfs path prefix. + * @param dev_addr + * Device identifier. + * + * @return + * 0 on success. + * <0 on failure, rte_errno is set. + */ +__rte_internal +int +rte_vfio_container_assign_device(int vfio_container_fd, const char *sysfs_base, + const char *dev_addr); + /** * @internal * Bind a IOMMU group to a container. diff --git a/lib/eal/linux/eal_vfio.c b/lib/eal/linux/eal_vfio.c index 33fa04feaf..29dd1758e4 100644 --- a/lib/eal/linux/eal_vfio.c +++ b/lib/eal/linux/eal_vfio.c @@ -2120,6 +2120,38 @@ rte_vfio_container_destroy(int container_fd) return 0; } +RTE_EXPORT_INTERNAL_SYMBOL(rte_vfio_container_assign_device) +int +rte_vfio_container_assign_device(int vfio_container_fd, const char *sysfs_base, + const char *dev_addr) +{ + int iommu_group_num; + int ret; + + ret = rte_vfio_get_group_num(sysfs_base, dev_addr, &iommu_group_num); + if (ret < 0) { + EAL_LOG(ERR, "Cannot get IOMMU group number for device %s", + dev_addr); + return -1; + } else if (ret == 0) { + EAL_LOG(ERR, + "Device %s is not assigned to any IOMMU group", + dev_addr); + return -1; + } + + ret = rte_vfio_container_group_bind(vfio_container_fd, + iommu_group_num); + if (ret < 0) { + EAL_LOG(ERR, + "Cannot bind IOMMU group %d for device %s", + iommu_group_num, dev_addr); + return -1; + } + + return 0; +} + RTE_EXPORT_INTERNAL_SYMBOL(rte_vfio_container_group_bind) int rte_vfio_container_group_bind(int container_fd, int iommu_group_num) -- 2.47.3