From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <arybchenko@solarflare.com>
Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com
 [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 78A611E25
 for <dev@dpdk.org>; Mon,  8 Oct 2018 11:24:56 +0200 (CEST)
X-Virus-Scanned: Proofpoint Essentials engine
Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id
 69343980071; Mon,  8 Oct 2018 09:24:55 +0000 (UTC)
Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com
 (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 8 Oct 2018
 10:24:49 +0100
To: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>, <dev@dpdk.org>
CC: <indranil@chelsio.com>, <nirranjan@chelsio.com>
References: <cover.1537776502.git.rahul.lakkireddy@chelsio.com>
 <1538840520-10369-1-git-send-email-rahul.lakkireddy@chelsio.com>
 <1538840520-10369-3-git-send-email-rahul.lakkireddy@chelsio.com>
From: Andrew Rybchenko <arybchenko@solarflare.com>
Message-ID: <93c0cf87-ab70-da81-b7e2-ab1ecf0b12fc@solarflare.com>
Date: Mon, 8 Oct 2018 12:24:08 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.0
MIME-Version: 1.0
In-Reply-To: <1538840520-10369-3-git-send-email-rahul.lakkireddy@chelsio.com>
Content-Language: en-GB
X-Originating-IP: [91.220.146.112]
X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To
 ukex01.SolarFlarecom.com (10.17.10.4)
X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24142.003
X-TM-AS-Result: No-15.015600-8.000000-10
X-TMASE-MatchedRID: VfovoVrt/oYOwH4pD14DsPHkpkyUphL9MZm0+sEE9mtnnK6mXN72m1la
 hCeVxirtjWWhwpKfm/67/LlTYfsWi7oyKC6miLNVW7gz/Gbgpl5MkOX0UoduuZiiJ0OtYmgDOpc
 qctkANi9fzpKi5wJDhW1/yEfMFk2o8FLksoJC8fRoOA9kFf9sy+q9xwosX7inDC/Vm90If4VUza
 n9xEPKMWJz/nKtphYOV5samMezmZbGV1Io4ZdpfBkJVFT9oj3M9zefYQcHZp9CI7pNLiSjfcUzz
 dIu4oxh92grUwQgYZd5OPD8XJFfpE1+zyfzlN7ygxsfzkNRlfKx5amWK2anSLVV9mtf2bFYHYn7
 /O2MapOoKMGQt80bX28EmjZ9PmjvQhD5piBRdFdNSaqE5Kr2YsK7SfuriwToESTyvI+ppSg0tPp
 BkzZ6Y5I7BVGV1lix
X-TM-AS-User-Approved-Sender: Yes
X-TM-AS-User-Blocked-Sender: No
X-TMASE-Result: 10--15.015600-8.000000
X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24142.003
X-MDID: 1538990696-TMV9GIqzvtAQ
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH v2 2/3] ethdev: add flow api actions to
 modify TCP/UDP port numbers
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Oct 2018 09:24:56 -0000

On 10/6/18 6:41 PM, Rahul Lakkireddy wrote:
> Add actions:
> - SET_TP_SRC - set a new TCP/UDP source port number.
> - SET_TP_DST - set a new TCP/UDP destination port number.
>
> Original work by Shagun Agrawal
>
> Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
> Acked-by: Xiaoyu Min <jackmin@mellanox.com>
> Acked-by: Ori Kam <orika@mellanox.com>

One nit below, otherwise
Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>

<...>

> @@ -1939,6 +1961,21 @@ struct rte_flow_action_set_ipv6 {
>   	uint8_t ipv6_addr[16];
>   };
>   
> +/**
> + * @warning
> + * @b EXPERIMENTAL: this structure may change without prior notice
> + *
> + * RTE_FLOW_ACTION_TYPE_SET_TP_SRC
> + * RTE_FLOW_ACTION_TYPE_SET_TP_DST
> + *
> + * Allows modification of source (RTE_FLOW_ACTION_TYPE_SET_TP_SRC)
> + * and destination (RTE_FLOW_ACTION_TYPE_SET_TP_DST) port numbers
> + * in the specified outermost TCP/UDP header.
> + */
> +struct rte_flow_action_set_tp {
> +	uint16_t port;

rte_be16_t?