From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id A70CD5F2D; Fri, 24 Aug 2018 17:04:25 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Aug 2018 08:04:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,283,1531810800"; d="scan'208";a="67596159" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.56]) ([10.237.221.56]) by orsmga007.jf.intel.com with ESMTP; 24 Aug 2018 08:04:23 -0700 To: Alejandro Lucero , dev@dpdk.org Cc: stable@dpdk.org References: <1535120736-785-1-git-send-email-alejandro.lucero@netronome.com> <1535120736-785-2-git-send-email-alejandro.lucero@netronome.com> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: <93c6412d-362f-7285-e02e-1d51f54fb5ae@intel.com> Date: Fri, 24 Aug 2018 16:04:22 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1535120736-785-2-git-send-email-alejandro.lucero@netronome.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 1/2] ethdev: fix MAC changes when live change not supported X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Aug 2018 15:04:26 -0000 On 8/24/2018 3:25 PM, Alejandro Lucero wrote: > Current code assumes a MAC change can occur when the port has been > started. In fact, there are some NICs which require this port state > for being successful, but other NICs not always support MAC change > in that case. > > This patch supports a new device flag for a device advertising this > limitation, and if the flag is set, the MAC is changed before the > port starts. > > Fixes: af75078fece3 ("first public release") > Cc: stable@dpdk.org > > Signed-off-by: Alejandro Lucero Reviewed-by: Ferruh Yigit