From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 55927A00C5; Wed, 31 Aug 2022 03:49:22 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DC4EF40F17; Wed, 31 Aug 2022 03:49:21 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 5A81040395 for ; Wed, 31 Aug 2022 03:49:20 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 27UKjQfa023997; Tue, 30 Aug 2022 18:49:14 -0700 Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2176.outbound.protection.outlook.com [104.47.56.176]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3j9sv4982k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 30 Aug 2022 18:49:14 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e4EhDeoGkHGMC4SyKmmwQKqVmh2MFgz0uCMi4kJ4WTYm2AhAI6GGfTE5kFNImC/A7/Pv2dJJxJoDMtS72AuwVSzUwm5zc3qZt4fnF7Bh4qfu6PMY3J4lTKIxSl+RJWgDPyZt6zZDwCIlzy0JB5c0IVX9Jds/cllw6butXP5rVO4ij9ABiN3mNn4sqKIvGX0f9+0/3NMM01TWUIEGmmiweb1i9gT+2UE4rau22XahGJ2ctIcW7xp7jyVW+Ny5KV7jQ8sCKJzp5GIK2+cQ+okPgUa7prjQYbuaMsAHI0v4/SWh1UykiZJ2TpUkhZxdii6Cy1ZW0suHA8qPoctfivntsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ruey2/IgxXYR/fb3VK+ug+yy/WLZ1/noTBmn1uhto5s=; b=Q4HJnYpbxqt06QftCMq8lsOo3xtxZnIR+5WfVMfg5yvH9rJYPTy2FKPDBzi2CLOPqNlp8Y0mxpmNffNzyhisxUvY4g1ALgQCtSDigc8Qy8Rtw+w1mZcmWxDej2+Wfv82lsI6opAky1d84sObqVVce6F4z5VIWvDfOinFlFHUlV+GJXnGQR7+XlJXaTuahQg1oWz3OvFmgiLY7gzDX/ZG2dUYQnD9YF4BSOsC3XqyOWidy3+BD0D8rrEvsQBcvEDBP2PPq1tbG93BzMMfBeXdUnqBRnL4RbvH6wlbxci3N4tS7flZRaKQNnYAlHTg/1xZI6EmXg+fZ7klCjjpM86L2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ruey2/IgxXYR/fb3VK+ug+yy/WLZ1/noTBmn1uhto5s=; b=GkXTgBViTbS8b5EdC81ghoVhMRB1WQyJGQUoXy3nUQSFX3UeCeTVrJOxdfAVW9GByYKYf23vcwP7b/BS83g06r+XmoSoXPb5Og1rB7ReP+tHD25piAAUytv3vS7Slyz5dg/vLMBnaB1ekAkn8DXA5mSNtJB+/LkcNEHMZ7TdnUo= Received: from MW2PR18MB2171.namprd18.prod.outlook.com (2603:10b6:907:7::17) by PH0PR18MB4024.namprd18.prod.outlook.com (2603:10b6:510:2c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Wed, 31 Aug 2022 01:49:11 +0000 Received: from MW2PR18MB2171.namprd18.prod.outlook.com ([fe80::9c71:355f:863:e111]) by MW2PR18MB2171.namprd18.prod.outlook.com ([fe80::9c71:355f:863:e111%4]) with mapi id 15.20.5566.021; Wed, 31 Aug 2022 01:49:10 +0000 Message-ID: <93c8eb1c-a15c-27ec-140e-55a30cca1a87@marvell.com> Date: Wed, 31 Aug 2022 07:19:02 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH v3 1/5] mbuf: clarify meta data needed for Outbound Inline Content-Language: en-US To: Olivier Matz , "Ananyev, Konstantin" Cc: Jerin Jacob Kollanukkaran , "dev@dpdk.org" , Akhil Goyal , "ruifeng.wang@arm.com" References: <20220707072921.13448-1-ndabilpuram@marvell.com> <20220822143812.30010-1-ndabilpuram@marvell.com> From: Nithin Kumar Dabilpuram In-Reply-To: <20220822143812.30010-1-ndabilpuram@marvell.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SG2P153CA0005.APCP153.PROD.OUTLOOK.COM (2603:1096::15) To MW2PR18MB2171.namprd18.prod.outlook.com (2603:10b6:907:7::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7794b1b2-f9fa-4320-7466-08da8af2ffbf X-MS-TrafficTypeDiagnostic: PH0PR18MB4024:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YUGX7mp1fum1N1O5fQp9W8ceU+TPJWM9Mw2EO5CJieAGgcR/0kBC0rZ727vRP1z2b38Ti2ilsQKWJefE6BR8VzX1/HtjG9roiAXwLvEWo6lGOwVkHy1yyU+oZVFqSvZiKt2Kw0FBrjAKeH39yqsJuXohGDlpivXadrR7iYKUmbEQ65dXd+Xez11LraVbxS03L+jSVq2AcXCO/+oSSu4FHPWUwGRzxE1Px0SRT0h6cn2ePkPCCe/snycII/RJVCiYEpVk3jaxWGPIG0CBT5CEwTtffvfPJXHIkI8Fq36EO9zajO/R12qXKgZoulJVNcHNP34u5dIDZH8wSfykOrCEzLbbFCqWukDYOf492fpi3jWcSxY0aW8Tr9A/d1z0Tp4CzqdX+QF4sohowRyM1FnIZnWFEai9UpkrniUiov6XtsCiNwfidDSgJ6gJHy8BSEqFguyH2iN6tp94IFKyjDZBWB3ivuoefDL1yw8Ppdic4X9GOY5gUqHG0MCdbc7jAlswc+sWhyWwImInlVtuIxexXYIUwzQ9EuLOHapJhkNCN1NsoZ++vx5kUo2P9w2voevrcF23aUMjMAguSV0twGlf3Abn5j90e89bSiyJ3bmPl/dRSD0tnZNmB3zY63ajsxSHrs65ZBYSJDtEUk3WTVyBic4i8PrxeGBkYCWXqJRZAgXSSyp0+GXyqToQbocwCGSj0BnxKVNgF5UdsYxucrWto+vD3qj8HAoBiIdT/R68wcjU2OuqjyaaF1hahP6V7O8Cc17epdJ29IioGTgRjWtMOyoig8t25+Wen+YIId9w5KhOW9PsmOt9dxpVzmI8a5UBra2LeDkqnqu5JKSW4nsavA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR18MB2171.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(39860400002)(346002)(366004)(376002)(136003)(396003)(31686004)(83380400001)(38100700002)(38350700002)(66556008)(110136005)(8676002)(4326008)(66476007)(66946007)(54906003)(316002)(2906002)(8936002)(5660300002)(52116002)(6512007)(6506007)(26005)(186003)(2616005)(6486002)(6666004)(53546011)(478600001)(41300700001)(31696002)(86362001)(36756003)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L2NKLzVKbU8yQXRIVnc4bFVOaUpIZzJBT3BhdVA4RUpmSmN3ZFl2TlkxSXZz?= =?utf-8?B?bThVU2duZU1HdzUvQ0xsQUVERU5tY1hDemE1MHJyVVVMSW8xeHI4bk9Xc3pw?= =?utf-8?B?SmNUb1ZGaVBWSVhWTDFDNUNNUWNwMW9aaVlKeFBhK3EwcEpMbVNIMThwTEp0?= =?utf-8?B?ekZweUt5dHNGenhPNGNuZ2d5NXI2T3ZwN0Q2TFlrYzBKcDZKRXJta1BkQiti?= =?utf-8?B?c3A1Z3J6YVFKbXpuQlJXNDdnYXZ0cExrNGU3Zms3NGh6a2pkd2Zwc2NQdUpS?= =?utf-8?B?ZVZnelFONyt1bFJabC9GUW5jT0R5RkJQRmFnWmNlbVlGbncwNnMwV2JsODlr?= =?utf-8?B?am02RVJZS1RlNkxKOHNBUTZVdjltMHdsa29VODViQm5VZllKcDVFZzNabmxY?= =?utf-8?B?Z1JOejNNU0Z4QWxqaUlINExBdjRiOTZ1SGtlc3pZclBnbEVObmRnQ3pRa2s3?= =?utf-8?B?OEVyWFh2OUx6ZUJVZXdHT0lqNHQ5anhGM2QrOWJTK2tidm5iMFBFTmtWZmRy?= =?utf-8?B?Q1JqTnJld0pGdHV6ZXduUG9xUjNpTHRlTkVmUVVrT2N5azBiTEFBa1Q4RDJ1?= =?utf-8?B?V3FsZ0phVWZoSW9IdGZsSWtxTForZnRHRmVCckYvWEhZMTZURVoxQWRndTZn?= =?utf-8?B?QXdsRFBobDdoNGhrYkNSK1V6dVlCSXM3Mk9qdU1aODIzbUd5TEsreEJ6YU1k?= =?utf-8?B?d25MM2N5VHJobkFVQmxGOUVpcVlYSnBVSEk3MmhxcXR4L1VlVXpXYytxdHMy?= =?utf-8?B?VmFZM1BRNkxSZkNaT2c2eTZyRWgyRTBwV1c5ajhHNXpCV3FEMzJzU0Y5d2Ex?= =?utf-8?B?aHBRcFQ4WkZUNWtLdm5RODZMd0VUY09OYWtoWmtZTVN2WnhjUzdjTEZrYXlR?= =?utf-8?B?eXU5QWV4ZUxhenJ1a1JrcUxhdk1pemhoWk9Sd24ydm43b240bnc0dXhRR0Vi?= =?utf-8?B?b2hzSGMzenhhMkFCRWw5L1B3RHFhOEVNM25USFZaamN6WjViTmE5TkxzdTM2?= =?utf-8?B?YVZPNHlpUzJVTWZqU2FOYjhxV2d1VmVXY0ZRVzZsaVlteEJtaGtFcmJYUGJv?= =?utf-8?B?bjBZdTEveFh2Uy93MDRocXZ0ZXBCMW1qaGFpL2Nad05ESkF5b2phQmNQa0ky?= =?utf-8?B?TnVXYk1QRnpKSW90SXJTaDdBQXBObjVUaWhZbXhjS0VxT3R6djQ1L1lCN1VX?= =?utf-8?B?VXRORHN2OVZIZlBRZ1dXZmovVEhrRjgvci9JR0t0eGJROWZaK2ZoYVlhaWN6?= =?utf-8?B?OFBYdU5janE2cFBQRklFZlZuZlVSY2Z4Z1FPcE9rK1RlaWhoY29IU054R0NV?= =?utf-8?B?NmYxd0VYQnVtek9xVG1kQlY0U1ZsNXJ5enlETGNHNHJJTTVtL0xQRmRvYjFZ?= =?utf-8?B?TCtYWUF3Y3NUU1dCdzE0b1M5bWEvbjBhVnc3Um5qRGRBbzd3SG9NdDVNR21w?= =?utf-8?B?VzRPcnB6TlpFQzN0QURES2FIbGVRWWUzeVdOaGE1NEhIOFhoOWUyNUNnMUVP?= =?utf-8?B?V1c0L3lZbHhuejl1WFpwSzRjWGZEZURQTUFmY1d5VDBqSUVtUzk2eS9qUkJh?= =?utf-8?B?a3c4VmtqaVA2MUt3Uk9Hb2VQUWp4UE9sWmZ5aUNxZUFpRFdxOUtyU2doVzNh?= =?utf-8?B?SUxUNjJxYThlK20ybW1IOXQzemxDQ1dkRU9GUGxia05PSFNoWmd3NGZZRDJP?= =?utf-8?B?R2tlZlpNTjB6OEkwUzJHdWZ2QUovRUJIbXpVS3pZZG5MOW9TT2M2Y0E0QkFV?= =?utf-8?B?RldoaDdueUJJSDNnRUovMGphcmdZTHUyM2sxejY3SHFYeWRnOXIybFkyUXdB?= =?utf-8?B?ajE3Nm9sMVMvZFpFSVcxV09pdGtVOGxnTktVUE1uYVNxZzcrMk83dVNCVThI?= =?utf-8?B?V1ZYOE5oejBmS2lseWtCVjliUkpEaThsTTc1dnU0cE9qNWFKTW1Xd3ljYlds?= =?utf-8?B?TlZHWEp1NGNlcmphNWVBQVA5MlhvZGFCZnRCYTR4Q0Q3eEQ1R3dSUEhjWmtn?= =?utf-8?B?K3J2b01na0RSa2NPM1VKQjZrMFY4WC80V05jNThhYkFEai9teldsMlUxRzhm?= =?utf-8?B?SmRuNXBjbUFFUU40MVdwUVBybDJ6L3FMbWo4M2RITWtkZDQyb3F4Tmpwcy9I?= =?utf-8?B?Z0dzcjBUdFI4Y2djelBYQ2QyN0NjaVA5Wk5McVduWU9ZK2p1aW1xRDloZXRv?= =?utf-8?B?SWc9PQ==?= X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7794b1b2-f9fa-4320-7466-08da8af2ffbf X-MS-Exchange-CrossTenant-AuthSource: MW2PR18MB2171.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Aug 2022 01:49:10.7552 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: a+NQsQ5sjkttSmFbpVviVT/is+mKP6xQg2WIFxHhrCSyQlXFj7OD5+OOFSgs69S9ajDNex+IwNPtAvvlry8DcA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR18MB4024 X-Proofpoint-ORIG-GUID: rFZb37EFI1wF5PTjdLzAm9yQ4l6d-mnT X-Proofpoint-GUID: rFZb37EFI1wF5PTjdLzAm9yQ4l6d-mnT X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-08-31_01,2022-08-30_01,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Ping. Any thoughts on this ? This is just clarification of existing assumptions for Inline Outbound that are being made. On 2022-08-22 8:08 PM, Nithin Dabilpuram wrote: > Clarify mbuf meta data needed for Outbound Inline processing. > Application needs to provide mbuf.l3_len and L3 type in > mbuf.ol_flags so that like tunnel mode using mbuf.l2_len, transport mode > can make use of l3_len and l3_type to determine perform > proper transport mode IPsec processing. > > Signed-off-by: Nithin Dabilpuram > --- > v3: > - Addressed comments on patch 4/5 and added acks. > v2: > - Modified ipsec-secgw to do ether type update for outbound path. > > doc/guides/nics/features.rst | 2 +- > lib/mbuf/rte_mbuf_core.h | 3 ++- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst > index 7f6cb91..b4a8e98 100644 > --- a/doc/guides/nics/features.rst > +++ b/doc/guides/nics/features.rst > @@ -431,7 +431,7 @@ protocol operations. See security library and PMD documentation for more details > > * **[uses] rte_eth_rxconf,rte_eth_rxmode**: ``offloads:RTE_ETH_RX_OFFLOAD_SECURITY``, > * **[uses] rte_eth_txconf,rte_eth_txmode**: ``offloads:RTE_ETH_TX_OFFLOAD_SECURITY``. > -* **[uses] mbuf**: ``mbuf.l2_len``. > +* **[uses] mbuf**: ``mbuf.l2_len``, ``mbuf.l3_len``, ``mbuf.ol_flags``. > * **[implements] rte_security_ops**: ``session_create``, ``session_update``, > ``session_stats_get``, ``session_destroy``, ``set_pkt_metadata``, ``get_userdata``, > ``capabilities_get``. > diff --git a/lib/mbuf/rte_mbuf_core.h b/lib/mbuf/rte_mbuf_core.h > index 3d6ddd6..b62a7c6 100644 > --- a/lib/mbuf/rte_mbuf_core.h > +++ b/lib/mbuf/rte_mbuf_core.h > @@ -267,7 +267,8 @@ extern "C" { > /** > * Request security offload processing on the TX packet. > * To use Tx security offload, the user needs to fill l2_len in mbuf > - * indicating L2 header size and where L3 header starts. > + * indicating L2 header size and where L3 header starts. Similarly, > + * l3_len should also be filled along with ol_flags reflecting current L3 type. > */ > #define RTE_MBUF_F_TX_SEC_OFFLOAD (1ULL << 43) > #define PKT_TX_SEC_OFFLOAD RTE_DEPRECATED(PKT_TX_SEC_OFFLOAD) \