From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id BE757559A; Thu, 11 Apr 2019 14:07:39 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Apr 2019 05:07:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,337,1549958400"; d="scan'208";a="290640555" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.84]) ([10.237.220.84]) by orsmga004.jf.intel.com with ESMTP; 11 Apr 2019 05:07:36 -0700 To: Reshma Pattan , dev@dpdk.org Cc: david.hunt@intel.com, stable@dpdk.org References: <20190411111336.2790-1-reshma.pattan@intel.com> From: "Burakov, Anatoly" Message-ID: <93cb87d3-cfcb-2bbc-ace1-e7ea12375bd3@intel.com> Date: Thu, 11 Apr 2019 13:07:36 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190411111336.2790-1-reshma.pattan@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] examples/vm_power_manager: fix overflowed value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Apr 2019 12:07:40 -0000 On 11-Apr-19 12:13 PM, Reshma Pattan wrote: > Fix the data type of last_branches, last_branch_misses > from unit32_t to uint64_t, and for hits_diff, miss_diff > from int to int64_t respectively to fix possible > overflow or truncation. > > Coverity issue: 337677 > Fixes: 4b1a631b8a ("examples/vm_power: add oob monitoring functions") > CC: david.hunt@intel.com > CC: stable@dpdk.org > > Signed-off-by: Reshma Pattan > --- Reviewed-by: Anatoly Burakov -- Thanks, Anatoly From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id E2FA9A0096 for ; Thu, 11 Apr 2019 14:07:41 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7AA105699; Thu, 11 Apr 2019 14:07:41 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id BE757559A; Thu, 11 Apr 2019 14:07:39 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Apr 2019 05:07:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,337,1549958400"; d="scan'208";a="290640555" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.84]) ([10.237.220.84]) by orsmga004.jf.intel.com with ESMTP; 11 Apr 2019 05:07:36 -0700 To: Reshma Pattan , dev@dpdk.org Cc: david.hunt@intel.com, stable@dpdk.org References: <20190411111336.2790-1-reshma.pattan@intel.com> From: "Burakov, Anatoly" Message-ID: <93cb87d3-cfcb-2bbc-ace1-e7ea12375bd3@intel.com> Date: Thu, 11 Apr 2019 13:07:36 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190411111336.2790-1-reshma.pattan@intel.com> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] examples/vm_power_manager: fix overflowed value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190411120736.auhp8Dknn_lS7ywJrADYzXHsOw3B5CrUdZRn_NEgiFc@z> On 11-Apr-19 12:13 PM, Reshma Pattan wrote: > Fix the data type of last_branches, last_branch_misses > from unit32_t to uint64_t, and for hits_diff, miss_diff > from int to int64_t respectively to fix possible > overflow or truncation. > > Coverity issue: 337677 > Fixes: 4b1a631b8a ("examples/vm_power: add oob monitoring functions") > CC: david.hunt@intel.com > CC: stable@dpdk.org > > Signed-off-by: Reshma Pattan > --- Reviewed-by: Anatoly Burakov -- Thanks, Anatoly