From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <anatoly.burakov@intel.com>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
by dpdk.org (Postfix) with ESMTP id 1CA247272
for <dev@dpdk.org>; Fri, 20 Apr 2018 09:55:23 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga004.jf.intel.com ([10.7.209.38])
by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
20 Apr 2018 00:55:22 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.49,300,1520924400"; d="scan'208";a="192985652"
Received: from rkotaba-mobl1.ger.corp.intel.com (HELO [10.252.23.81])
([10.252.23.81])
by orsmga004.jf.intel.com with ESMTP; 20 Apr 2018 00:55:21 -0700
To: Jianfeng Tan <jianfeng.tan@intel.com>, dev@dpdk.org
Cc: thomas@monjalon.net
References: <1524187312-129804-1-git-send-email-jianfeng.tan@intel.com>
<1524187312-129804-2-git-send-email-jianfeng.tan@intel.com>
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Message-ID: <93e616c5-292a-98ee-041b-462c098e90d0@intel.com>
Date: Fri, 20 Apr 2018 08:55:19 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
Thunderbird/52.7.0
MIME-Version: 1.0
In-Reply-To: <1524187312-129804-2-git-send-email-jianfeng.tan@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH 1/2] ipc: clearn up code
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Apr 2018 07:55:24 -0000
On 20-Apr-18 2:21 AM, Jianfeng Tan wrote:
> Following below commit, we change some internal function and variable
> names:
> commit ce3a7312357b ("eal: rename IPC request as synchronous one")
>
> Also use calloc to supersede malloc + memset for code clean up.
>
> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
> ---
In general,
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
However, i think it would be good to have it rebased/applied on top of
IPC coverity fixes, in particular because this patch uses strcpy instead
of instead of strlcpy.
--
Thanks,
Anatoly