From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Leyi Rong <leyi.rong@intel.com>,
qi.z.zhang@intel.com, bruce.richardson@intel.com,
beilei.xing@intel.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 1/3] net/i40e: remove devarg use-latest-supported-vec
Date: Wed, 13 Jan 2021 13:40:24 +0000 [thread overview]
Message-ID: <941277f6-1388-7cf6-8cd5-9c6c40cd5634@intel.com> (raw)
In-Reply-To: <20210107074420.6335-2-leyi.rong@intel.com>
On 1/7/2021 7:44 AM, Leyi Rong wrote:
> As eal parameter --force-max-simd-bitwidth is already introduced,
> to make it more clear when setting rx/tx function, remove
> devarg use-latest-supported-vec support.
>
> Signed-off-by: Leyi Rong <leyi.rong@intel.com>
<...>
> @@ -3154,20 +3124,33 @@ i40e_set_rx_function(struct rte_eth_dev *dev)
> break;
> }
> }
> +
> + if ((rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX2) == 1 ||
> + rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F) == 1) &&
> + rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_256)
> + use_avx2 = true;
> }
Hi Leyi,
The cpu flags, 'RTE_CPUFLAG_AVX2' & 'RTE_CPUFLAG_AVX512F', are only defined for
x86 and causing build error for other architectures.
And what about extracting that logic into a static inline function, this makes
code more clean, and in that function other architectures return 'use_avx2'
false straightaway and can do the checks only for x86?
next prev parent reply other threads:[~2021-01-13 13:40 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 2:19 [dpdk-dev] [PATCH 0/3] AVX512 vPMD on i40e Leyi Rong
2020-12-15 2:19 ` [dpdk-dev] [PATCH 1/3] net/i40e: remove devarg use-latest-supported-vec Leyi Rong
2020-12-15 2:19 ` [dpdk-dev] [PATCH 2/3] net/i40e: add AVX512 vector path Leyi Rong
2020-12-15 2:19 ` [dpdk-dev] [PATCH 3/3] net/i40e: optimize Tx by using AVX512 Leyi Rong
2021-01-07 7:44 ` [dpdk-dev] [PATCH v2 0/3] AVX512 vPMD on i40e Leyi Rong
2021-01-07 7:44 ` [dpdk-dev] [PATCH v2 1/3] net/i40e: remove devarg use-latest-supported-vec Leyi Rong
2021-01-13 6:12 ` Lu, Wenzhuo
2021-01-13 13:40 ` Ferruh Yigit [this message]
2021-01-07 7:44 ` [dpdk-dev] [PATCH v2 2/3] net/i40e: add AVX512 vector path Leyi Rong
2021-01-13 6:13 ` Lu, Wenzhuo
2021-01-07 7:44 ` [dpdk-dev] [PATCH v2 3/3] net/i40e: optimize Tx by using AVX512 Leyi Rong
2021-01-13 6:12 ` Lu, Wenzhuo
2021-01-13 9:53 ` [dpdk-dev] [PATCH v2 0/3] AVX512 vPMD on i40e Zhang, Qi Z
2021-01-14 6:39 ` [dpdk-dev] [PATCH v3 " Leyi Rong
2021-01-14 6:39 ` [dpdk-dev] [PATCH v3 1/3] net/i40e: remove devarg use-latest-supported-vec Leyi Rong
2021-01-15 13:36 ` Ferruh Yigit
2021-01-14 6:39 ` [dpdk-dev] [PATCH v3 2/3] net/i40e: add AVX512 vector path Leyi Rong
2021-01-14 6:39 ` [dpdk-dev] [PATCH v3 3/3] net/i40e: optimize Tx by using AVX512 Leyi Rong
2021-01-14 7:37 ` [dpdk-dev] [PATCH v3 0/3] AVX512 vPMD on i40e Zhang, Qi Z
2021-01-17 11:26 ` Odi Assli
2021-01-18 13:58 ` Rong, Leyi
2021-01-18 14:24 ` Ferruh Yigit
2021-01-18 14:53 ` Odi Assli
2021-01-18 16:36 ` Ferruh Yigit
2021-01-19 13:46 ` Ali Alnubani
2021-01-20 6:25 ` Tal Shnaiderman
2021-01-20 8:36 ` David Marchand
2021-01-20 9:18 ` Ferruh Yigit
2021-01-20 9:23 ` Thomas Monjalon
2021-01-20 9:53 ` David Marchand
2021-01-20 10:05 ` Ali Alnubani
2021-01-20 17:51 ` Ferruh Yigit
2021-01-20 18:04 ` Ferruh Yigit
2021-01-21 5:01 ` Kadam, Pallavi
2021-01-25 14:35 ` David Marchand
2021-01-26 16:17 ` Rong, Leyi
2021-01-26 16:22 ` Thomas Monjalon
2021-01-26 16:39 ` Ferruh Yigit
2021-01-26 16:48 ` Thomas Monjalon
2021-01-26 16:51 ` Ferruh Yigit
2021-01-28 20:35 ` Dmitry Kozlyuk
2021-01-28 21:24 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=941277f6-1388-7cf6-8cd5-9c6c40cd5634@intel.com \
--to=ferruh.yigit@intel.com \
--cc=beilei.xing@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=leyi.rong@intel.com \
--cc=qi.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).