From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: Heinrich Kuhn <heinrich.kuhn@netronome.com>, dev@dpdk.org
Cc: Simon Horman <simon.horman@corigine.com>, dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/nfp: improve PF probing logic
Date: Thu, 1 Jul 2021 17:33:13 +0300 [thread overview]
Message-ID: <941b636c-620a-1302-5dee-3ec120ebbf95@oktetlabs.ru> (raw)
In-Reply-To: <20210609140814.76977-1-heinrich.kuhn@netronome.com>
On 6/9/21 5:08 PM, Heinrich Kuhn wrote:
> When using rte_eth_dev_pci_generic_probe() during probing a
> rte_eth_dev will be created with the name field corresponding to the PCI
> address of the device. NFP4000/6000 devices only have a single PF (but
> potentially multiple physical ports). This means that in a simple two
> port example the rte_eth_devices[] array will be populated with two
> devices: 0000:02:00.0 and 0000:02:00.0_port1. This is inconsistent and
> not ideal. It will also cause issues when a secondary process tries to
> attach to these ports.
>
> This patch removes the use of rte_eth_dev_pci_generic_probe() and
> allocates eth_dev's for each physical port during PF initialization,
> giving them more consistent names.
>
> Fixes: 5e15e799d697 ("net/nfp: create separate entity for PF device")
>
> Signed-off-by: Heinrich Kuhn <heinrich.kuhn@netronome.com>
> Signed-off-by: Simon Horman <simon.horman@corigine.com>
Cc: stable@dpdk.org
Applied, thanks
prev parent reply other threads:[~2021-07-01 14:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 14:08 Heinrich Kuhn
2021-06-09 14:08 ` [dpdk-dev] [PATCH v2 2/2] net/nfp: fix PF secondary process probing Heinrich Kuhn
2021-07-01 14:33 ` Andrew Rybchenko
2021-07-01 14:33 ` Andrew Rybchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=941b636c-620a-1302-5dee-3ec120ebbf95@oktetlabs.ru \
--to=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=heinrich.kuhn@netronome.com \
--cc=simon.horman@corigine.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).