From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id CEE7DA0A0C;
	Thu,  1 Jul 2021 16:33:15 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 7ECB340141;
	Thu,  1 Jul 2021 16:33:15 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 3BA844003E;
 Thu,  1 Jul 2021 16:33:14 +0200 (CEST)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id B41057F504;
 Thu,  1 Jul 2021 17:33:13 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru B41057F504
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1625149993;
 bh=4XpX5PtZwQrkYO91oyimnvGT8qFPL2avbIkUnLDxe5o=;
 h=Subject:To:Cc:References:From:Date:In-Reply-To;
 b=uL/aEfu0xOd855HpAQfhXi0OJ2IpZTQ6gQHDTqNA7Vs9lFfBACtWRYqVf/V/vzJlw
 wSG4t2c4Q+p1dSHFuGBCnVG5jRneHHd5FYnPLGAi8zGqReRE6DjVKPCsdQJNiFQATs
 0l1+JwnMwKfDFqyuM0z6405BNma2HvfbLK2e24Gc=
To: Heinrich Kuhn <heinrich.kuhn@netronome.com>, dev@dpdk.org
Cc: Simon Horman <simon.horman@corigine.com>, dpdk stable <stable@dpdk.org>
References: <20210609140814.76977-1-heinrich.kuhn@netronome.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
Message-ID: <941b636c-620a-1302-5dee-3ec120ebbf95@oktetlabs.ru>
Date: Thu, 1 Jul 2021 17:33:13 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20210609140814.76977-1-heinrich.kuhn@netronome.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/nfp: improve PF probing logic
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 6/9/21 5:08 PM, Heinrich Kuhn wrote:
> When using rte_eth_dev_pci_generic_probe() during probing a
> rte_eth_dev will be created with the name field corresponding to the PCI
> address of the device. NFP4000/6000 devices only have a single PF (but
> potentially multiple physical ports). This means that in a simple two
> port example the rte_eth_devices[] array will be populated with two
> devices: 0000:02:00.0 and 0000:02:00.0_port1. This is inconsistent and
> not ideal. It will also cause issues when a secondary process tries to
> attach to these ports.
> 
> This patch removes the use of rte_eth_dev_pci_generic_probe() and
> allocates eth_dev's for each physical port during PF initialization,
> giving them more consistent names.
> 
> Fixes: 5e15e799d697 ("net/nfp: create separate entity for PF device")
> 
> Signed-off-by: Heinrich Kuhn <heinrich.kuhn@netronome.com>
> Signed-off-by: Simon Horman <simon.horman@corigine.com>

Cc: stable@dpdk.org

Applied, thanks